odo/pkg/service/crd_builder_test.go

package service

import (
	"encoding/json"
	"testing"

	"github.com/go-openapi/spec"
	"github.com/google/go-cmp/cmp"
)

func TestBuildCRDFromParams(t *testing.T) {
	tests := []struct {
		name    string
		crd     *spec.Schema
		params  map[string]string
		want    map[string]interface{}
		wantErr bool
	}{
		{
			name: "params ok without crd",
			params: map[string]string{
				"u":     "1",
				"a.b.c": "2",
				"a.b.d": "3",
				"a.B":   "4",
			},
			want: map[string]interface{}{
				"u": int64(1),
				"a": map[string]interface{}{
					"b": map[string]interface{}{
						"c": int64(2),
						"d": int64(3),
					},
					"B": int64(4),
				},
			},
			wantErr: false,
		},
		{
			name: "typed params without crd",
			params: map[string]string{
				"a.bool":   "true",
				"a.string": "foobar",
				"a.float":  "1.234",
			},
			want: map[string]interface{}{
				"a": map[string]interface{}{
					"bool":   true,
					"string": "foobar",
					"float":  1.234,
				},
			},
			wantErr: false,
		},
		{
			name: "typed params with crd",
			params: map[string]string{
				"a.bool":    "true",
				"a.string1": "foobar",
				"a.string2": "true",
				"a.string3": "1.234",
				"a.string4": "11",
				"a.float":   "1.234",
				"a.int":     "11",
			},
			crd: &spec.Schema{
				SchemaProps: spec.SchemaProps{
					Type: spec.StringOrArray{
						"object",
					},
					Properties: map[string]spec.Schema{
						"a": {
							SchemaProps: spec.SchemaProps{
								Type: spec.StringOrArray{
									"object",
								},
								Properties: map[string]spec.Schema{
									"bool": {
										SchemaProps: spec.SchemaProps{
											Type: spec.StringOrArray{
												"boolean",
											},
										},
									},
									"int": {
										SchemaProps: spec.SchemaProps{
											Type: spec.StringOrArray{
												"integer",
											},
										},
									},
									"float": {
										SchemaProps: spec.SchemaProps{
											Type: spec.StringOrArray{
												"number",
											},
										},
									},
									"string1": {
										SchemaProps: spec.SchemaProps{
											Type: spec.StringOrArray{
												"string",
											},
										},
									},
									"string2": {
										SchemaProps: spec.SchemaProps{
											Type: spec.StringOrArray{
												"string",
											},
										},
									},
									"string3": {
										SchemaProps: spec.SchemaProps{
											Type: spec.StringOrArray{
												"string",
											},
										},
									},
									"string4": {
										SchemaProps: spec.SchemaProps{
											Type: spec.StringOrArray{
												"string",
											},
										},
									},
								},
							},
						},
					},
				},
			},
			want: map[string]interface{}{
				"a": map[string]interface{}{
					"bool":    true,
					"string1": "foobar",
					"string2": "true",
					"string3": "1.234",
					"string4": "11",
					"float":   1.234,
					"int":     int64(11),
				},
			},
			wantErr: false,
		},
		{
			name: "params error map defined before value",
			params: map[string]string{
				"u":     "1",
				"a.b.c": "2",
				"a.b":   "3",
				"a.B":   "4",
			},
			want:    nil,
			wantErr: true,
		},
		{
			name: "params error value defined before map",
			params: map[string]string{
				"u":     "1",
				"a.b":   "2",
				"a.b.c": "3",
				"a.B":   "4",
			},
			want:    nil,
			wantErr: true,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			got, gotErr := BuildCRDFromParams(tt.params, tt.crd, "a group", "a version", "a kind")
			if gotErr != nil != tt.wantErr {
				t.Errorf("got err: %v, expected err: %v\n", gotErr != nil, tt.wantErr)
			}
			if gotErr == nil {
				if diff := cmp.Diff(tt.want, got["spec"]); diff != "" {
					t.Errorf("BuildCRDFromParams() mismatch (-want +got):\n%s", diff)
					jsonGot, _ := json.Marshal(got["spec"])
					jsonWant, _ := json.Marshal(tt.want)
					t.Errorf("\ngot:  %+v\n\nwant: %v\n", string(jsonGot), string(jsonWant))
				}
			}
		})
	}
}