mirror of
https://github.com/redhat-developer/odo.git
synced 2025-10-19 03:06:19 +03:00
* Add alizer library and test functionality <!-- Thank you for opening a PR! Here are some things you need to know before submitting: 1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines 2. Label this PR accordingly with the '/kind' line 3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests 4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review Documentation: If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs --> **What type of PR is this:** <!-- Add one of the following kinds: /kind bug /kind cleanup /kind tests /kind documentation Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind feature **What does this PR do / why we need it:** Adds the alizer library from https://github.com/redhat-developer/alizer/tree/main/go as part of our implementaion of `odo dev` and `odo init`. This builds upon @feloy 's PR located here: https://github.com/redhat-developer/odo/pull/5434 **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> Fixes # **PR acceptance criteria:** - [X] Unit test - [X] Integration test - [X] Documentation **How to test changes / Special notes to the reviewer:** N/A. Only function implementation * New alizer version * Use alizer for odo init * Add integration tests * Add Alizer to odo deploy * review * Ask component name for odo deploy * Fix unit test Co-authored-by: Charlie Drage <charlie@charliedrage.com>
219 lines
5.5 KiB
Go
219 lines
5.5 KiB
Go
package backend
|
|
|
|
import (
|
|
"path/filepath"
|
|
"reflect"
|
|
"runtime"
|
|
"testing"
|
|
|
|
"github.com/golang/mock/gomock"
|
|
"github.com/redhat-developer/odo/pkg/catalog"
|
|
"github.com/redhat-developer/odo/pkg/init/asker"
|
|
"github.com/redhat-developer/odo/pkg/testingutil/filesystem"
|
|
)
|
|
|
|
// Below functions are from:
|
|
// https://github.com/redhat-developer/alizer/blob/main/go/test/apis/language_recognizer_test.go
|
|
func GetTestProjectPath(folder string) string {
|
|
_, b, _, _ := runtime.Caller(0)
|
|
basepath := filepath.Dir(b)
|
|
return filepath.Join(basepath, "..", "..", "..", "tests/examples/source/", folder)
|
|
}
|
|
|
|
var types = []catalog.DevfileComponentType{
|
|
{
|
|
Name: "java-maven",
|
|
Language: "java",
|
|
ProjectType: "maven",
|
|
Tags: []string{"Java", "Maven"},
|
|
Registry: catalog.Registry{
|
|
Name: "registry1",
|
|
},
|
|
},
|
|
{
|
|
Name: "java-quarkus",
|
|
Language: "java",
|
|
ProjectType: "quarkus",
|
|
Tags: []string{"Java", "Quarkus"},
|
|
Registry: catalog.Registry{
|
|
Name: "registry1",
|
|
},
|
|
},
|
|
{
|
|
Name: "java-wildfly",
|
|
Language: "java",
|
|
ProjectType: "wildfly",
|
|
Tags: []string{"Java", "WildFly"},
|
|
Registry: catalog.Registry{
|
|
Name: "registry2",
|
|
},
|
|
},
|
|
{
|
|
Name: "nodejs",
|
|
Language: "javascript",
|
|
ProjectType: "nodejs",
|
|
Tags: []string{"NodeJS", "Express", "ubi8"},
|
|
Registry: catalog.Registry{
|
|
Name: "registry2",
|
|
},
|
|
},
|
|
{
|
|
Name: "python",
|
|
Language: "python",
|
|
ProjectType: "python",
|
|
Tags: []string{"Python", "pip"},
|
|
Registry: catalog.Registry{
|
|
Name: "registry3",
|
|
},
|
|
},
|
|
}
|
|
var list = catalog.DevfileComponentTypeList{
|
|
Items: types,
|
|
}
|
|
|
|
func TestDetectFramework(t *testing.T) {
|
|
|
|
type args struct {
|
|
path string
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
wantedDevfile string
|
|
wantedRegistry string
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "Detect Node.JS example",
|
|
args: args{
|
|
path: GetTestProjectPath("nodejs"),
|
|
},
|
|
wantedDevfile: "nodejs",
|
|
wantedRegistry: "registry2",
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "Detect java openjdk example",
|
|
args: args{
|
|
path: GetTestProjectPath("openjdk"),
|
|
},
|
|
wantedDevfile: "java-maven",
|
|
wantedRegistry: "registry1",
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "Detect python example",
|
|
args: args{
|
|
path: GetTestProjectPath("python"),
|
|
},
|
|
wantedDevfile: "python",
|
|
wantedRegistry: "registry3",
|
|
wantErr: false,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
ctrl := gomock.NewController(t)
|
|
askerClient := asker.NewMockAsker(ctrl)
|
|
catalogClient := catalog.NewMockClient(ctrl)
|
|
catalogClient.EXPECT().ListDevfileComponents("").Return(list, nil)
|
|
alizerClient := NewAlizerBackend(askerClient, catalogClient)
|
|
// Run function DetectFramework
|
|
detected, registry, err := alizerClient.detectFramework(tt.args.path)
|
|
|
|
if !tt.wantErr == (err != nil) {
|
|
t.Errorf("unexpected error %v, wantErr %v", err, tt.wantErr)
|
|
return
|
|
}
|
|
|
|
if detected.Name != tt.wantedDevfile {
|
|
t.Errorf("unexpected devfile %v, wantedDevfile %v", detected, tt.wantedDevfile)
|
|
}
|
|
if registry.Name != tt.wantedRegistry {
|
|
t.Errorf("unexpected registry %v, wantedRegistry %v", registry, tt.wantedRegistry)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestAlizerBackend_SelectDevfile(t *testing.T) {
|
|
type fields struct {
|
|
askerClient func(ctrl *gomock.Controller) asker.Asker
|
|
catalogClient func(ctrl *gomock.Controller) catalog.Client
|
|
}
|
|
type args struct {
|
|
flags map[string]string
|
|
fs filesystem.Filesystem
|
|
dir string
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
args args
|
|
wantLocation *DevfileLocation
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "devfile found and accepted",
|
|
fields: fields{
|
|
askerClient: func(ctrl *gomock.Controller) asker.Asker {
|
|
askerClient := asker.NewMockAsker(ctrl)
|
|
askerClient.EXPECT().AskCorrect().Return(true, nil)
|
|
return askerClient
|
|
},
|
|
catalogClient: func(ctrl *gomock.Controller) catalog.Client {
|
|
catalogClient := catalog.NewMockClient(ctrl)
|
|
catalogClient.EXPECT().ListDevfileComponents("").Return(list, nil)
|
|
return catalogClient
|
|
},
|
|
},
|
|
args: args{
|
|
fs: filesystem.DefaultFs{},
|
|
dir: GetTestProjectPath("nodejs"),
|
|
},
|
|
wantLocation: &DevfileLocation{
|
|
Devfile: "nodejs",
|
|
DevfileRegistry: "registry2",
|
|
},
|
|
},
|
|
{
|
|
name: "devfile found but not accepted",
|
|
fields: fields{
|
|
askerClient: func(ctrl *gomock.Controller) asker.Asker {
|
|
askerClient := asker.NewMockAsker(ctrl)
|
|
askerClient.EXPECT().AskCorrect().Return(false, nil)
|
|
return askerClient
|
|
},
|
|
catalogClient: func(ctrl *gomock.Controller) catalog.Client {
|
|
catalogClient := catalog.NewMockClient(ctrl)
|
|
catalogClient.EXPECT().ListDevfileComponents("").Return(list, nil)
|
|
return catalogClient
|
|
},
|
|
},
|
|
args: args{
|
|
fs: filesystem.DefaultFs{},
|
|
dir: GetTestProjectPath("nodejs"),
|
|
},
|
|
wantLocation: nil,
|
|
},
|
|
// TODO: Add test cases.
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
ctrl := gomock.NewController(t)
|
|
o := &AlizerBackend{
|
|
askerClient: tt.fields.askerClient(ctrl),
|
|
catalogClient: tt.fields.catalogClient(ctrl),
|
|
}
|
|
gotLocation, err := o.SelectDevfile(tt.args.flags, tt.args.fs, tt.args.dir)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("AlizerBackend.SelectDevfile() error = %v, wantErr %v", err, tt.wantErr)
|
|
return
|
|
}
|
|
if !reflect.DeepEqual(gotLocation, tt.wantLocation) {
|
|
t.Errorf("AlizerBackend.SelectDevfile() = %v, want %v", gotLocation, tt.wantLocation)
|
|
}
|
|
})
|
|
}
|
|
}
|