diff --git a/.eslintrc.js b/.eslintrc.js index 5d62513449..fbb81b8cf5 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -120,6 +120,20 @@ module.exports = { "no-useless-computed-key": "error", // https://eslint.org/docs/rules/rest-spread-spacing "rest-spread-spacing": ["error"], + // https://eslint.org/docs/rules/no-unused-expressions + "no-unused-expressions": "error", + // https://eslint.org/docs/rules/no-useless-concat + "no-useless-concat": "error", + // https://eslint.org/docs/rules/radix + "radix": "error", + // https://eslint.org/docs/rules/require-await + "require-await": "error", + // https://eslint.org/docs/rules/no-alert + "no-alert": "error", + // https://eslint.org/docs/rules/no-useless-constructor + "no-useless-constructor": "error", + // https://eslint.org/docs/rules/no-duplicate-imports + "no-duplicate-imports": "error", // https://eslint.org/docs/rules/no-implicit-coercion "no-implicit-coercion": "error", diff --git a/example/forms/src/ExampleFormController.js b/example/forms/src/ExampleFormController.js index 726c8ae857..655b656280 100644 --- a/example/forms/src/ExampleFormController.js +++ b/example/forms/src/ExampleFormController.js @@ -80,7 +80,7 @@ define( control: "button", csslass: "icon-save", click: function () { - window.alert("Save"); + console.log("Save"); } }, { @@ -88,7 +88,7 @@ define( csslass: "icon-x", description: "Button B", click: function () { - window.alert("Cancel"); + console.log("Cancel"); } }, { @@ -97,7 +97,7 @@ define( description: "Button C", disabled: true, click: function () { - window.alert("Delete"); + console.log("Delete"); } } ] diff --git a/src/adapter/services/LegacyObjectAPIInterceptor.js b/src/adapter/services/LegacyObjectAPIInterceptor.js index 60f57ca6a0..69805579be 100644 --- a/src/adapter/services/LegacyObjectAPIInterceptor.js +++ b/src/adapter/services/LegacyObjectAPIInterceptor.js @@ -72,21 +72,25 @@ define([ ObjectServiceProvider.prototype.create = async function (object) { let model = utils.toOldFormat(object); - return this.getPersistenceService().createObject( + let result = await this.getPersistenceService().createObject( this.getSpace(utils.makeKeyString(object.identifier)), object.identifier.key, model ); + + return result; }; ObjectServiceProvider.prototype.update = async function (object) { let model = utils.toOldFormat(object); - return this.getPersistenceService().updateObject( + let result = await this.getPersistenceService().updateObject( this.getSpace(utils.makeKeyString(object.identifier)), object.identifier.key, model ); + + return result; }; /** diff --git a/src/plugins/condition/components/Criterion.vue b/src/plugins/condition/components/Criterion.vue index ee5e58b34f..fb317e4db1 100644 --- a/src/plugins/condition/components/Criterion.vue +++ b/src/plugins/condition/components/Criterion.vue @@ -108,8 +108,7 @@