alihan/openmct
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Common UI] Fix FullscreenActionSpec

Browse Source 
Fix FullscreenActionSpec such that it will execute on
command line; the global screenfull dependency behaves
differently during attempts to spy on methods from
the command line build, so replace it entirely.

Concludes work on WTD-574 in preparation to submit for
review.
This commit is contained in:
Victor Woeltjen
2014-11-25 23:08:47 -08:00
parent b0cb8a8455
commit 0bacc03e58
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
platform/commonUI/browse/test/windowing/FullscreenActionSpec.js
View File

@@ -1,4 +1,4 @@
/*global define,Promise,describe,it,expect,beforeEach,waitsFor,jasmine,afterEach,screenfull*/ /*global define,Promise,describe,it,expect,beforeEach,waitsFor,jasmine,afterEach,window*/
/** /**
* MCTRepresentationSpec. Created by vwoeltje on 11/6/14. * MCTRepresentationSpec. Created by vwoeltje on 11/6/14.
@@ -10,25 +10,26 @@ define(
describe("The fullscreen action", function () { describe("The fullscreen action", function () {
var action, var action,
oldToggle; oldScreenfull;
beforeEach(function () { beforeEach(function () {
// Screenfull is not shimmed or injected, so // Screenfull is not shimmed or injected, so
// we need to spy on it in the global scope. // we need to spy on it in the global scope.
oldToggle = screenfull.toggle; oldScreenfull = window.screenfull;
screenfull.toggle = jasmine.createSpy("toggle"); window.screenfull = {};
window.screenfull.toggle = jasmine.createSpy("toggle");
action = new FullscreenAction({}); action = new FullscreenAction({});
}); });
afterEach(function () { afterEach(function () {
screenfull.toggle = oldToggle; window.screenfull = oldScreenfull;
}); });
it("toggles fullscreen mode when performed", function () { it("toggles fullscreen mode when performed", function () {
action.perform(); action.perform();
expect(screenfull.toggle).toHaveBeenCalled(); expect(window.screenfull.toggle).toHaveBeenCalled();
}); });
it("provides displayable metadata", function () { it("provides displayable metadata", function () {