From 0c4d422e2d26f04c98a32e467a939e7d92105ca0 Mon Sep 17 00:00:00 2001
From: Charles Hacskaylo <charlesh88@gmail.com>
Date: Fri, 23 Oct 2015 11:13:51 -0700
Subject: [PATCH] [Frontend] Manual re-do of collapse/expand panes

open #90
Refactored templates to move all split-pane elements into browse.html;
---
 .../browse/res/templates/browse-object.html   | 59 ++++++++-----------
 .../commonUI/browse/res/templates/browse.html | 20 +++++--
 2 files changed, 39 insertions(+), 40 deletions(-)

diff --git a/platform/commonUI/browse/res/templates/browse-object.html b/platform/commonUI/browse/res/templates/browse-object.html
index 9464aaee45..9dc1c8f83a 100644
--- a/platform/commonUI/browse/res/templates/browse-object.html
+++ b/platform/commonUI/browse/res/templates/browse-object.html
@@ -20,42 +20,29 @@
  at runtime from the About dialog for additional information.
 -->
 <span ng-controller="BrowseObjectController">
-    <mct-split-pane class='l-object-and-inspector contents abs' anchor='right'>
-        <div class='split-pane-component t-object pane left'>
-            <div class="object-browse-bar bar l-flex">
-                <div class="items-select left">
-                    <mct-representation key="'back-arrow'"
-                                        mct-object="domainObject"
-                                        class="l-back"></mct-representation>
-                    <mct-representation key="'object-header'" mct-object="domainObject">
-                    </mct-representation>
-                </div>
-                <div class="btn-bar right">
-                    <mct-representation key="'switcher'"
-                                        mct-object="domainObject"
-                                        ng-model="representation">
-                    </mct-representation>
-                    <!-- Temporarily, on mobile, the action buttons are hidden-->
-                    <mct-representation key="'action-group'"
-                                        mct-object="domainObject"
-                                        parameters="{ category: 'view-control' }"
-                                        class="mobile-hide">
-                    </mct-representation>
-                </div>
-            </div>
-            <mct-representation key="representation.selected.key"
-                                mct-object="representation.selected.key && domainObject"
-                                class="abs object-holder">
+    <div class="object-browse-bar bar l-flex">
+        <div class="items-select left">
+            <mct-representation key="'back-arrow'"
+                                mct-object="domainObject"
+                                class="l-back"></mct-representation>
+            <mct-representation key="'object-header'" mct-object="domainObject">
             </mct-representation>
-            <a class="mini-tab anchor-right mobile-hide toggle-pane toggle-inspect"
-               ng-click="ngModel.toggle()"
-               ng-class="{ collapsed : !ngModel.visible() }"></a>
-        </div><!--/ t-object -->
-
-        <mct-splitter class="splitter-inspect mobile-hide"></mct-splitter>
-
-        <div class="split-pane-component t-inspect pane right mobile-hide">
-            <!--Inspector goes here-->
         </div>
-    </mct-split-pane><!--/ t-object-and-inspector -->
+        <div class="btn-bar right">
+            <mct-representation key="'switcher'"
+                                mct-object="domainObject"
+                                ng-model="representation">
+            </mct-representation>
+            <!-- Temporarily, on mobile, the action buttons are hidden-->
+            <mct-representation key="'action-group'"
+                                mct-object="domainObject"
+                                parameters="{ category: 'view-control' }"
+                                class="mobile-hide">
+            </mct-representation>
+        </div>
+    </div>
+    <mct-representation key="representation.selected.key"
+                        mct-object="representation.selected.key && domainObject"
+                        class="abs object-holder">
+    </mct-representation>
 </span>
diff --git a/platform/commonUI/browse/res/templates/browse.html b/platform/commonUI/browse/res/templates/browse.html
index c1eff0b907..d59ac222c0 100644
--- a/platform/commonUI/browse/res/templates/browse.html
+++ b/platform/commonUI/browse/res/templates/browse.html
@@ -58,10 +58,22 @@
                 <div class='holder abs l-mobile' id='content-area'
                      ng-controller="PaneController as modelPaneInspect"
                      ng-class="modelPaneInspect.visible() ? 'pane-inspect-showing' : 'pane-inspect-hidden'">
-                    <mct-representation mct-object="navigatedObject"
-                                        key="'browse-object'"
-                                        ng-model="modelPaneInspect">
-                    </mct-representation>
+                    <mct-split-pane class='l-object-and-inspector contents abs' anchor='right'>
+                        <div class='split-pane-component t-object pane left'>
+                            <a class="mini-tab anchor-right mobile-hide toggle-pane toggle-inspect"
+                               ng-click="modelPaneInspect.toggle()"
+                               ng-class="{ collapsed : !modelPaneInspect.visible() }"></a>
+                            <mct-representation mct-object="navigatedObject"
+                                                key="'browse-object'">
+                            </mct-representation>
+                        </div>
+
+                        <mct-splitter class="splitter-inspect mobile-hide"></mct-splitter>
+
+                        <div class="split-pane-component t-inspect pane right mobile-hide">
+                            <!--Inspector goes here-->
+                        </div>
+                    </mct-split-pane>
                 </div>
             </div>
         </mct-split-pane>