From 1525657ac2caab381707bd382556b6772c6ec358 Mon Sep 17 00:00:00 2001 From: larkin Date: Thu, 11 Jun 2015 12:50:03 -0700 Subject: [PATCH] [Task] Remove TODOS --- platform/entanglement/test/services/LocationServiceSpec.js | 4 ---- platform/entanglement/test/services/MockCopyService.js | 1 - platform/entanglement/test/services/MockLinkService.js | 1 - platform/entanglement/test/services/MockMoveService.js | 1 - 4 files changed, 7 deletions(-) diff --git a/platform/entanglement/test/services/LocationServiceSpec.js b/platform/entanglement/test/services/LocationServiceSpec.js index 0fe194edff..0d565f9a9d 100644 --- a/platform/entanglement/test/services/LocationServiceSpec.js +++ b/platform/entanglement/test/services/LocationServiceSpec.js @@ -18,8 +18,6 @@ define( 'dialogService', ['getUserInput'] ); - // TODO: replace the dialogServicePromise with a deferred and - // get rid of chainedPromise. dialogServicePromise = jasmine.createSpyObj( 'dialogServicePromise', ['then'] @@ -72,8 +70,6 @@ define( }); it("returns a promise", function () { - // This test is testing that chainedPromise is returned. - // TODO: have better assumptions with deferred objects. expect(locationResult.then).toBeDefined(); }); diff --git a/platform/entanglement/test/services/MockCopyService.js b/platform/entanglement/test/services/MockCopyService.js index cdd52920dd..3d020a9c48 100644 --- a/platform/entanglement/test/services/MockCopyService.js +++ b/platform/entanglement/test/services/MockCopyService.js @@ -45,7 +45,6 @@ define( callExtensions, spy; - // TODO: return a proper deferred to support composing. performPromise = jasmine.createSpyObj( 'performPromise', ['then'] diff --git a/platform/entanglement/test/services/MockLinkService.js b/platform/entanglement/test/services/MockLinkService.js index cb406464a3..0609ccbec3 100644 --- a/platform/entanglement/test/services/MockLinkService.js +++ b/platform/entanglement/test/services/MockLinkService.js @@ -45,7 +45,6 @@ define( callExtensions, spy; - // TODO: return a proper deferred to support composing. performPromise = jasmine.createSpyObj( 'performPromise', ['then'] diff --git a/platform/entanglement/test/services/MockMoveService.js b/platform/entanglement/test/services/MockMoveService.js index 375da8874f..e24401e96f 100644 --- a/platform/entanglement/test/services/MockMoveService.js +++ b/platform/entanglement/test/services/MockMoveService.js @@ -45,7 +45,6 @@ define( callExtensions, spy; - // TODO: return a proper deferred to support composing. performPromise = jasmine.createSpyObj( 'performPromise', ['then']