[Clocks/Timers] Update code style for controllers

platform/features/clock/src/controllers/ClockController.js

@@ -30,19 +30,21 @@ define(
          * Controller for views of a Clock domain object.
          *
          * @constructor
+         * @memberof platform/features/clock
+         * @param {angular.Scope} $scope the Angular scope
+         * @param {platform/features/clock.TickerService} tickerService
+         *        a service used to align behavior with clock ticks
          */
         function ClockController($scope, tickerService) {
-            var text,
-                ampm,
-                use24,
-                lastTimestamp,
+            var lastTimestamp,
                 unlisten,
-                timeFormat;
+                timeFormat,
+                self = this;
 
             function update() {
                 var m = moment.utc(lastTimestamp);
-                text = timeFormat && m.format(timeFormat);
-                ampm = m.format("A"); // Just the AM or PM part
+                self.textValue = timeFormat && m.format(timeFormat);
+                self.ampmValue = m.format("A"); // Just the AM or PM part
             }
 
             function tick(timestamp) {
@@ -56,8 +58,8 @@ define(
                 if (clockFormat !== undefined) {
                     baseFormat = clockFormat[0];
 
-                    use24 = clockFormat[1] === 'clock24';
-                    timeFormat = use24 ?
+                    self.use24 = clockFormat[1] === 'clock24';
+                    timeFormat = self.use24 ?
                             baseFormat.replace('hh', "HH") : baseFormat;
 
                     update();
@@ -69,32 +71,32 @@ define(
             // Listen for clock ticks ... and stop listening on destroy
             unlisten = tickerService.listen(tick);
             $scope.$on('$destroy', unlisten);
-
-            return {
-                /**
-                 * Get the clock's time zone, as displayable text.
-                 * @returns {string}
-                 */
-                zone: function () {
-                    return "UTC";
-                },
-                /**
-                 * Get the current time, as displayable text.
-                 * @returns {string}
-                 */
-                text: function () {
-                    return text;
-                },
-                /**
-                 * Get the text to display to qualify a time as AM or PM.
-                 * @returns {string}
-                 */
-                ampm: function () {
-                    return use24 ? '' : ampm;
-                }
-            };
         }
 
+        /**
+         * Get the clock's time zone, as displayable text.
+         * @returns {string}
+         */
+        ClockController.prototype.zone = function () {
+            return "UTC";
+        };
+
+        /**
+         * Get the current time, as displayable text.
+         * @returns {string}
+         */
+        ClockController.prototype.text = function () {
+            return this.textValue;
+        };
+
+        /**
+         * Get the text to display to qualify a time as AM or PM.
+         * @returns {string}
+         */
+        ClockController.prototype.ampm = function () {
+            return this.use24 ? '' : this.ampmValue;
+        };
+
         return ClockController;
     }
 );