[Clocks/Timers] Update code style for controllers

platform/features/clock/src/controllers/TimerController.js

@@ -33,26 +33,30 @@ define(
          * Controller for views of a Timer domain object.
          *
          * @constructor
+         * @memberof platform/features/clock
+         * @param {angular.Scope} $scope the Angular scope
+         * @param $window Angular-provided window object
+         * @param {Function} now a function which returns the current
+         *        time (typically wrapping `Date.now`)
          */
         function TimerController($scope, $window, now) {
             var timerObject,
-                relevantAction,
-                sign = '',
-                text = '',
                 formatter,
                 active = true,
                 relativeTimestamp,
-                lastTimestamp;
+                lastTimestamp,
+                self = this;
 
             function update() {
                 var timeDelta = lastTimestamp - relativeTimestamp;
 
                 if (formatter && !isNaN(timeDelta)) {
-                    text = formatter(timeDelta);
-                    sign = timeDelta < 0 ? "-" : timeDelta >= 1000 ? "+" : "";
+                    self.textValue = formatter(timeDelta);
+                    self.signValue = timeDelta < 0 ? "-" :
+                            timeDelta >= 1000 ? "+" : "";
                 } else {
-                    text = "";
-                    sign = "";
+                    self.textValue = "";
+                    self.signValue = "";
                 }
             }
 
@@ -75,7 +79,7 @@ define(
                 updateFormat(formatKey);
                 updateTimestamp(timestamp);
 
-                relevantAction = actionCapability &&
+                self.relevantAction = actionCapability &&
                     actionCapability.getActions(actionKey)[0];
 
                 update();
@@ -92,13 +96,14 @@ define(
             }
 
             function tick() {
-                var lastSign = sign, lastText = text;
+                var lastSign = self.signValue,
+                    lastText = self.textValue;
                 lastTimestamp = now();
                 update();
                 // We're running in an animation frame, not in a digest cycle.
                 // We need to trigger a digest cycle if our displayable data
                 // changes.
-                if (lastSign !== sign || lastText !== text) {
+                if (lastSign !== self.signValue || lastText !== self.textValue) {
                     $scope.$apply();
                 }
                 if (active) {
@@ -117,51 +122,58 @@ define(
                 active = false;
             });
 
-            return {
-                /**
-                 * Get the glyph to display for the start/restart button.
-                 * @returns {string} glyph to display
-                 */
-                buttonGlyph: function () {
-                    return relevantAction ?
-                            relevantAction.getMetadata().glyph : "";
-                },
-                /**
-                 * Get the text to show for the start/restart button
-                 * (e.g. in a tooltip)
-                 * @returns {string} name of the action
-                 */
-                buttonText: function () {
-                    return relevantAction ?
-                            relevantAction.getMetadata().name : "";
-                },
-                /**
-                 * Perform the action associated with the start/restart button.
-                 */
-                clickButton: function () {
-                    if (relevantAction) {
-                        relevantAction.perform();
-                        updateObject($scope.domainObject);
-                    }
-                },
-                /**
-                 * Get the sign (+ or -) of the current timer value, as
-                 * displayable text.
-                 * @returns {string} sign of the current timer value
-                 */
-                sign: function () {
-                    return sign;
-                },
-                /**
-                 * Get the text to display for the current timer value.
-                 * @returns {string} current timer value
-                 */
-                text: function () {
-                    return text;
-                }
-            };
+            this.signValue = '';
+            this.textValue = '';
+            this.updateObject = updateObject;
         }
 
+        /**
+         * Get the glyph to display for the start/restart button.
+         * @returns {string} glyph to display
+         */
+        TimerController.prototype.buttonGlyph = function () {
+            return this.relevantAction ?
+                    this.relevantAction.getMetadata().glyph : "";
+        };
+
+        /**
+         * Get the text to show for the start/restart button
+         * (e.g. in a tooltip)
+         * @returns {string} name of the action
+         */
+        TimerController.prototype.buttonText = function () {
+            return this.relevantAction ?
+                    this.relevantAction.getMetadata().name : "";
+        };
+
+
+        /**
+         * Perform the action associated with the start/restart button.
+         */
+        TimerController.prototype.clickButton = function () {
+            if (this.relevantAction) {
+                this.relevantAction.perform();
+                this.updateObject(this.$scope.domainObject);
+            }
+        };
+
+        /**
+         * Get the sign (+ or -) of the current timer value, as
+         * displayable text.
+         * @returns {string} sign of the current timer value
+         */
+        TimerController.prototype.sign = function () {
+            return this.signValue;
+        };
+
+        /**
+         * Get the text to display for the current timer value.
+         * @returns {string} current timer value
+         */
+        TimerController.prototype.text = function () {
+            return this.textValue;
+        };
+
         return TimerController;
     }
 );