Update test specs to use Jasmine 3 (#2089)
* Updated Karma and Jasmine versions * Added DOMObserver class. Supports promise-based testing of DOM changes Update asynchronous test specs to use promises or done() instead of waitsFor/runs * Modified ActionCapability to duplicate context object properties as own properties for better object equality comparisons * Global find + replace to fix syntax issues * Fixed various issues caused by non-deterministic runtime order of tests in Jasmine 3. Fixed issues caused by changes to determination of object equality * Addressed review comments * Resolved merge conflicts with master * Fixed style errors * Use spy.calls.count() instead of manually tracking
This commit is contained in:
committed by
Pete Richards
parent
013eba744d
commit
433dee0314
@@ -46,12 +46,12 @@ define([
|
||||
|
||||
splashElement.className = 'some-class-name';
|
||||
|
||||
$document.querySelectorAll.andReturn([splashElement]);
|
||||
$document.querySelectorAll.and.returnValue([splashElement]);
|
||||
});
|
||||
|
||||
describe('when element exists', function () {
|
||||
beforeEach(function () {
|
||||
$document.querySelectorAll.andReturn([splashElement]);
|
||||
$document.querySelectorAll.and.returnValue([splashElement]);
|
||||
return new SplashScreenManager([$document]);
|
||||
});
|
||||
|
||||
@@ -69,14 +69,14 @@ define([
|
||||
.not
|
||||
.toHaveBeenCalled();
|
||||
|
||||
splashElement.addEventListener.mostRecentCall.args[1]();
|
||||
splashElement.addEventListener.calls.mostRecent().args[1]();
|
||||
expect(splashElement.parentNode.removeChild)
|
||||
.toHaveBeenCalledWith(splashElement);
|
||||
});
|
||||
});
|
||||
|
||||
it('does not error when element doesn\'t exist', function () {
|
||||
$document.querySelectorAll.andReturn([]);
|
||||
$document.querySelectorAll.and.returnValue([]);
|
||||
|
||||
function run() {
|
||||
return new SplashScreenManager([$document]);
|
||||
|
||||
Reference in New Issue
Block a user