From 43d497e069052e96265e80eb4c0089acda13e5b8 Mon Sep 17 00:00:00 2001 From: Victor Woeltjen Date: Thu, 11 Feb 2016 09:49:26 -0800 Subject: [PATCH] [Create] Clarify function naming Per review feedback, https://github.com/nasa/openmctweb/pull/666#discussion_r52625960 --- platform/entanglement/src/services/CopyService.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/platform/entanglement/src/services/CopyService.js b/platform/entanglement/src/services/CopyService.js index 0df33de71c..56155f0b77 100644 --- a/platform/entanglement/src/services/CopyService.js +++ b/platform/entanglement/src/services/CopyService.js @@ -83,7 +83,9 @@ define( CopyService.prototype.perform = function (domainObject, parent, filter) { var policyService = this.policyService; - function completeFilter(domainObject) { + // Combines caller-provided filter (if any) with the + // baseline behavior of respecting creation policy. + function filterWithPolicy(domainObject) { return (!filter || filter(domainObject)) && policyService.allow( "creation", @@ -95,7 +97,7 @@ define( return new CopyTask( domainObject, parent, - completeFilter, + filterWithPolicy, this.$q ).perform(); } else {