[Time Conductor] Prevent route change when time conductor values change (#1342)

* [Time Conductor] Prevent route change on setting search parameters. fixes #1341

* [Inspector] Fixed incorrect listener deregistration which was causing errors on scope destruction

* Bare route is redirect to browse

* [Browse] handle routing without breaking $route

Manage route transitions such that route changes are properly
prevented and navigation events occur while still updating the url.

Resolves a number of issues where path and search updates had
to be supported in a very hacky manner.

https://github.com/nasa/openmct/pull/1342

* [URL] Set search without hacks

Changes in previous commit allow the search parameters to be modified
without accidentally triggering a page reload.

https://github.com/nasa/openmct/pull/1342

* [Views] Update on location changes

If the user has a bookmark or tries to change the current view of an
object by specifying view=someView as a search parameter, the change would
not previously take effect.  This resolves that bug.

https://github.com/nasa/openmct/pull/1342

* [TC] Set query params to undefined

Instead of setting params to null, which would eventually result in those
parameters equaling undefined, set them to undefined to skip the extra
step.

https://github.com/nasa/openmct/pull/1342

* [Instantiate] Instantiate objects with context

Add context to instantiate objects so that they can be navigated
to for editing.

https://github.com/nasa/openmct/pull/1342

* [Tests] Update specs

Update specs to match new expectations.

* [Style] Fix style

* [TC] Remove unused dependency

Remove $route dependency from time conductor controller as it was
not being used.  Resolves review comments.

https://github.com/nasa/openmct/pull/1342#pullrequestreview-11449260

platform/core/src/capabilities/InstantiationCapability.js

@@ -68,7 +68,13 @@ define(
             this.instantiateFn = this.instantiateFn ||
                 this.$injector.get("instantiate");
 
-            return this.instantiateFn(model, id);
+            var newObject = this.instantiateFn(model, id);
+
+            this.contextualizeFn = this.contextualizeFn ||
+                this.$injector.get("contextualize");
+
+
+            return this.contextualizeFn(newObject, this.domainObject);
         };
 
         /**

platform/core/test/capabilities/InstantiationCapabilitySpec.js

@@ -28,6 +28,7 @@ define(
             var mockInjector,
                 mockIdentifierService,
                 mockInstantiate,
+                mockContextualize,
                 mockIdentifier,
                 mockNow,
                 mockDomainObject,
@@ -36,6 +37,7 @@ define(
             beforeEach(function () {
                 mockInjector = jasmine.createSpyObj("$injector", ["get"]);
                 mockInstantiate = jasmine.createSpy("instantiate");
+                mockContextualize = jasmine.createSpy("contextualize");
                 mockIdentifierService = jasmine.createSpyObj(
                     'identifierService',
                     ['parse', 'generate']
@@ -50,8 +52,10 @@ define(
                 );
 
                 mockInjector.get.andCallFake(function (key) {
-                    return key === 'instantiate' ?
-                            mockInstantiate : undefined;
+                    return {
+                        'instantiate': mockInstantiate,
+                        'contextualize': mockContextualize
+                    }[key];
                 });
                 mockIdentifierService.parse.andReturn(mockIdentifier);
                 mockIdentifierService.generate.andReturn("some-id");
@@ -72,7 +76,7 @@ define(
                 expect(instantiation.invoke).toBe(instantiation.instantiate);
             });
 
-            it("uses the instantiate service to create domain objects", function () {
+            it("uses instantiate and contextualize to create domain objects", function () {
                 var mockDomainObj = jasmine.createSpyObj('domainObject', [
                     'getId',
                     'getModel',
@@ -81,6 +85,9 @@ define(
                     'hasCapability'
                 ]), testModel = { someKey: "some value" };
                 mockInstantiate.andReturn(mockDomainObj);
+                mockContextualize.andCallFake(function (x) {
+                    return x;
+                });
                 expect(instantiation.instantiate(testModel))
                     .toBe(mockDomainObj);
                 expect(mockInstantiate)
@@ -88,6 +95,8 @@ define(
                         someKey: "some value",
                         modified: mockNow()
                     }, jasmine.any(String));
+                expect(mockContextualize)
+                    .toHaveBeenCalledWith(mockDomainObj, mockDomainObject);
             });
 
         });