From 471adde923d2c322eb7ed6ffe7b6d63e1c4dc1c0 Mon Sep 17 00:00:00 2001
From: David Hudson <david@few.io>
Date: Tue, 20 Sep 2016 17:59:25 +0900
Subject: [PATCH] [Swimlanes] Check for valid swimlane

Issue #599. Also switches class toggle from scope based to element
based.
---
 .../timeline/res/templates/timeline.html      |  3 ++-
 .../src/directives/MCTResourceGraphDrop.js    | 21 ++++++++++++++-----
 2 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/platform/features/timeline/res/templates/timeline.html b/platform/features/timeline/res/templates/timeline.html
index 2a87921f29..942a3f0e8f 100644
--- a/platform/features/timeline/res/templates/timeline.html
+++ b/platform/features/timeline/res/templates/timeline.html
@@ -77,7 +77,8 @@
         <mct-splitter></mct-splitter>
 
         <!-- BOTTOM PANE RESOURCE LEGEND -->
-        <div mct-resource-graph-drop class="split-pane-component abs l-timeline-pane t-pane-h l-pane-btm s-timeline-resource-legend l-timeline-resource-legend" ng-class="{'drop-over': resourceGraphLegendropOver }">
+        <div mct-resource-graph-drop
+             class="split-pane-component abs l-timeline-pane t-pane-h l-pane-btm s-timeline-resource-legend l-timeline-resource-legend">
             <div class="l-title s-title">{{ngModel.title}}Resource Graph Legend</div>
             <div class="l-legend-items legend">
                 <mct-include key="'timeline-legend-item'"
diff --git a/platform/features/timeline/src/directives/MCTResourceGraphDrop.js b/platform/features/timeline/src/directives/MCTResourceGraphDrop.js
index 6dbb4437b7..86ccabb2e6 100644
--- a/platform/features/timeline/src/directives/MCTResourceGraphDrop.js
+++ b/platform/features/timeline/src/directives/MCTResourceGraphDrop.js
@@ -36,8 +36,15 @@ define(
             function link(scope, element, attrs) {
                 // Handle dragover
                 element.on('dragover', function (e) {
-                    scope.resourceGraphLegendropOver = true;
-                    scope.$apply();
+                    var swimlane = dndService.getData(
+                        SwimlaneDragConstants.TIMELINE_SWIMLANE_DRAG_TYPE
+                    );
+
+                    if (typeof swimlane !== "undefined" && !swimlane.graph()) {
+                        element.addClass('drop-over');
+                        scope.$apply();
+                        e.preventDefault();
+                    }
                 });
                 // Handle drops
                 element.on('drop', function (e) {
@@ -45,15 +52,19 @@ define(
                         SwimlaneDragConstants.TIMELINE_SWIMLANE_DRAG_TYPE
                     );
 
+                    element.removeClass('drop-over');
+
                     // Only toggle if the graph isn't already set
-                    if (!swimlane.graph()) {
+                    if (typeof swimlane !== "undefined" && !swimlane.graph()) {
                         swimlane.toggleGraph();
+                        e.preventDefault();
                     }
                 });
                 // Clear highlights when drag leaves this swimlane
-                element.on('dragleave', function () {
-                    scope.resourceGraphLegendropOver = false;
+                element.on('dragleave', function (e) {
+                    element.removeClass('drop-over');
                     scope.$apply();
+                    e.preventDefault();
                 });
             }