alihan/openmct
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Creation] Simplify creationService

Browse Source 
Add the newly-created domain object directly, instead of via
its id.
This commit is contained in:
Victor Woeltjen
2015-11-05 15:36:33 -08:00
parent 3f26be885e
commit 62b9eb5180
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
platform/commonUI/browse/src/creation/CreationService.js
View File

@@ -75,10 +75,10 @@ define(
// Add the newly-created object's id to the parent's // Add the newly-created object's id to the parent's
// composition, so that it will subsequently appear // composition, so that it will subsequently appear
// as a child contained by that parent. // as a child contained by that parent.
function addToComposition(id, parent, parentPersistence) { function addToComposition() {
var compositionCapability = parent.getCapability('composition'), var compositionCapability = parent.getCapability('composition'),
addResult = compositionCapability && addResult = compositionCapability &&
compositionCapability.add(id); compositionCapability.add(newObject);
return self.$q.when(addResult).then(function (result) { return self.$q.when(addResult).then(function (result) {
if (!result) { if (!result) {
@@ -86,7 +86,7 @@ define(
return undefined; return undefined;
} }
return parentPersistence.persist().then(function () { return persistence.persist().then(function () {
return result; return result;
}); });
}); });
@@ -100,10 +100,7 @@ define(
} }
// Persist the new object, then add it to composition. // Persist the new object, then add it to composition.
return newObjectPersistence.persist().then(function () { return newObjectPersistence.persist().then(addToComposition);
var id = newObject.getId();
return addToComposition(id, parent, persistence);
});
}; };