Fix existing eslint warnings, configure eslint to fail on warning (#5258)
* [e2e] Remove unnecessary step with force click * `test.skip()` -> `test.fixme()` * Bypass `no-wait-for-timeout` rule for visual tests * Fail lint step if warnings > 0 * Set default value for `imageUrl` - Resolves `vue/require-default-prop` warning * Disable eslint rule `you-dont-need-lodash-underscore/get` - Disable the rule for now as the implementation they suggest doesn't match lodash `_.get()` functionality, and fails a bunch of our tests. See https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/issues/311 and https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/issues/294 * Disable `no-wait-for-timeout` warning for `visual` folder * Add rule exception and comments in logPlot test - Add exception and FIXME for timeout - Add comment on fixme test to discourage community contribution * clean up tests - remove unnecessary awaits - update locators to use data-testid where possible - remove unnecessary wait * Wait for image count condition instead of timeout * code review comments: use expect.poll() * readability * .fixme() + comment instead of .skip() * disable `.skip()` warning for memleak test suite
This commit is contained in:
@@ -43,8 +43,6 @@ test.describe('forms set', () => {
|
||||
await page.fill('text=Properties Title Notes >> input[type="text"]', '');
|
||||
// Press Tab
|
||||
await page.press('text=Properties Title Notes >> input[type="text"]', 'Tab');
|
||||
// Click text=OK Cancel
|
||||
await page.click('text=OK', { force: true });
|
||||
|
||||
const okButton = page.locator('text=OK');
|
||||
|
||||
|
||||
Reference in New Issue
Block a user