From 97d80f57cc8554904374396e60be965c2b4c8574 Mon Sep 17 00:00:00 2001 From: Charles Hacskaylo Date: Tue, 21 Jul 2020 21:01:38 -0700 Subject: [PATCH] UI enhancements (#3217) * UI enhancements for #3176 - Large overlay now displays fullscreen; * UI enhancements for #3176 - Adding new ".is-in-small-container" CSS - VERY WIP! - TODO: fix table implementation; * UI fixes for NIRVSS client #170 - Hide table header filter inputs when table is in small container; * UI fixes for NIRVSS client #170 - Fixing legends and plot layout when small, and within a stacked plot; - Add new `hideLegendWhenSmall` property; - Remove 'hidden' from plot legend position options; - Reduced opacity of tabular headers in Espresso theme; - VERY, VERY WIP right now! * UI fixes for NIRVSS client #170 - Fixing legends and plot layout when small, and within a stacked plot; - Cleanups, indention, removed commented CSS; - Tightened up spacing in plot Y axis; * UI enhancements for #3176 - Move local controls for plots and imagery, prevent overlapping with view large button when in a hidden frame in a layout; - Finesse local control styling for increased legibility; - Move l-state-indicators to avoid overlap with repositioned local controls, finesse styling; * UI enhancements for #3176 - Tweak large overlay close button for better visual alignment; * UI enhancements for #3176 - Significant improvements to lines in Display Layouts; - Increased border-width for lines and boxes; - Code enhanced for proper handling of horizontal and vertical lines - but still isn't working properly; - Renamed box-view.scss to box-and-line-views.scss; - VERY WIP! * Fixed incorrect grid array reference * UI enhancements for #3176 - Fixed final issue with Display Layout line drawing object, thank you @deeptailor!; * UI enhancements for #3176 - Contrast enhancements and markup normalization for `c-object-label` elements in main view, Layout frames, Inspector and overlay; - Enhanced `l-overlay-large` layout; - Tightened up margins and spacing in plots; - Refined `is-paused` styling in Telemetry Tables; - Now hide Telemetry Tables 'Export Data' button if rows are selected, which use a separate export button; - Layout frames now hide button's text labels when small; - Layout frames spacing tightened up and improved; * UI enhancements for #3176 - Tweak Snow theme constants; * UI enhancements for #3176 - Fixed ObjectFrame getOverlayElement method, added a wrapper div around the viewed object to properly control resulting layout in the overlay; - Simplified preview CSS to remove background, border and padding; - Layout tweaks to add space between scrollbar and thumbs in Imagery view; - Removed dev "-info" element in LineView.vue; * UI enhancements for #3176 - Improved styling for 'edit lock' button; * UI enhancements for #3176 - Show Display Layout frame "-move" bar on hover, rather than select, to make it easier to select items with hidden frames, and only show -move bar's drag grippy when that frame is selected; - `pointer-events: none` applied to table's body and plot's plot areas when placed in a Layout and being edited, prevents distracting interactions (plot zoom/pan, table row selection) when selecting and moving elements in a Layout; - Refined hover styles for c-button to use $filterHov, simplified and normalized hover styling; - Converted a number of old `` tags to `` to normalize styling and use the appropriate control; - Edit lock button is now colored when locked; * Fix linting issue * Minor tweaks - Tweaked control positioning; Co-authored-by: Shefali Joshi --- .../commonUI/dialog/res/templates/dialog.html | 8 +- .../dialog/res/templates/overlay-options.html | 4 +- platform/search/res/templates/search.html | 14 +-- .../components/overlay-component.scss | 34 +++++- .../displayLayout/components/LayoutFrame.vue | 10 +- .../displayLayout/components/LineView.vue | 85 +++++++++----- .../components/box-and-line-views.scss | 55 +++++++++ .../displayLayout/components/box-view.scss | 8 -- .../components/layout-frame.scss | 15 ++- .../imagery/components/ImageryViewLayout.vue | 4 +- .../components/imagery-view-layout.scss | 3 +- src/plugins/plot/res/templates/mct-plot.html | 36 +++--- .../res/templates/plot-options-browse.html | 5 + .../plot/res/templates/plot-options-edit.html | 6 +- .../plot/src/configuration/LegendModel.js | 1 + .../src/inspector/PlotLegendFormController.js | 5 + .../telemetryTable/components/table.scss | 22 +++- .../telemetryTable/components/table.vue | 7 +- src/styles/_constants-espresso.scss | 14 ++- src/styles/_constants-maelstrom.scss | 10 +- src/styles/_constants-snow.scss | 8 +- src/styles/_constants.scss | 7 +- src/styles/_controls.scss | 5 - src/styles/_global.scss | 4 - src/styles/_legacy-plots.scss | 106 +++++++++++++----- src/styles/_mixins.scss | 16 +-- src/styles/_table.scss | 18 ++- src/styles/vue-styles.scss | 2 +- src/ui/components/ObjectFrame.vue | 5 +- src/ui/components/object-frame.scss | 46 ++++---- src/ui/components/object-label.scss | 1 + src/ui/inspector/ObjectName.vue | 17 +-- src/ui/inspector/inspector.scss | 13 ++- src/ui/layout/BrowseBar.vue | 2 +- src/ui/layout/layout.scss | 11 ++ src/ui/preview/preview-header.vue | 10 +- src/ui/preview/preview.scss | 4 +- 37 files changed, 429 insertions(+), 192 deletions(-) create mode 100644 src/plugins/displayLayout/components/box-and-line-views.scss delete mode 100644 src/plugins/displayLayout/components/box-view.scss diff --git a/platform/commonUI/dialog/res/templates/dialog.html b/platform/commonUI/dialog/res/templates/dialog.html index 78b852c968..6c6b3d44da 100644 --- a/platform/commonUI/dialog/res/templates/dialog.html +++ b/platform/commonUI/dialog/res/templates/dialog.html @@ -31,13 +31,13 @@
- OK - - +
diff --git a/platform/commonUI/dialog/res/templates/overlay-options.html b/platform/commonUI/dialog/res/templates/overlay-options.html index 40bf8d9755..d83d5b7302 100644 --- a/platform/commonUI/dialog/res/templates/overlay-options.html +++ b/platform/commonUI/dialog/res/templates/overlay-options.html @@ -31,13 +31,13 @@
- {{option.name}} - +
diff --git a/platform/search/res/templates/search.html b/platform/search/res/templates/search.html index 726f04fdd6..d0bfcfcf92 100644 --- a/platform/search/res/templates/search.html +++ b/platform/search/res/templates/search.html @@ -29,9 +29,9 @@ type="text" tabindex="10000" ng-model="ngModel.input" ng-keyup="controller.search()"/> - + ng-click="ngModel.input = ''; controller.search()"> - - Cancel + Cancel
- Filtered by: {{ ngModel.filtersString }} + Filtered by: {{ ngModel.filtersString }}
@@ -72,7 +72,7 @@ ng-model="ngModel" class="l-flex-row flex-elem grows"> - More Results +
diff --git a/src/api/overlays/components/overlay-component.scss b/src/api/overlays/components/overlay-component.scss index 14de7b0c4a..c30ffa5191 100644 --- a/src/api/overlays/components/overlay-component.scss +++ b/src/api/overlays/components/overlay-component.scss @@ -36,6 +36,7 @@ font-size: 1.25em; position: absolute; top: $p; right: $p; + z-index: 99; } &__contents { @@ -43,7 +44,7 @@ display: flex; flex-direction: column; outline: none; - overflow: hidden; + overflow: auto; } &__top-bar { @@ -87,6 +88,10 @@ .c-click-icon { filter: $overlayBrightnessAdjust; } + + .c-object-label__name { + filter: $objectLabelNameFilter; + } } body.desktop { @@ -100,7 +105,6 @@ body.desktop { } // Overlay types, styling for desktop. Appended to .l-overlay-wrapper element. - .l-overlay-large, .l-overlay-small, .l-overlay-fit { .c-overlay__outer { @@ -118,8 +122,28 @@ body.desktop { .l-overlay-large { // Default - .c-overlay__outer { - @include overlaySizing($overlayOuterMarginLg); + $pad: $interiorMarginLg; + $tbPad: floor($pad * 0.8); + $lrPad: $pad; + .c-overlay { + &__blocker { + display: none; + } + + &__outer { + @include overlaySizing($overlayOuterMarginFullscreen); + padding: $tbPad $lrPad; + } + + &__close-button { + top: $pad; + right: $interiorMarginSm; + } + } + + .l-browse-bar { + margin-right: $lrPad + $pad; // Don't cover close button + margin-bottom: $interiorMargin; } } @@ -139,4 +163,4 @@ body.desktop { min-width: 20%; } } -} \ No newline at end of file +} diff --git a/src/plugins/displayLayout/components/LayoutFrame.vue b/src/plugins/displayLayout/components/LayoutFrame.vue index 330e6025ee..70bc9bf653 100644 --- a/src/plugins/displayLayout/components/LayoutFrame.vue +++ b/src/plugins/displayLayout/components/LayoutFrame.vue @@ -25,7 +25,8 @@ class="l-layout__frame c-frame" :class="{ 'no-frame': !item.hasFrame, - 'u-inspectable': inspectable + 'u-inspectable': inspectable, + 'is-in-small-container': size.width < 600 || size.height < 600 }" :style="style" > @@ -61,6 +62,13 @@ export default { } }, computed: { + size() { + let {width, height} = this.item; + return { + width: (this.gridSize[0] * width), + height: (this.gridSize[1] * height) + }; + }, style() { let {x, y, width, height} = this.item; return { diff --git a/src/plugins/displayLayout/components/LineView.vue b/src/plugins/displayLayout/components/LineView.vue index fb19a70049..dc6d9bf934 100644 --- a/src/plugins/displayLayout/components/LineView.vue +++ b/src/plugins/displayLayout/components/LineView.vue @@ -22,7 +22,7 @@