[Build] Remove unused variables

...to satisfy JSHint

platform/commonUI/general/src/controllers/TimeRangeController.js

@@ -21,8 +21,8 @@
  *****************************************************************************/
 
 define(
-    ['moment'],
-    function (moment) {
+    [],
+    function () {
 
         var TICK_SPACING_PX = 150;
 
@@ -180,7 +180,7 @@ define(
                 };
             }
 
-            function updateOuterStart(t) {
+            function updateOuterStart() {
                 var ngModel = $scope.ngModel;
 
                 ngModel.inner.start =
@@ -195,7 +195,7 @@ define(
                 updateTicks();
             }
 
-            function updateOuterEnd(t) {
+            function updateOuterEnd() {
                 var ngModel = $scope.ngModel;
 
                 ngModel.inner.end =

platform/commonUI/general/src/controllers/TreeNodeController.js

@@ -60,9 +60,7 @@ define(
          */
         function TreeNodeController($scope, $timeout) {
             var self = this,
-                selectedObject = ($scope.ngModel || {}).selectedObject,
-                isSelected = false,
-                hasBeenExpanded = false;
+                selectedObject = ($scope.ngModel || {}).selectedObject;
 
             // Look up the id for a domain object. A convenience
             // for mapping; additionally does some undefined-checking.

platform/commonUI/general/src/directives/MCTSplitPane.js

@@ -94,13 +94,6 @@ define(
          * @constructor
          */
         function MCTSplitPane($parse, $log, $interval) {
-            var anchors = {
-                left: true,
-                right: true,
-                top: true,
-                bottom: true
-            };
-
             function controller($scope, $element, $attrs) {
                 var anchorKey = $attrs.anchor || DEFAULT_ANCHOR,
                     anchor,
@@ -162,7 +155,7 @@ define(
                 // Getter-setter for the pixel offset of the splitter,
                 // relative to the current edge.
                 function getSetPosition(value) {
-                    var min, max, prior = position;
+                    var prior = position;
                     if (typeof value === 'number') {
                         position = value;
                         enforceExtrema();

platform/commonUI/general/src/directives/MCTSplitter.js

@@ -28,13 +28,7 @@ define(
         var SPLITTER_TEMPLATE = "<div class='abs'" +
                 "mct-drag-down=\"splitter.startMove()\" " +
                 "mct-drag=\"splitter.move(delta)\" " +
-                "mct-drag-up=\"splitter.endMove()\"></div>",
-            OFFSETS_BY_EDGE = {
-                left: "offsetLeft",
-                right: "offsetRight",
-                top: "offsetTop",
-                bottom: "offsetBottom"
-            };
+                "mct-drag-up=\"splitter.endMove()\"></div>";
 
         /**
          * Implements `mct-splitter` directive.
@@ -50,7 +44,6 @@ define(
                 scope.splitter = {
                     // Begin moving this splitter
                     startMove: function () {
-                        var splitter = element[0];
                         initialPosition = mctSplitPane.position();
                         mctSplitPane.toggleClass('resizing');
                     },

platform/commonUI/general/src/services/PopupService.js

@@ -81,8 +81,7 @@ define(
                 winDim = [ $window.innerWidth, $window.innerHeight ],
                 styles = { position: 'absolute' },
                 margin,
-                offset,
-                bubble;
+                offset;
 
             function adjustNegatives(value, index) {
                 return value < 0 ? (value + winDim[index]) : value;