alihan/openmct
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Timeline] Reduce flicker

Browse Source 
Reposition scroll bar in Timeline with RAF instead of timeout;
this ensures that scroll bar is positioned after the current
digest (updating the width) but before the results are rendered
(avoiding flicker.) Fixes #997
This commit is contained in:
Victor Woeltjen
2016-06-07 10:02:52 -07:00
parent b0f06a2195
commit a1b2175801
3 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
platform/features/timeline/test/controllers/TimelineZoomControllerSpec.js
View File

@@ -28,7 +28,7 @@ define(
describe("The timeline zoom state controller", function () {
var testConfiguration,
mockScope,
mockTimeout,
mockWindow,
controller;
beforeEach(function () {
@@ -36,13 +36,16 @@ define(
levels: [1000, 2000, 3500],
width: 12321
};
mockScope = jasmine.createSpyObj("$scope", ['$watch']);
mockScope =
jasmine.createSpyObj("$scope", ['$watch', '$apply']);
mockScope.commit = jasmine.createSpy('commit');
mockScope.scroll = { x: 0, width: 1000 };
mockTimeout = jasmine.createSpy('$timeout');
mockWindow = {
requestAnimationFrame: jasmine.createSpy('raf')
};
controller = new TimelineZoomController(
mockScope,
mockTimeout,
mockWindow,
testConfiguration
);
});
@@ -109,7 +112,7 @@ define(
call.args[1](mockScope[call.args[0]]);
});
mockTimeout.calls.forEach(function (call) {
mockWindow.requestAnimationFrame.calls.forEach(function (call) {
call.args[0]();
});
});