alihan/openmct
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixes issue #2537 Removes unused isEditing parameter for the view method of ViewProviders. (#2542)

Browse Source
This commit is contained in:
Shefali Joshi
2019-11-18 10:27:05 -08:00
committed by Pegah Sarram
parent 93abb09419
commit a4c2e944b3
8 changed files with 14 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/ui/components/ObjectView.vue
View File

@@ -77,7 +77,7 @@ export default {
if (!this.currentObject) {
return;
}
this.composition = this.openmct.composition.get(this.currentObject);
if (this.composition) {
this.composition._synchronize();
@@ -98,13 +98,13 @@ export default {
if (this.openmct.editor.isEditing()) {
this.currentView = provider.edit(this.currentObject, true, objectPath);
} else {
this.currentView = provider.view(this.currentObject, false, objectPath);
this.currentView = provider.view(this.currentObject, objectPath);
}
this.openmct.editor.on('isEditing', this.toggleEditView);
this.releaseEditModeHandler = () => this.openmct.editor.off('isEditing', this.toggleEditView);
} else {
this.currentView = provider.view(this.currentObject, this.openmct.editor.isEditing(), objectPath);
this.currentView = provider.view(this.currentObject, objectPath);
if (this.currentView.onEditModeChange) {
this.openmct.editor.on('isEditing', this.invokeEditModeHandler);
@@ -186,7 +186,7 @@ export default {
},
editIfEditable(event) {
let provider = this.getViewProvider();
if (provider &&
if (provider &&
provider.canEdit &&
provider.canEdit(this.currentObject) &&
!this.openmct.editor.isEditing()) {
@@ -204,7 +204,7 @@ export default {
if (domainObject) {
let clearKeyString = this.openmct.objects.makeKeyString(domainObject.identifier),
currentObjectKeyString = this.openmct.objects.makeKeyString(this.currentObject.identifier);
if (clearKeyString === currentObjectKeyString) {
if (this.currentView.onClearData) {
this.currentView.onClearData();