Merge remote-tracking branch 'origin/open882' into open-master
This commit is contained in:
@@ -15,12 +15,29 @@
|
|||||||
style="position: absolute;"
|
style="position: absolute;"
|
||||||
key="element.template"
|
key="element.template"
|
||||||
parameters="{ gridSize: controller.getGridSize() }"
|
parameters="{ gridSize: controller.getGridSize() }"
|
||||||
ng-class="{ test: controller.selected(element) }"
|
ng-class="{ disabled: controller.selected() && !controller.selected(element) }"
|
||||||
ng-style="element.style"
|
ng-style="element.style"
|
||||||
ng-click="controller.select(element)"
|
ng-click="controller.select(element)"
|
||||||
ng-model="element"
|
ng-model="element">
|
||||||
mct-drag-down="controller.startDrag(element); controller.select(element)"
|
|
||||||
mct-drag="controller.continueDrag(delta)"
|
|
||||||
mct-drag-up="controller.endDrag()">
|
|
||||||
</mct-include>
|
</mct-include>
|
||||||
|
|
||||||
|
<!-- Selection highlight, handles -->
|
||||||
|
<span ng-if="controller.selected()">
|
||||||
|
<div class="test"
|
||||||
|
style="position: absolute;"
|
||||||
|
mct-drag-down="controller.moveHandle().startDrag(controller.selected())"
|
||||||
|
mct-drag="controller.moveHandle().continueDrag(delta)"
|
||||||
|
mct-drag-up="controller.moveHandle().endDrag()"
|
||||||
|
ng-style="controller.selected().style">
|
||||||
|
</div>
|
||||||
|
<div ng-repeat="handle in controller.handles()"
|
||||||
|
style="position: absolute;"
|
||||||
|
ng-style="handle.style()"
|
||||||
|
mct-drag-down="handle.startDrag()"
|
||||||
|
mct-drag="handle.continueDrag(delta)"
|
||||||
|
mct-drag-up="handle.endDrag()">
|
||||||
|
O
|
||||||
|
</div>
|
||||||
|
</span>
|
||||||
|
|
||||||
</div>
|
</div>
|
||||||
@@ -1,8 +1,8 @@
|
|||||||
/*global define*/
|
/*global define*/
|
||||||
|
|
||||||
define(
|
define(
|
||||||
['./LayoutDrag', './LayoutSelection', './FixedProxy', './elements/ElementProxies'],
|
['./LayoutSelection', './FixedProxy', './elements/ElementProxies', './FixedDragHandle'],
|
||||||
function (LayoutDrag, LayoutSelection, FixedProxy, ElementProxies) {
|
function (LayoutSelection, FixedProxy, ElementProxies, FixedDragHandle) {
|
||||||
"use strict";
|
"use strict";
|
||||||
|
|
||||||
var DEFAULT_DIMENSIONS = [ 2, 1 ],
|
var DEFAULT_DIMENSIONS = [ 2, 1 ],
|
||||||
@@ -27,6 +27,8 @@ define(
|
|||||||
names = {}, // Cache names by ID
|
names = {}, // Cache names by ID
|
||||||
values = {}, // Cache values by ID
|
values = {}, // Cache values by ID
|
||||||
elementProxiesById = {},
|
elementProxiesById = {},
|
||||||
|
handles = [],
|
||||||
|
moveHandle,
|
||||||
selection;
|
selection;
|
||||||
|
|
||||||
// Refresh cell styles (e.g. because grid extent changed)
|
// Refresh cell styles (e.g. because grid extent changed)
|
||||||
@@ -64,6 +66,40 @@ define(
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Update the style for a selected element
|
||||||
|
function updateSelectionStyle() {
|
||||||
|
var element = selection && selection.get();
|
||||||
|
if (element) {
|
||||||
|
element.style = convertPosition(element);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Generate a specific drag handle
|
||||||
|
function generateDragHandle(elementHandle) {
|
||||||
|
return new FixedDragHandle(
|
||||||
|
elementHandle,
|
||||||
|
gridSize,
|
||||||
|
updateSelectionStyle,
|
||||||
|
$scope.commit
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Generate drag handles for an element
|
||||||
|
function generateDragHandles(element) {
|
||||||
|
return element.handles().map(generateDragHandle);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Select an element
|
||||||
|
function select(element) {
|
||||||
|
if (selection) {
|
||||||
|
// Update selection...
|
||||||
|
selection.select(element);
|
||||||
|
// ...as well as move, resize handles
|
||||||
|
moveHandle = generateDragHandle(element);
|
||||||
|
handles = generateDragHandles(element);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// Update the displayed value for this object
|
// Update the displayed value for this object
|
||||||
function updateValue(telemetryObject) {
|
function updateValue(telemetryObject) {
|
||||||
var id = telemetryObject && telemetryObject.getId();
|
var id = telemetryObject && telemetryObject.getId();
|
||||||
@@ -121,7 +157,7 @@ define(
|
|||||||
if (selection) {
|
if (selection) {
|
||||||
selection.deselect();
|
selection.deselect();
|
||||||
if (index > -1) {
|
if (index > -1) {
|
||||||
selection.select(elementProxies[index]);
|
select(elementProxies[index]);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -183,9 +219,7 @@ define(
|
|||||||
// Refresh displayed elements
|
// Refresh displayed elements
|
||||||
refreshElements();
|
refreshElements();
|
||||||
// Select the newly-added element
|
// Select the newly-added element
|
||||||
if (selection) {
|
select(elementProxies[elementProxies.length - 1]);
|
||||||
selection.select(elementProxies[elementProxies.length - 1]);
|
|
||||||
}
|
|
||||||
// Mark change as persistable
|
// Mark change as persistable
|
||||||
if ($scope.commit) {
|
if ($scope.commit) {
|
||||||
$scope.commit("Dropped an element.");
|
$scope.commit("Dropped an element.");
|
||||||
@@ -275,82 +309,42 @@ define(
|
|||||||
return elementProxies;
|
return elementProxies;
|
||||||
},
|
},
|
||||||
/**
|
/**
|
||||||
* Check if the element is currently selected.
|
* Check if the element is currently selected, or (if no
|
||||||
|
* argument is supplied) get the currently selected element.
|
||||||
* @returns {boolean} true if selected
|
* @returns {boolean} true if selected
|
||||||
*/
|
*/
|
||||||
selected: function (element) {
|
selected: function (element) {
|
||||||
return selection && selection.selected(element);
|
return selection && ((arguments.length > 0) ?
|
||||||
|
selection.selected(element) : selection.get());
|
||||||
},
|
},
|
||||||
/**
|
/**
|
||||||
* Set the active user selection in this view.
|
* Set the active user selection in this view.
|
||||||
* @param element the element to select
|
* @param element the element to select
|
||||||
*/
|
*/
|
||||||
select: function (element) {
|
select: select,
|
||||||
if (selection) {
|
|
||||||
selection.select(element);
|
|
||||||
}
|
|
||||||
},
|
|
||||||
/**
|
/**
|
||||||
* Clear the current user selection.
|
* Clear the current user selection.
|
||||||
*/
|
*/
|
||||||
clearSelection: function () {
|
clearSelection: function () {
|
||||||
if (selection) {
|
if (selection) {
|
||||||
selection.deselect();
|
selection.deselect();
|
||||||
|
handles = [];
|
||||||
|
moveHandle = undefined;
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
/**
|
/**
|
||||||
* Start a drag gesture to move/resize a frame.
|
* Get drag handles.
|
||||||
*
|
* @returns {Array} drag handles for the current selection
|
||||||
* The provided position and dimensions factors will determine
|
|
||||||
* whether this is a move or a resize, and what type it
|
|
||||||
* will be. For instance, a position factor of [1, 1]
|
|
||||||
* will move a frame along with the mouse as the drag
|
|
||||||
* proceeds, while a dimension factor of [0, 0] will leave
|
|
||||||
* dimensions unchanged. Combining these in different
|
|
||||||
* ways results in different handles; a position factor of
|
|
||||||
* [1, 0] and a dimensions factor of [-1, 0] will implement
|
|
||||||
* a left-edge resize, as the horizontal position will move
|
|
||||||
* with the mouse while the horizontal dimensions shrink in
|
|
||||||
* kind (and vertical properties remain unmodified.)
|
|
||||||
*
|
|
||||||
* @param element the raw (undecorated) element to drag
|
|
||||||
*/
|
*/
|
||||||
startDrag: function (element) {
|
handles: function () {
|
||||||
// Only allow dragging in edit mode
|
return handles;
|
||||||
if ($scope.domainObject &&
|
|
||||||
$scope.domainObject.hasCapability('editor')) {
|
|
||||||
dragging = {
|
|
||||||
element: element,
|
|
||||||
x: element.x(),
|
|
||||||
y: element.y()
|
|
||||||
};
|
|
||||||
}
|
|
||||||
},
|
},
|
||||||
/**
|
/**
|
||||||
* Continue an active drag gesture.
|
* Get the handle to handle dragging to reposition an element.
|
||||||
* @param {number[]} delta the offset, in pixels,
|
* @returns {FixedDragHandle} the drag handle
|
||||||
* of the current pointer position, relative
|
|
||||||
* to its position when the drag started
|
|
||||||
*/
|
*/
|
||||||
continueDrag: function (delta) {
|
moveHandle: function () {
|
||||||
if (dragging) {
|
return moveHandle;
|
||||||
// Update x/y values
|
|
||||||
dragging.element.x(dragging.x + Math.round(delta[0] / gridSize[0]));
|
|
||||||
dragging.element.y(dragging.y + Math.round(delta[1] / gridSize[1]));
|
|
||||||
// Update display position
|
|
||||||
dragging.element.style = convertPosition(dragging.element);
|
|
||||||
}
|
|
||||||
},
|
|
||||||
/**
|
|
||||||
* End the active drag gesture. This will update the
|
|
||||||
* view configuration.
|
|
||||||
*/
|
|
||||||
endDrag: function () {
|
|
||||||
// Mark this object as dirty to encourage persistence
|
|
||||||
if (dragging && $scope.commit) {
|
|
||||||
dragging = undefined;
|
|
||||||
$scope.commit("Moved element.");
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
96
platform/features/layout/src/FixedDragHandle.js
Normal file
96
platform/features/layout/src/FixedDragHandle.js
Normal file
@@ -0,0 +1,96 @@
|
|||||||
|
/*global define*/
|
||||||
|
|
||||||
|
define(
|
||||||
|
[],
|
||||||
|
function () {
|
||||||
|
'use strict';
|
||||||
|
|
||||||
|
|
||||||
|
// 8 by 8 pixels
|
||||||
|
var DRAG_HANDLE_SIZE = [ 8, 8 ];
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Template-displayable drag handle for an element in fixed
|
||||||
|
* position mode.
|
||||||
|
* @constructor
|
||||||
|
*/
|
||||||
|
function FixedDragHandle(elementHandle, gridSize, update, commit) {
|
||||||
|
var self = {},
|
||||||
|
dragging;
|
||||||
|
|
||||||
|
// Generate ng-style-appropriate style for positioning
|
||||||
|
function getStyle() {
|
||||||
|
// Adjust from grid to pixel coordinates
|
||||||
|
var x = elementHandle.x() * gridSize[0],
|
||||||
|
y = elementHandle.y() * gridSize[1];
|
||||||
|
|
||||||
|
// Convert to a CSS style centered on that point
|
||||||
|
return {
|
||||||
|
left: (x - DRAG_HANDLE_SIZE[0] / 2) + 'px',
|
||||||
|
top: (y - DRAG_HANDLE_SIZE[1] / 2) + 'px',
|
||||||
|
width: DRAG_HANDLE_SIZE[0] + 'px',
|
||||||
|
height: DRAG_HANDLE_SIZE[1] + 'px'
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
// Begin a drag gesture
|
||||||
|
function startDrag() {
|
||||||
|
// Cache initial x/y positions
|
||||||
|
dragging = { x: elementHandle.x(), y: elementHandle.y() };
|
||||||
|
}
|
||||||
|
|
||||||
|
// Reposition during drag
|
||||||
|
function continueDrag(delta) {
|
||||||
|
if (dragging) {
|
||||||
|
// Update x/y positions (snapping to grid)
|
||||||
|
elementHandle.x(
|
||||||
|
dragging.x + Math.round(delta[0] / gridSize[0])
|
||||||
|
);
|
||||||
|
elementHandle.y(
|
||||||
|
dragging.y + Math.round(delta[1] / gridSize[1])
|
||||||
|
);
|
||||||
|
// Invoke update callback
|
||||||
|
if (update) {
|
||||||
|
update();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Conclude a drag gesture
|
||||||
|
function endDrag() {
|
||||||
|
// Clear cached state
|
||||||
|
dragging = undefined;
|
||||||
|
// Mark change as complete
|
||||||
|
if (commit) {
|
||||||
|
commit("Dragged handle.");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
/**
|
||||||
|
* Get a CSS style to position this drag handle.
|
||||||
|
* @returns CSS style object (for `ng-style`)
|
||||||
|
*/
|
||||||
|
style: getStyle,
|
||||||
|
/**
|
||||||
|
* Start a drag gesture. This should be called when a drag
|
||||||
|
* begins to track initial state.
|
||||||
|
*/
|
||||||
|
startDrag: startDrag,
|
||||||
|
/**
|
||||||
|
* Continue a drag gesture; update x/y positions.
|
||||||
|
* @param {number[]} delta x/y pixel difference since drag
|
||||||
|
* started
|
||||||
|
*/
|
||||||
|
continueDrag: continueDrag,
|
||||||
|
/**
|
||||||
|
* End a drag gesture. This should be callled when a drag
|
||||||
|
* concludes to trigger commit of changes.
|
||||||
|
*/
|
||||||
|
endDrag: endDrag
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
return FixedDragHandle;
|
||||||
|
}
|
||||||
|
);
|
||||||
@@ -8,14 +8,26 @@ define(
|
|||||||
/**
|
/**
|
||||||
* Utility function for creating getter-setter functions,
|
* Utility function for creating getter-setter functions,
|
||||||
* since these are frequently useful for element proxies.
|
* since these are frequently useful for element proxies.
|
||||||
|
*
|
||||||
|
* An optional third argument may be supplied in order to
|
||||||
|
* constrain or modify arguments when using as a setter;
|
||||||
|
* this argument is a function which takes two arguments
|
||||||
|
* (the current value for the property, and the requested
|
||||||
|
* new value.) This is useful when values need to be kept
|
||||||
|
* in certain ranges; specifically, to keep x/y positions
|
||||||
|
* non-negative in a fixed position view.
|
||||||
|
*
|
||||||
* @constructor
|
* @constructor
|
||||||
* @param {Object} object the object to get/set values upon
|
* @param {Object} object the object to get/set values upon
|
||||||
* @param {string} key the property to get/set
|
* @param {string} key the property to get/set
|
||||||
|
* @param {function} [updater] function used to process updates
|
||||||
*/
|
*/
|
||||||
function AccessorMutator(object, key) {
|
function AccessorMutator(object, key, updater) {
|
||||||
return function (value) {
|
return function (value) {
|
||||||
if (arguments.length > 0) {
|
if (arguments.length > 0) {
|
||||||
object[key] = value;
|
object[key] = updater ?
|
||||||
|
updater(value, object[key]) :
|
||||||
|
value;
|
||||||
}
|
}
|
||||||
return object[key];
|
return object[key];
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -1,8 +1,8 @@
|
|||||||
/*global define*/
|
/*global define*/
|
||||||
|
|
||||||
define(
|
define(
|
||||||
['./AccessorMutator'],
|
['./AccessorMutator', './ResizeHandle'],
|
||||||
function (AccessorMutator) {
|
function (AccessorMutator, ResizeHandle) {
|
||||||
"use strict";
|
"use strict";
|
||||||
|
|
||||||
// Index deltas for changes in order
|
// Index deltas for changes in order
|
||||||
@@ -13,6 +13,11 @@ define(
|
|||||||
bottom: Number.NEGATIVE_INFINITY
|
bottom: Number.NEGATIVE_INFINITY
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// Ensure a value is non-negative (for x/y setters)
|
||||||
|
function clamp(value) {
|
||||||
|
return Math.max(value, 0);
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Abstract superclass for other classes which provide useful
|
* Abstract superclass for other classes which provide useful
|
||||||
* interfaces upon an elements in a fixed position view.
|
* interfaces upon an elements in a fixed position view.
|
||||||
@@ -29,6 +34,8 @@ define(
|
|||||||
* @param {Array} elements the full array of elements
|
* @param {Array} elements the full array of elements
|
||||||
*/
|
*/
|
||||||
function ElementProxy(element, index, elements) {
|
function ElementProxy(element, index, elements) {
|
||||||
|
var handles = [ new ResizeHandle(element, 1, 1) ];
|
||||||
|
|
||||||
return {
|
return {
|
||||||
/**
|
/**
|
||||||
* The element as stored in the view configuration.
|
* The element as stored in the view configuration.
|
||||||
@@ -40,14 +47,14 @@ define(
|
|||||||
* @param {number} [x] the new x position (if setting)
|
* @param {number} [x] the new x position (if setting)
|
||||||
* @returns {number} the x position
|
* @returns {number} the x position
|
||||||
*/
|
*/
|
||||||
x: new AccessorMutator(element, 'x'),
|
x: new AccessorMutator(element, 'x', clamp),
|
||||||
/**
|
/**
|
||||||
* Get and/or set the y position of this element.
|
* Get and/or set the y position of this element.
|
||||||
* Units are in fixed position grid space.
|
* Units are in fixed position grid space.
|
||||||
* @param {number} [y] the new y position (if setting)
|
* @param {number} [y] the new y position (if setting)
|
||||||
* @returns {number} the y position
|
* @returns {number} the y position
|
||||||
*/
|
*/
|
||||||
y: new AccessorMutator(element, 'y'),
|
y: new AccessorMutator(element, 'y', clamp),
|
||||||
/**
|
/**
|
||||||
* Get and/or set the stroke color of this element.
|
* Get and/or set the stroke color of this element.
|
||||||
* @param {string} [stroke] the new stroke color (if setting)
|
* @param {string} [stroke] the new stroke color (if setting)
|
||||||
@@ -97,6 +104,13 @@ define(
|
|||||||
if (elements[index] === element) {
|
if (elements[index] === element) {
|
||||||
elements.splice(index, 1);
|
elements.splice(index, 1);
|
||||||
}
|
}
|
||||||
|
},
|
||||||
|
/**
|
||||||
|
* Get handles to control specific features of this element,
|
||||||
|
* e.g. corner size.
|
||||||
|
*/
|
||||||
|
handles: function () {
|
||||||
|
return handles;
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|||||||
61
platform/features/layout/src/elements/LineHandle.js
Normal file
61
platform/features/layout/src/elements/LineHandle.js
Normal file
@@ -0,0 +1,61 @@
|
|||||||
|
/*global define*/
|
||||||
|
define(
|
||||||
|
[],
|
||||||
|
function () {
|
||||||
|
'use strict';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Handle for changing x/y position of a line's end point.
|
||||||
|
* This is used to support drag handles for line elements
|
||||||
|
* in a fixed position view. Field names for opposite ends
|
||||||
|
* are provided to avoid zero-length lines.
|
||||||
|
* @constructor
|
||||||
|
* @param element the line element
|
||||||
|
* @param {string} xProperty field which stores x position
|
||||||
|
* @param {string} yProperty field which stores x position
|
||||||
|
* @param {string} xOther field which stores x of other end
|
||||||
|
* @param {string} yOther field which stores y of other end
|
||||||
|
*/
|
||||||
|
function LineHandle(element, xProperty, yProperty, xOther, yOther) {
|
||||||
|
return {
|
||||||
|
/**
|
||||||
|
* Get/set the x position of the lower-right corner
|
||||||
|
* of the handle-controlled element, changing size
|
||||||
|
* as necessary.
|
||||||
|
*/
|
||||||
|
x: function (value) {
|
||||||
|
if (arguments.length > 0) {
|
||||||
|
// Ensure we stay in view
|
||||||
|
value = Math.max(value, 0);
|
||||||
|
// Make sure end points will still be different
|
||||||
|
if (element[yOther] !== element[yProperty] ||
|
||||||
|
element[xOther] !== value) {
|
||||||
|
element[xProperty] = value;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return element[xProperty];
|
||||||
|
},
|
||||||
|
/**
|
||||||
|
* Get/set the y position of the lower-right corner
|
||||||
|
* of the handle-controlled element, changing size
|
||||||
|
* as necessary.
|
||||||
|
*/
|
||||||
|
y: function (value) {
|
||||||
|
if (arguments.length > 0) {
|
||||||
|
// Ensure we stay in view
|
||||||
|
value = Math.max(value, 0);
|
||||||
|
// Make sure end points will still be different
|
||||||
|
if (element[xOther] !== element[xProperty] ||
|
||||||
|
element[yOther] !== value) {
|
||||||
|
element[yProperty] = value;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return element[yProperty];
|
||||||
|
}
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
return LineHandle;
|
||||||
|
|
||||||
|
}
|
||||||
|
);
|
||||||
@@ -1,8 +1,8 @@
|
|||||||
/*global define*/
|
/*global define*/
|
||||||
|
|
||||||
define(
|
define(
|
||||||
['./ElementProxy'],
|
['./ElementProxy', './LineHandle'],
|
||||||
function (ElementProxy) {
|
function (ElementProxy, LineHandle) {
|
||||||
'use strict';
|
'use strict';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -15,7 +15,11 @@ define(
|
|||||||
* @param {Array} elements the full array of elements
|
* @param {Array} elements the full array of elements
|
||||||
*/
|
*/
|
||||||
function LineProxy(element, index, elements) {
|
function LineProxy(element, index, elements) {
|
||||||
var proxy = new ElementProxy(element, index, elements);
|
var proxy = new ElementProxy(element, index, elements),
|
||||||
|
handles = [
|
||||||
|
new LineHandle(element, 'x', 'y', 'x2', 'y2'),
|
||||||
|
new LineHandle(element, 'x2', 'y2', 'x', 'y')
|
||||||
|
];
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Get the top-left x coordinate, in grid space, of
|
* Get the top-left x coordinate, in grid space, of
|
||||||
@@ -24,7 +28,7 @@ define(
|
|||||||
*/
|
*/
|
||||||
proxy.x = function (v) {
|
proxy.x = function (v) {
|
||||||
var x = Math.min(element.x, element.x2),
|
var x = Math.min(element.x, element.x2),
|
||||||
delta = v - x;
|
delta = Math.max(v, 0) - x;
|
||||||
if (arguments.length > 0 && delta) {
|
if (arguments.length > 0 && delta) {
|
||||||
element.x += delta;
|
element.x += delta;
|
||||||
element.x2 += delta;
|
element.x2 += delta;
|
||||||
@@ -39,7 +43,7 @@ define(
|
|||||||
*/
|
*/
|
||||||
proxy.y = function (v) {
|
proxy.y = function (v) {
|
||||||
var y = Math.min(element.y, element.y2),
|
var y = Math.min(element.y, element.y2),
|
||||||
delta = v - y;
|
delta = Math.max(v, 0) - y;
|
||||||
if (arguments.length > 0 && delta) {
|
if (arguments.length > 0 && delta) {
|
||||||
element.y += delta;
|
element.y += delta;
|
||||||
element.y2 += delta;
|
element.y2 += delta;
|
||||||
@@ -105,6 +109,15 @@ define(
|
|||||||
return element.y2 - proxy.y();
|
return element.y2 - proxy.y();
|
||||||
};
|
};
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Get element handles for changing the position of end
|
||||||
|
* points of this line.
|
||||||
|
* @returns {LineHandle[]} line handles for both end points
|
||||||
|
*/
|
||||||
|
proxy.handles = function () {
|
||||||
|
return handles;
|
||||||
|
};
|
||||||
|
|
||||||
return proxy;
|
return proxy;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
53
platform/features/layout/src/elements/ResizeHandle.js
Normal file
53
platform/features/layout/src/elements/ResizeHandle.js
Normal file
@@ -0,0 +1,53 @@
|
|||||||
|
/*global define*/
|
||||||
|
define(
|
||||||
|
[],
|
||||||
|
function () {
|
||||||
|
'use strict';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Handle for changing width/height properties of an element.
|
||||||
|
* This is used to support drag handles for different
|
||||||
|
* element types in a fixed position view.
|
||||||
|
* @constructor
|
||||||
|
*/
|
||||||
|
function ResizeHandle(element, minWidth, minHeight) {
|
||||||
|
// Ensure reasonable defaults
|
||||||
|
minWidth = minWidth || 0;
|
||||||
|
minHeight = minHeight || 0;
|
||||||
|
|
||||||
|
return {
|
||||||
|
/**
|
||||||
|
* Get/set the x position of the lower-right corner
|
||||||
|
* of the handle-controlled element, changing size
|
||||||
|
* as necessary.
|
||||||
|
*/
|
||||||
|
x: function (value) {
|
||||||
|
if (arguments.length > 0) {
|
||||||
|
element.width = Math.max(
|
||||||
|
minWidth,
|
||||||
|
value - element.x
|
||||||
|
);
|
||||||
|
}
|
||||||
|
return element.x + element.width;
|
||||||
|
},
|
||||||
|
/**
|
||||||
|
* Get/set the y position of the lower-right corner
|
||||||
|
* of the handle-controlled element, changing size
|
||||||
|
* as necessary.
|
||||||
|
*/
|
||||||
|
y: function (value) {
|
||||||
|
if (arguments.length > 0) {
|
||||||
|
element.height = Math.max(
|
||||||
|
minHeight,
|
||||||
|
value - element.y
|
||||||
|
);
|
||||||
|
}
|
||||||
|
return element.y + element.height;
|
||||||
|
}
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
return ResizeHandle;
|
||||||
|
|
||||||
|
}
|
||||||
|
);
|
||||||
@@ -167,6 +167,19 @@ define(
|
|||||||
expect(controller.selected(elements[1])).toBeTruthy();
|
expect(controller.selected(elements[1])).toBeTruthy();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("allows selection retrieval", function () {
|
||||||
|
// selected with no arguments should give the current
|
||||||
|
// selection
|
||||||
|
var elements;
|
||||||
|
|
||||||
|
testModel.modified = 1;
|
||||||
|
findWatch("model.modified")(testModel.modified);
|
||||||
|
|
||||||
|
elements = controller.getElements();
|
||||||
|
controller.select(elements[1]);
|
||||||
|
expect(controller.selected()).toEqual(elements[1]);
|
||||||
|
});
|
||||||
|
|
||||||
it("allows selections to be cleared", function () {
|
it("allows selections to be cleared", function () {
|
||||||
var elements;
|
var elements;
|
||||||
|
|
||||||
@@ -288,6 +301,68 @@ define(
|
|||||||
// elements to size SVGs appropriately
|
// elements to size SVGs appropriately
|
||||||
expect(controller.getGridSize()).toEqual(testGrid);
|
expect(controller.getGridSize()).toEqual(testGrid);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("exposes drag handles", function () {
|
||||||
|
var handles;
|
||||||
|
|
||||||
|
// Select something so that drag handles are expected
|
||||||
|
testModel.modified = 1;
|
||||||
|
findWatch("model.modified")(testModel.modified);
|
||||||
|
controller.select(controller.getElements()[1]);
|
||||||
|
|
||||||
|
// Should have a non-empty array of handles
|
||||||
|
handles = controller.handles();
|
||||||
|
expect(handles).toEqual(jasmine.any(Array));
|
||||||
|
expect(handles.length).not.toEqual(0);
|
||||||
|
|
||||||
|
// And they should have start/continue/end drag methods
|
||||||
|
handles.forEach(function (handle) {
|
||||||
|
expect(handle.startDrag).toEqual(jasmine.any(Function));
|
||||||
|
expect(handle.continueDrag).toEqual(jasmine.any(Function));
|
||||||
|
expect(handle.endDrag).toEqual(jasmine.any(Function));
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it("exposes a move handle", function () {
|
||||||
|
var handle;
|
||||||
|
|
||||||
|
// Select something so that drag handles are expected
|
||||||
|
testModel.modified = 1;
|
||||||
|
findWatch("model.modified")(testModel.modified);
|
||||||
|
controller.select(controller.getElements()[1]);
|
||||||
|
|
||||||
|
// Should have a move handle
|
||||||
|
handle = controller.moveHandle();
|
||||||
|
|
||||||
|
// And it should have start/continue/end drag methods
|
||||||
|
expect(handle.startDrag).toEqual(jasmine.any(Function));
|
||||||
|
expect(handle.continueDrag).toEqual(jasmine.any(Function));
|
||||||
|
expect(handle.endDrag).toEqual(jasmine.any(Function));
|
||||||
|
});
|
||||||
|
|
||||||
|
it("updates selection style during drag", function () {
|
||||||
|
var oldStyle;
|
||||||
|
|
||||||
|
// Select something so that drag handles are expected
|
||||||
|
testModel.modified = 1;
|
||||||
|
findWatch("model.modified")(testModel.modified);
|
||||||
|
controller.select(controller.getElements()[1]);
|
||||||
|
|
||||||
|
// Get style
|
||||||
|
oldStyle = controller.selected().style;
|
||||||
|
|
||||||
|
// Start a drag gesture
|
||||||
|
controller.moveHandle().startDrag();
|
||||||
|
|
||||||
|
// Haven't moved yet; style shouldn't have updated yet
|
||||||
|
expect(controller.selected().style).toEqual(oldStyle);
|
||||||
|
|
||||||
|
// Drag a little
|
||||||
|
controller.moveHandle().continueDrag([ 1000, 100 ]);
|
||||||
|
|
||||||
|
// Style should have been updated
|
||||||
|
expect(controller.selected().style).not.toEqual(oldStyle);
|
||||||
|
});
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
68
platform/features/layout/test/FixedDragHandleSpec.js
Normal file
68
platform/features/layout/test/FixedDragHandleSpec.js
Normal file
@@ -0,0 +1,68 @@
|
|||||||
|
/*global define,describe,it,expect,beforeEach,jasmine,xit*/
|
||||||
|
|
||||||
|
define(
|
||||||
|
['../src/FixedDragHandle'],
|
||||||
|
function (FixedDragHandle) {
|
||||||
|
"use strict";
|
||||||
|
|
||||||
|
var TEST_GRID_SIZE = [ 13, 33 ];
|
||||||
|
|
||||||
|
describe("A fixed position drag handle", function () {
|
||||||
|
var mockElementHandle,
|
||||||
|
mockUpdate,
|
||||||
|
mockCommit,
|
||||||
|
handle;
|
||||||
|
|
||||||
|
beforeEach(function () {
|
||||||
|
mockElementHandle = jasmine.createSpyObj(
|
||||||
|
'elementHandle',
|
||||||
|
[ 'x', 'y' ]
|
||||||
|
);
|
||||||
|
mockUpdate = jasmine.createSpy('update');
|
||||||
|
mockCommit = jasmine.createSpy('commit');
|
||||||
|
|
||||||
|
mockElementHandle.x.andReturn(6);
|
||||||
|
mockElementHandle.y.andReturn(8);
|
||||||
|
|
||||||
|
handle = new FixedDragHandle(
|
||||||
|
mockElementHandle,
|
||||||
|
TEST_GRID_SIZE,
|
||||||
|
mockUpdate,
|
||||||
|
mockCommit
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("provides a style for positioning", function () {
|
||||||
|
var style = handle.style();
|
||||||
|
// 6 grid coords * 13 pixels - 4 pixels for centering
|
||||||
|
expect(style.left).toEqual('74px');
|
||||||
|
// 8 grid coords * 33 pixels - 4 pixels for centering
|
||||||
|
expect(style.top).toEqual('260px');
|
||||||
|
});
|
||||||
|
|
||||||
|
it("allows handles to be dragged", function () {
|
||||||
|
handle.startDrag();
|
||||||
|
handle.continueDrag([ 16, 8 ]);
|
||||||
|
|
||||||
|
// Should update x/y, snapped to grid
|
||||||
|
expect(mockElementHandle.x).toHaveBeenCalledWith(7);
|
||||||
|
expect(mockElementHandle.y).toHaveBeenCalledWith(8);
|
||||||
|
|
||||||
|
handle.continueDrag([ -16, -35 ]);
|
||||||
|
|
||||||
|
// Should have interpreted relative to initial state
|
||||||
|
expect(mockElementHandle.x).toHaveBeenCalledWith(5);
|
||||||
|
expect(mockElementHandle.y).toHaveBeenCalledWith(7);
|
||||||
|
|
||||||
|
// Should have called update once per continueDrag
|
||||||
|
expect(mockUpdate.calls.length).toEqual(2);
|
||||||
|
|
||||||
|
// Finally, ending drag should commit
|
||||||
|
expect(mockCommit).not.toHaveBeenCalled();
|
||||||
|
handle.endDrag();
|
||||||
|
expect(mockCommit).toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
});
|
||||||
|
}
|
||||||
|
);
|
||||||
@@ -47,6 +47,13 @@ define(
|
|||||||
proxy.order("top");
|
proxy.order("top");
|
||||||
expect(testElements).toEqual([{}, {}, {}, testElement]);
|
expect(testElements).toEqual([{}, {}, {}, testElement]);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("ensures x/y values are non-negative", function () {
|
||||||
|
proxy.x(-1);
|
||||||
|
proxy.y(-400);
|
||||||
|
expect(proxy.x()).toEqual(0);
|
||||||
|
expect(proxy.y()).toEqual(0);
|
||||||
|
});
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
|
|||||||
54
platform/features/layout/test/elements/LineHandleSpec.js
Normal file
54
platform/features/layout/test/elements/LineHandleSpec.js
Normal file
@@ -0,0 +1,54 @@
|
|||||||
|
/*global define,describe,it,expect,beforeEach,jasmine,xit*/
|
||||||
|
|
||||||
|
define(
|
||||||
|
['../../src/elements/LineHandle'],
|
||||||
|
function (LineHandle) {
|
||||||
|
"use strict";
|
||||||
|
|
||||||
|
describe("A fixed position drag handle", function () {
|
||||||
|
var testElement,
|
||||||
|
handle;
|
||||||
|
|
||||||
|
beforeEach(function () {
|
||||||
|
testElement = {
|
||||||
|
x: 3,
|
||||||
|
y: 42,
|
||||||
|
x2: 8,
|
||||||
|
y2: 11
|
||||||
|
};
|
||||||
|
|
||||||
|
handle = new LineHandle(testElement, 'x', 'y', 'x2', 'y2');
|
||||||
|
});
|
||||||
|
|
||||||
|
it("provides x/y grid coordinates for its corner", function () {
|
||||||
|
expect(handle.x()).toEqual(3);
|
||||||
|
expect(handle.y()).toEqual(42);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("changes x and y positions", function () {
|
||||||
|
handle.x(30);
|
||||||
|
expect(testElement.x).toEqual(30);
|
||||||
|
handle.y(40);
|
||||||
|
expect(testElement.y).toEqual(40);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("disallows values less than zero", function () {
|
||||||
|
handle.x(-1);
|
||||||
|
handle.y(-400);
|
||||||
|
expect(testElement.x).toEqual(0);
|
||||||
|
expect(testElement.y).toEqual(0);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("ensures that end points remain different", function () {
|
||||||
|
handle.x(testElement.x2);
|
||||||
|
handle.y(testElement.y2);
|
||||||
|
// First change should have been fine, because y was different
|
||||||
|
expect(testElement.x).toEqual(testElement.x2);
|
||||||
|
// Second change should have been rejected
|
||||||
|
expect(testElement.y).not.toEqual(testElement.y2);
|
||||||
|
});
|
||||||
|
|
||||||
|
|
||||||
|
});
|
||||||
|
}
|
||||||
|
);
|
||||||
@@ -67,6 +67,10 @@ define(
|
|||||||
expect(proxy.y2()).toEqual(0);
|
expect(proxy.y2()).toEqual(0);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("provides handles for both ends", function () {
|
||||||
|
expect(new LineProxy(diagonal).handles().length).toEqual(2);
|
||||||
|
});
|
||||||
|
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
59
platform/features/layout/test/elements/ResizeHandleSpec.js
Normal file
59
platform/features/layout/test/elements/ResizeHandleSpec.js
Normal file
@@ -0,0 +1,59 @@
|
|||||||
|
/*global define,describe,it,expect,beforeEach,jasmine,xit*/
|
||||||
|
|
||||||
|
define(
|
||||||
|
['../../src/elements/ResizeHandle'],
|
||||||
|
function (ResizeHandle) {
|
||||||
|
"use strict";
|
||||||
|
|
||||||
|
var TEST_MIN_WIDTH = 4, TEST_MIN_HEIGHT = 2;
|
||||||
|
|
||||||
|
describe("A fixed position drag handle", function () {
|
||||||
|
var testElement,
|
||||||
|
handle;
|
||||||
|
|
||||||
|
beforeEach(function () {
|
||||||
|
testElement = {
|
||||||
|
x: 3,
|
||||||
|
y: 42,
|
||||||
|
width: 30,
|
||||||
|
height: 36
|
||||||
|
};
|
||||||
|
|
||||||
|
handle = new ResizeHandle(
|
||||||
|
testElement,
|
||||||
|
TEST_MIN_WIDTH,
|
||||||
|
TEST_MIN_HEIGHT
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("provides x/y grid coordinates for lower-right corner", function () {
|
||||||
|
expect(handle.x()).toEqual(33);
|
||||||
|
expect(handle.y()).toEqual(78);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("changes width of an element", function () {
|
||||||
|
handle.x(30);
|
||||||
|
// Should change width, not x
|
||||||
|
expect(testElement.x).toEqual(3);
|
||||||
|
expect(testElement.width).toEqual(27);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("changes height of an element", function () {
|
||||||
|
handle.y(60);
|
||||||
|
// Should change height, not y
|
||||||
|
expect(testElement.y).toEqual(42);
|
||||||
|
expect(testElement.height).toEqual(18);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("enforces minimum width/height", function () {
|
||||||
|
handle.x(testElement.x);
|
||||||
|
handle.y(testElement.y);
|
||||||
|
expect(testElement.x).toEqual(3);
|
||||||
|
expect(testElement.y).toEqual(42);
|
||||||
|
expect(testElement.width).toEqual(TEST_MIN_WIDTH);
|
||||||
|
expect(testElement.height).toEqual(TEST_MIN_HEIGHT);
|
||||||
|
});
|
||||||
|
|
||||||
|
});
|
||||||
|
}
|
||||||
|
);
|
||||||
@@ -1,5 +1,6 @@
|
|||||||
[
|
[
|
||||||
"FixedController",
|
"FixedController",
|
||||||
|
"FixedDragHandle",
|
||||||
"FixedProxy",
|
"FixedProxy",
|
||||||
"LayoutController",
|
"LayoutController",
|
||||||
"LayoutDrag",
|
"LayoutDrag",
|
||||||
@@ -10,6 +11,7 @@
|
|||||||
"elements/ElementProxies",
|
"elements/ElementProxies",
|
||||||
"elements/ElementProxy",
|
"elements/ElementProxy",
|
||||||
"elements/LineProxy",
|
"elements/LineProxy",
|
||||||
|
"elements/ResizeHandle",
|
||||||
"elements/TelemetryProxy",
|
"elements/TelemetryProxy",
|
||||||
"elements/TextProxy"
|
"elements/TextProxy"
|
||||||
]
|
]
|
||||||
Reference in New Issue
Block a user