From cf47f7c1b2bd54430461a361e3753e647b0d32dd Mon Sep 17 00:00:00 2001 From: John Hill Date: Thu, 20 Jan 2022 10:31:06 -0800 Subject: [PATCH] Task automation and test improvement (#4673) * Run full regression suite on PR * Limit concurrency to 2 workers * Update PULL_REQUEST_TEMPLATE.md * Added prcop config Co-authored-by: unlikelyzero Co-authored-by: Jamie V Co-authored-by: Andrew Henry --- .github/PULL_REQUEST_TEMPLATE.md | 16 ++++++++++++++++ .github/workflows/prcop-config.json | 19 +++++++++++++++++++ .github/workflows/prcop.yml | 23 +++++++++++++++++++++++ 3 files changed, 58 insertions(+) create mode 100644 .github/workflows/prcop-config.json create mode 100644 .github/workflows/prcop.yml diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 819bdf6fb6..a67581d1b6 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,3 +1,9 @@ + +Closes: + +### Describe your changes: + + ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing document](https://github.com/nasa/openmct/blob/master/CONTRIBUTING.md)? @@ -11,3 +17,13 @@ * [ ] Command line build passes? * [ ] Has this been smoke tested? * [ ] Testing instructions included in associated issue? + +### Reviewer Checklist + +* [ ] Changes appear to address issue? +* [ ] Changes appear not to be breaking changes? +* [ ] Appropriate unit tests included? +* [ ] Code style and in-line documentation are appropriate? +* [ ] Commit messages meet standards? +* [ ] Has associated issue been labelled unverified? (only applicable if this PR closes the issue) +* [ ] Has associated issue been labelled bug? (only applicable if this PR is for a bug fix) diff --git a/.github/workflows/prcop-config.json b/.github/workflows/prcop-config.json new file mode 100644 index 0000000000..9e43998028 --- /dev/null +++ b/.github/workflows/prcop-config.json @@ -0,0 +1,19 @@ +{ + "linters": [ + { + "name": "descriptionRegexp", + "config": { + "regexp": "x] Testing instructions", + "errorMessage": ":police_officer: PR Description does not confirm that associated issue(s) contain Testing instructions" + } + }, + { + "name": "descriptionMinWords", + "config": { + "minWordsCount": 160, + "errorMessage": ":police_officer: Please, be sure to use existing PR template." + } + } + ], + "disableWord": "prcop:disable" +} diff --git a/.github/workflows/prcop.yml b/.github/workflows/prcop.yml new file mode 100644 index 0000000000..88169d57c2 --- /dev/null +++ b/.github/workflows/prcop.yml @@ -0,0 +1,23 @@ +name: PRcop + +on: + pull_request: + types: + - edited + - synchronize + - ready_for_review + - review_requested + pull_request_review_comment: + types: + - created + +jobs: + prcop: + runs-on: ubuntu-latest + name: PRcop + steps: + - name: Linting Pull Request + uses: makaroni4/prcop@v1.0.31 + with: + config-file: ".github/workflows/prcop-config.json" + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}