Addressing issues from code review
This commit is contained in:
@@ -128,8 +128,7 @@ define(
|
||||
var typeKey = 'telemetry.panel',
|
||||
type = typeService.getType(typeKey),
|
||||
model = type.getInitialModel(),
|
||||
newPanel,
|
||||
composeAction;
|
||||
newPanel;
|
||||
|
||||
model.type = typeKey;
|
||||
newPanel = new EditableDomainObject(instantiate(model), $q);
|
||||
@@ -166,16 +165,12 @@ define(
|
||||
editableDomainObject = createVirtualPanel(domainObject, selectedObject);
|
||||
if (editableDomainObject) {
|
||||
editableDomainObject.getCapability('action').perform('edit');
|
||||
//navigationService.setNavigation(editableDomainObject);
|
||||
broadcastDrop(id, event);
|
||||
//editableDomainObject.getCapability('status').set('editing', true);
|
||||
}
|
||||
} else {
|
||||
$q.when(action && action.perform()).then(function (result) {
|
||||
//Don't go into edit mode for folders
|
||||
if (domainObjectType!=='folder') {
|
||||
// navigationService.setNavigation(editableDomainObject);
|
||||
//editableDomainObject.getCapability('status').set('editing', true);
|
||||
editableDomainObject.getCapability('action').perform('edit');
|
||||
}
|
||||
broadcastDrop(id, event);
|
||||
|
||||
Reference in New Issue
Block a user