Remove snapshot (#6783)

.github/workflows/e2e-couchdb.yml

@@ -7,33 +7,15 @@ on:
       - opened
 jobs:
   e2e-couchdb:
-    if: github.event.label.name == 'pr:e2e:couchdb' || github.event.action == 'opened' && github.actor == 'dependabot[bot]'
+    if: ${{ github.event.label.name == 'pr:e2e:couchdb' }} || ${{ github.event.action == 'opened' }}
     runs-on: ubuntu-latest
-    timeout-minutes: 60
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 'lts/hydrogen'
-
-      - name: Cache NPM dependencies
-        uses: actions/cache@v3
-        with:
-          path: ~/.npm
-          key: ${{ runner.os }}-node-${{ hashFiles('**/package.json') }}
-          restore-keys: |
-            ${{ runner.os }}-node-
-      
-      - run: npm install --cache ~/.npm --prefer-offline --no-audit --progress=false
-
-      - name: Login to DockerHub
-        uses: docker/login-action@v2 
-        with:
-          username: ${{ secrets.DOCKERHUB_USERNAME }}
-          password: ${{ secrets.DOCKERHUB_TOKEN }}
-      
+          node-version: 'lts/gallium'
       - run: npx playwright@1.32.3 install
-
+      - run: npm install
       - name: Start CouchDB Docker Container and Init with Setup Scripts
         run: |
           export $(cat src/plugins/persistence/couch/.env.ci | xargs)
@@ -41,31 +23,26 @@ jobs:
           sleep 3
           bash src/plugins/persistence/couch/setup-couchdb.sh
           bash src/plugins/persistence/couch/replace-localstorage-with-couchdb-indexhtml.sh
-
       - name: Run CouchDB Tests and publish to deploysentinel
         env:
           DEPLOYSENTINEL_API_KEY: ${{ secrets.DEPLOYSENTINEL_API_KEY }}
         run: npm run test:e2e:couchdb
-
       - name: Publish Results to Codecov.io
         env:
           SUPER_SECRET: ${{ secrets.CODECOV_TOKEN }}
         run: npm run cov:e2e:full:publish
-
       - name: Archive test results
         if: success() || failure()
         uses: actions/upload-artifact@v3
         with:
           path: test-results
-
       - name: Archive html test results
         if: success() || failure()
         uses: actions/upload-artifact@v3
         with:
           path: html-test-results
-
       - name: Remove pr:e2e:couchdb label (if present)
-        if: always()
+        if: ${{ contains(github.event.pull_request.labels.*.name, 'pr:e2e:couchdb') }}
         uses: actions/github-script@v6
         with:
           script: |
@@ -79,5 +56,5 @@ jobs:
                 name: labelToRemove
               });
             } catch (error) {
-              core.warning(`Failed to remove ' + labelToRemove + ' label: ${error.message}`);
+              core.warning(`Failed to remove 'pr:e2e:couchdb' label: ${error.message}`);
             }

.github/workflows/e2e-pr.yml

@@ -7,31 +7,31 @@ on:
       - opened
 jobs:
   e2e-full:
-    if: github.event.label.name == 'pr:e2e' || github.event.action == 'opened' && github.actor == 'dependabot[bot]'
+    if: ${{ github.event.label.name == 'pr:e2e' }}
     runs-on: ${{ matrix.os }}
-    timeout-minutes: 60
     strategy:
       matrix:
         os:
           - ubuntu-latest
           - windows-latest
     steps:
+      - name: Trigger Success
+        uses: actions/github-script@v6
+        with:
+          script: |
+            github.rest.issues.createComment({
+              issue_number: context.issue.number,
+              owner: "nasa",
+              repo: "openmct",
+              body: 'Started e2e Run. Follow along: https://github.com/nasa/openmct/actions/runs/' + context.runId
+            })
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 'lts/hydrogen'
-      
-      - name: Cache NPM dependencies
-        uses: actions/cache@v3
-        with:
-          path: ~/.npm
-          key: ${{ runner.os }}-node-${{ hashFiles('**/package.json') }}
-          restore-keys: |
-            ${{ runner.os }}-node-
-            
+          node-version: '16'
       - run: npx playwright@1.32.3 install
       - run: npx playwright install chrome-beta
-      - run: npm install --cache ~/.npm --prefer-offline --no-audit --progress=false
+      - run: npm install
       - run: npm run test:e2e:full -- --max-failures=40
       - run: npm run cov:e2e:report || true
       - shell: bash
@@ -44,9 +44,30 @@ jobs:
         uses: actions/upload-artifact@v3
         with:
           path: test-results
-
+      - name: Test success
+        if: ${{ success() }}
+        uses: actions/github-script@v6
+        with:
+          script: |
+            github.rest.issues.createComment({
+              issue_number: context.issue.number,
+              owner: "nasa",
+              repo: "openmct",
+              body: 'Success ✅ ! Build artifacts are here: https://github.com/nasa/openmct/actions/runs/' + context.runId
+            })
+      - name: Test failure
+        if: ${{ failure() }}
+        uses: actions/github-script@v6
+        with:
+          script: |
+            github.rest.issues.createComment({
+              issue_number: context.issue.number,
+              owner: "nasa",
+              repo: "openmct",
+              body: 'Failure ❌ ! Build artifacts are here: https://github.com/nasa/openmct/actions/runs/' + context.runId
+            })
       - name: Remove pr:e2e label (if present)
-        if: always()
+        if: ${{ contains(github.event.pull_request.labels.*.name, 'pr:e2e') }}
         uses: actions/github-script@v6
         with:
           script: |
@@ -60,5 +81,5 @@ jobs:
                 name: labelToRemove
               });
             } catch (error) {
-              core.warning(`Failed to remove ' + labelToRemove + ' label: ${error.message}`);
-            }
+              core.warning(`Failed to remove 'pr:e2e' label: ${error.message}`);
+            }

.github/workflows/npm-prerelease.yml

@@ -14,7 +14,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: lts/hydrogen
+          node-version: 16
       - run: npm install
       - run: |
           echo "//registry.npmjs.org/:_authToken=$NODE_AUTH_TOKEN" >> ~/.npmrc
@@ -29,7 +29,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: lts/hydrogen
+          node-version: 16
           registry-url: https://registry.npmjs.org/
       - run: npm install
       - run: npm publish --access=public --tag unstable

.github/workflows/pr-platform.yml

@@ -2,15 +2,12 @@ name: 'pr-platform'
 on:
   workflow_dispatch:
   pull_request:
-    types:
-      - labeled
-      - opened
+    types: [labeled]
 
 jobs:
-  pr-platform:
-    if: github.event.label.name == 'pr:platform' || github.event.action == 'opened' && github.actor == 'dependabot[bot]'
+  e2e-full:
+    if: ${{ github.event.label.name == 'pr:platform' }}
     runs-on: ${{ matrix.os }}
-    timeout-minutes: 60
     strategy:
       fail-fast: false
       matrix:
@@ -19,49 +16,18 @@ jobs:
           - macos-latest
           - windows-latest
         node_version:
-          - lts/gallium
-          - lts/hydrogen
+          - 16
+          - 18
         architecture:
           - x64
-    
     name: Node ${{ matrix.node_version }} - ${{ matrix.architecture }} on ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3
-      
       - name: Setup node
         uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node_version }}
           architecture: ${{ matrix.architecture }}
-
-      - name: Cache NPM dependencies
-        uses: actions/cache@v3
-        with:
-          path: ~/.npm
-          key: ${{ runner.os }}-${{ matrix.node_version }}-${{ hashFiles('**/package.json') }}
-          restore-keys: |
-            ${{ runner.os }}-${{ matrix.node_version }}-
-
-      - run: npm install --cache ~/.npm --prefer-offline --no-audit --progress=false
-      
+      - run: npm install
       - run: npm test
-      
       - run: npm run lint -- --quiet
-      
-      - name: Remove pr:platform label (if present)
-        if: always()
-        uses: actions/github-script@v6
-        with:
-          script: |
-            const { owner, repo, number } = context.issue;
-            const labelToRemove = 'pr:platform';
-            try {
-              await github.rest.issues.removeLabel({
-                owner,
-                repo,
-                issue_number: number,
-                name: labelToRemove
-              });
-            } catch (error) {
-              core.warning(`Failed to remove ' + labelToRemove + ' label: ${error.message}`);
-            }

.prettierrc

@@ -1,6 +1,5 @@
 {
   "trailingComma": "none",
   "singleQuote": true,
-  "printWidth": 100,
-  "endOfLine": "auto"
+  "printWidth": 100
 }

e2e/playwright-performance.config.js

@@ -23,10 +23,7 @@ const config = {
     ignoreHTTPSErrors: true,
     screenshot: 'off',
     trace: 'on-first-retry',
-    video: 'off',
-    launchOptions: {
-      args: ['--js-flags=--expose-gc']
-    }
+    video: 'off'
   },
   projects: [
     {

e2e/tests/performance/navigation-memory-leak-detection.perf.spec.js

@@ -1,251 +0,0 @@
-/*****************************************************************************
- * Open MCT, Copyright (c) 2014-2023, United States Government
- * as represented by the Administrator of the National Aeronautics and Space
- * Administration. All rights reserved.
- *
- * Open MCT is licensed under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0.
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations
- * under the License.
- *
- * Open MCT includes source code licensed under additional open source
- * licenses. See the Open Source Licenses file (LICENSES.md) included with
- * this source code distribution or the Licensing information page available
- * at runtime from the About dialog for additional information.
- *****************************************************************************/
-
-const { test, expect } = require('@playwright/test');
-
-const filePath = 'e2e/test-data/memory-leak-detection.json';
-/**
- * Executes tests to verify that views are not leaking memory on navigation away. This sort of
- * memory leak is generally caused by a failure to clean up registered listeners.
- *
- * These tests are executed on a set of pre-built displays loaded from ../test-data/memory-leak-detection.json.
- *
- * In order to modify the test data set:
- * 1. Run Open MCT locally (npm start)
- * 2. Right click on a folder in the tree, and select "Import From JSON"
- * 3. In the subsequent dialog, select the file ../test-data/memory-leak-detection.json
- * 4. Click "OK"
- * 5. Modify test objects as desired
- * 6. Right click on the "Memory Leak Detection" folder, and select "Export to JSON"
- * 7. Copy the exported file to ../test-data/memory-leak-detection.json
- *
- */
-test.describe('Navigation memory leak is not detected in', () => {
-  test.beforeEach(async ({ page, browser }, testInfo) => {
-    // Go to baseURL
-    await page.goto('./', { waitUntil: 'networkidle' });
-
-    // Click a:has-text("My Items")
-    await page.locator('a:has-text("My Items")').click({
-      button: 'right'
-    });
-
-    // Click text=Import from JSON
-    await page.locator('text=Import from JSON').click();
-
-    // Upload memory-leak-detection.json
-    await page.setInputFiles('#fileElem', filePath);
-
-    // Click text=OK
-    await page.locator('text=OK').click();
-
-    await expect(page.locator('a:has-text("Memory Leak Detection")')).toBeVisible();
-  });
-
-  test('plot view', async ({ page }) => {
-    const result = await navigateToObjectAndDetectMemoryLeak(page, 'overlay-plot-single-1hz-swg');
-
-    // If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
-    expect(result).toBe(true);
-  });
-
-  test('stacked plot view', async ({ page }) => {
-    const result = await navigateToObjectAndDetectMemoryLeak(page, 'stacked-plot-single-1hz-swg');
-
-    // If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
-    expect(result).toBe(true);
-  });
-
-  test('LAD table view', async ({ page }) => {
-    const result = await navigateToObjectAndDetectMemoryLeak(page, 'lad-table-single-1hz-swg');
-
-    // If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
-    expect(result).toBe(true);
-  });
-
-  test('LAD table set', async ({ page }) => {
-    const result = await navigateToObjectAndDetectMemoryLeak(page, 'lad-table-set-single-1hz-swg');
-
-    // If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
-    expect(result).toBe(true);
-  });
-
-  test('telemetry table view', async ({ page }) => {
-    const result = await navigateToObjectAndDetectMemoryLeak(
-      page,
-      'telemetry-table-single-1hz-swg'
-    );
-
-    // If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
-    expect(result).toBe(true);
-  });
-
-  test('notebook view', async ({ page }) => {
-    const result = await navigateToObjectAndDetectMemoryLeak(
-      page,
-      'notebook-memory-leak-detection-test'
-    );
-
-    // If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
-    expect(result).toBe(true);
-  });
-
-  test('display layout of a single SWG alphanumeric', async ({ page }) => {
-    const result = await navigateToObjectAndDetectMemoryLeak(page, 'display-layout-single-1hz-swg');
-
-    // If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
-    expect(result).toBe(true);
-  });
-
-  test('display layout of a single SWG plot', async ({ page }) => {
-    const result = await navigateToObjectAndDetectMemoryLeak(
-      page,
-      'display-layout-single-overlay-plot'
-    );
-
-    // If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
-    expect(result).toBe(true);
-  });
-
-  test.skip('example imagery view', async ({ page }) => {
-    const result = await navigateToObjectAndDetectMemoryLeak(
-      page,
-      'example-imagery-memory-leak-test'
-    );
-
-    // If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
-    expect(result).toBe(true);
-  });
-
-  test.skip('display layout of example imagery views', async ({ page }) => {
-    const result = await navigateToObjectAndDetectMemoryLeak(
-      page,
-      'display-layout-images-memory-leak-test'
-    );
-
-    // If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
-    expect(result).toBe(true);
-  });
-
-  test.skip('display layout with plots of swgs, alphanumerics, and condition sets, ', async ({
-    page
-  }) => {
-    const result = await navigateToObjectAndDetectMemoryLeak(
-      page,
-      'display-layout-simple-telemetry'
-    );
-
-    // If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
-    expect(result).toBe(true);
-  });
-
-  test.skip('flexible layout with plots of swgs', async ({ page }) => {
-    const result = await navigateToObjectAndDetectMemoryLeak(
-      page,
-      'flexible-layout-plots-memory-leak-test'
-    );
-
-    // If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
-    expect(result).toBe(true);
-  });
-
-  test.skip('flexible layout of example imagery views', async ({ page }) => {
-    const result = await navigateToObjectAndDetectMemoryLeak(
-      page,
-      'flexible-layout-images-memory-leak-test'
-    );
-
-    // If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
-    expect(result).toBe(true);
-  });
-
-  test.skip('tabbed view of display layouts and time strips', async ({ page }) => {
-    const result = await navigateToObjectAndDetectMemoryLeak(
-      page,
-      'tab-view-simple-memory-leak-test'
-    );
-
-    // If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
-    expect(result).toBe(true);
-  });
-
-  test.skip('time strip view of telemetry', async ({ page }) => {
-    const result = await navigateToObjectAndDetectMemoryLeak(
-      page,
-      'time-strip-telemetry-memory-leak-test'
-    );
-
-    // If we got here without timing out, then the root view object was garbage collected and no memory leak was detected.
-    expect(result).toBe(true);
-  });
-
-  async function navigateToObjectAndDetectMemoryLeak(page, objectName) {
-    await page.locator('[aria-label="OpenMCT Search"] input[type="search"]').click();
-    // Fill Search input
-    await page.locator('[aria-label="OpenMCT Search"] input[type="search"]').fill(objectName);
-
-    //Search Result Appears and is clicked
-    await Promise.all([
-      page.locator(`div.c-gsearch-result__title:has-text("${objectName}")`).first().click(),
-      page.waitForNavigation()
-    ]);
-
-    // Register a finalization listener on the root node for the view. This tends to be the last thing to be
-    // garbage collected since it has either direct or indirect references to all resources used by the view. Therefore it's a pretty good proxy
-    // for detecting memory leaks.
-    await page.evaluate(() => {
-      window.gcPromise = new Promise((resolve) => {
-        // eslint-disable-next-line no-undef
-        window.fr = new FinalizationRegistry(resolve);
-        window.fr.register(
-          window.openmct.layout.$refs.browseObject.$refs.objectViewWrapper.firstChild.__vue__,
-          'navigatedObject',
-          window.openmct.layout.$refs.browseObject.$refs.objectViewWrapper.firstChild.__vue__
-        );
-      });
-    });
-
-    // Nav back to folder
-    await page.goto('./#/browse/mine', { waitUntil: 'networkidle' });
-    await page.waitForNavigation();
-
-    // This next code block blocks until the finalization listener is called and the gcPromise resolved. This means that the root node for the view has been garbage collected.
-    // In the event that the root node is not garbage collected, the gcPromise will never resolve and the test will time out.
-    await page.evaluate(() => {
-      const gcPromise = window.gcPromise;
-      window.gcPromise = null;
-
-      // Manually invoke the garbage collector once all references are removed.
-      window.gc();
-
-      return gcPromise;
-    });
-
-    // Clean up the finalization registry since we don't need it any more.
-    await page.evaluate(() => {
-      window.fr = null;
-    });
-
-    // If we get here without timing out, it means the garbage collection promise resolved and the test passed.
-    return true;
-  }
-});

package.json

@@ -1,9 +1,9 @@
 {
   "name": "openmct",
-  "version": "2.2.6-SNAPSHOT",
+  "version": "2.2.5",
   "description": "The Open MCT core platform",
   "devDependencies": {
-    "@babel/eslint-parser": "7.22.5",
+    "@babel/eslint-parser": "7.21.8",
     "@braintree/sanitize-url": "6.0.2",
     "@deploysentinel/playwright": "0.3.4",
     "@percy/cli": "1.26.0",
@@ -21,16 +21,16 @@
     "d3-axis": "3.0.0",
     "d3-scale": "3.3.0",
     "d3-selection": "3.0.0",
-    "eslint": "8.43.0",
+    "eslint": "8.42.0",
     "eslint-plugin-compat": "4.1.4",
     "eslint-config-prettier": "8.8.0",
     "eslint-plugin-playwright": "0.12.0",
     "eslint-plugin-prettier": "4.2.1",
-    "eslint-plugin-vue": "9.15.0",
+    "eslint-plugin-vue": "9.14.1",
     "eslint-plugin-you-dont-need-lodash-underscore": "6.12.0",
     "eventemitter3": "1.2.0",
     "file-saver": "2.0.5",
-    "flatbush": "4.2.0",
+    "flatbush": "4.1.0",
     "git-rev-sync": "3.0.2",
     "html2canvas": "1.4.1",
     "imports-loader": "4.0.1",
@@ -59,8 +59,8 @@
     "prettier": "2.8.7",
     "printj": "1.3.1",
     "resolve-url-loader": "5.0.0",
-    "sanitize-html": "2.11.0",
-    "sass": "1.63.4",
+    "sanitize-html": "2.10.0",
+    "sass": "1.63.3",
     "sass-loader": "13.3.2",
     "sinon": "15.1.0",
     "style-loader": "3.3.3",
@@ -70,7 +70,7 @@
     "vue-eslint-parser": "9.3.1",
     "vue-loader": "15.9.8",
     "vue-template-compiler": "2.6.14",
-    "webpack": "5.88.0",
+    "webpack": "5.86.0",
     "webpack-cli": "5.1.1",
     "webpack-dev-server": "4.15.1",
     "webpack-merge": "5.9.0"

src/plugins/imagery/components/AnnotationsCanvas.vue

@@ -89,11 +89,6 @@ export default {
       }
     }
   },
-  watch: {
-    imageryAnnotations() {
-      this.drawAnnotations();
-    }
-  },
   mounted() {
     this.canvas = this.$refs.canvas;
     this.context = this.canvas.getContext('2d');