Compare commits

...

4 Commits

Author SHA1 Message Date
Shefali Joshi
ab76a25f0c Merge branch 'master' into collimate-stacked-plots 2021-09-28 13:23:58 -07:00
David Tsay
5667d70109 Merge branch 'master' into collimate-stacked-plots 2021-09-16 21:30:42 -07:00
David Tsay
e6a71d85ac code cleanup 2021-08-19 10:11:46 -07:00
David Tsay
8a3d3dbfc1 make tick width reactive 2021-08-18 17:13:14 -07:00
2 changed files with 10 additions and 13 deletions

View File

@@ -593,7 +593,9 @@ export default {
} }
} }
this.$emit('plotTickWidth', this.tickWidth); const id = this.openmct.objects.makeKeyString(this.domainObject.identifier);
this.$emit('plotTickWidth', this.tickWidth, id);
}, },
trackMousePosition(event) { trackMousePosition(event) {

View File

@@ -90,7 +90,8 @@ export default {
cursorGuide: false, cursorGuide: false,
gridLines: true, gridLines: true,
loading: false, loading: false,
compositionObjects: [] compositionObjects: [],
tickWidthMap: {}
}; };
}, },
computed: { computed: {
@@ -106,8 +107,6 @@ export default {
this.imageExporter = new ImageExporter(this.openmct); this.imageExporter = new ImageExporter(this.openmct);
this.tickWidthMap = {};
this.composition.on('add', this.addChild); this.composition.on('add', this.addChild);
this.composition.on('remove', this.removeChild); this.composition.on('remove', this.removeChild);
this.composition.on('reorder', this.compositionReorder); this.composition.on('reorder', this.compositionReorder);
@@ -127,18 +126,21 @@ export default {
addChild(child) { addChild(child) {
const id = this.openmct.objects.makeKeyString(child.identifier); const id = this.openmct.objects.makeKeyString(child.identifier);
this.tickWidthMap[id] = 0; this.$set(this.tickWidthMap, id, 0);
this.compositionObjects.push(child); this.compositionObjects.push(child);
}, },
removeChild(childIdentifier) { removeChild(childIdentifier) {
const id = this.openmct.objects.makeKeyString(childIdentifier); const id = this.openmct.objects.makeKeyString(childIdentifier);
delete this.tickWidthMap[id];
this.$delete(this.tickWidthMap, id);
const childObj = this.compositionObjects.filter((c) => { const childObj = this.compositionObjects.filter((c) => {
const identifier = this.openmct.objects.makeKeyString(c.identifier); const identifier = this.openmct.objects.makeKeyString(c.identifier);
return identifier === id; return identifier === id;
})[0]; })[0];
if (childObj) { if (childObj) {
const index = this.compositionObjects.indexOf(childObj); const index = this.compositionObjects.indexOf(childObj);
this.compositionObjects.splice(index, 1); this.compositionObjects.splice(index, 1);
@@ -191,14 +193,7 @@ export default {
return; return;
} }
//update the tickWidth for this plotId, the computed max tick width of the stacked plot will be cascaded down
//TODO: Might need to do this using $set
this.tickWidthMap[plotId] = Math.max(width, this.tickWidthMap[plotId]); this.tickWidthMap[plotId] = Math.max(width, this.tickWidthMap[plotId]);
// const newTickWidth = Math.max(...Object.values(this.tickWidthMap));
// if (newTickWidth !== tickWidth || width !== tickWidth) {
// tickWidth = newTickWidth;
// $scope.$broadcast('plot:tickWidth', tickWidth);
// }
} }
} }
}; };