openmct/src/api/telemetry/TelemetryAPISpec.js

/*****************************************************************************
 * Open MCT, Copyright (c) 2014-2022, United States Government
 * as represented by the Administrator of the National Aeronautics and Space
 * Administration. All rights reserved.
 *
 * Open MCT is licensed under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 * http://www.apache.org/licenses/LICENSE-2.0.
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
 * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 * License for the specific language governing permissions and limitations
 * under the License.
 *
 * Open MCT includes source code licensed under additional open source
 * licenses. See the Open Source Licenses file (LICENSES.md) included with
 * this source code distribution or the Licensing information page available
 * at runtime from the About dialog for additional information.
 *****************************************************************************/
import { createOpenMct, resetApplicationState } from 'utils/testing';
import TelemetryAPI from './TelemetryAPI';
import TelemetryCollection from './TelemetryCollection';

describe('Telemetry API', function () {
    let openmct;
    let telemetryAPI;

    beforeEach(function () {
        openmct = {
            time: jasmine.createSpyObj('timeAPI', [
                'timeSystem',
                'bounds'
            ]),
            types: jasmine.createSpyObj('typeRegistry', [
                'get'
            ])
        };

        openmct.time.timeSystem.and.returnValue({key: 'system'});
        openmct.time.bounds.and.returnValue({
            start: 0,
            end: 1
        });
        telemetryAPI = new TelemetryAPI(openmct);

    });

    describe('telemetry providers', function () {
        let telemetryProvider;
        let domainObject;

        beforeEach(function () {
            telemetryProvider = jasmine.createSpyObj('telemetryProvider', [
                'supportsSubscribe',
                'subscribe',
                'supportsRequest',
                'request'
            ]);
            domainObject = {
                identifier: {
                    key: 'a',
                    namespace: 'b'
                },
                type: 'sample-type'
            };

            openmct.notifications = {
                error: () => {
                    console.log('sample error notification');
                }
            };
        });

        it('provides consistent results without providers', function (done) {
            const unsubscribe = telemetryAPI.subscribe(domainObject);

            expect(unsubscribe).toEqual(jasmine.any(Function));

            telemetryAPI.request(domainObject)
                .then((data) => {
                    expect(data).toEqual([]);
                })
                .finally(done);
        });

        it('skips providers that do not match', function (done) {
            telemetryProvider.supportsSubscribe.and.returnValue(false);
            telemetryProvider.supportsRequest.and.returnValue(false);
            telemetryProvider.request.and.returnValue(Promise.resolve([]));
            telemetryAPI.addProvider(telemetryProvider);

            const callback = jasmine.createSpy('callback');
            const unsubscribe = telemetryAPI.subscribe(domainObject, callback);
            expect(telemetryProvider.supportsSubscribe)
                .toHaveBeenCalledWith(domainObject);
            expect(telemetryProvider.subscribe).not.toHaveBeenCalled();
            expect(unsubscribe).toEqual(jasmine.any(Function));

            telemetryAPI.request(domainObject).then((response) => {
                expect(telemetryProvider.supportsRequest)
                    .toHaveBeenCalledWith(domainObject, jasmine.any(Object));
                expect(telemetryProvider.request).not.toHaveBeenCalled();
            }).finally(done);
        });

        it('sends subscribe calls to matching providers', function () {
            const unsubFunc = jasmine.createSpy('unsubscribe');
            telemetryProvider.subscribe.and.returnValue(unsubFunc);
            telemetryProvider.supportsSubscribe.and.returnValue(true);
            telemetryAPI.addProvider(telemetryProvider);

            const callback = jasmine.createSpy('callback');
            const unsubscribe = telemetryAPI.subscribe(domainObject, callback);
            expect(telemetryProvider.supportsSubscribe.calls.count()).toBe(1);
            expect(telemetryProvider.supportsSubscribe)
                .toHaveBeenCalledWith(domainObject);
            expect(telemetryProvider.subscribe.calls.count()).toBe(1);
            expect(telemetryProvider.subscribe)
                .toHaveBeenCalledWith(domainObject, jasmine.any(Function), undefined);

            const notify = telemetryProvider.subscribe.calls.mostRecent().args[1];
            notify('someValue');
            expect(callback).toHaveBeenCalledWith('someValue');

            expect(unsubscribe).toEqual(jasmine.any(Function));
            expect(unsubFunc).not.toHaveBeenCalled();
            unsubscribe();
            expect(unsubFunc).toHaveBeenCalled();

            notify('otherValue');
            expect(callback).not.toHaveBeenCalledWith('otherValue');
        });

        it('subscribes once per object', function () {
            const unsubFunc = jasmine.createSpy('unsubscribe');
            telemetryProvider.subscribe.and.returnValue(unsubFunc);
            telemetryProvider.supportsSubscribe.and.returnValue(true);
            telemetryAPI.addProvider(telemetryProvider);

            const callback = jasmine.createSpy('callback');
            const callbacktwo = jasmine.createSpy('callback two');
            const unsubscribe = telemetryAPI.subscribe(domainObject, callback);
            const unsubscribetwo = telemetryAPI.subscribe(domainObject, callbacktwo);

            expect(telemetryProvider.subscribe.calls.count()).toBe(1);

            const notify = telemetryProvider.subscribe.calls.mostRecent().args[1];
            notify('someValue');
            expect(callback).toHaveBeenCalledWith('someValue');
            expect(callbacktwo).toHaveBeenCalledWith('someValue');

            unsubscribe();
            expect(unsubFunc).not.toHaveBeenCalled();
            notify('otherValue');
            expect(callback).not.toHaveBeenCalledWith('otherValue');
            expect(callbacktwo).toHaveBeenCalledWith('otherValue');

            unsubscribetwo();
            expect(unsubFunc).toHaveBeenCalled();
            notify('anotherValue');
            expect(callback).not.toHaveBeenCalledWith('anotherValue');
            expect(callbacktwo).not.toHaveBeenCalledWith('anotherValue');
        });

        it('only deletes subscription cache when there are no more subscribers', function () {
            const unsubFunc = jasmine.createSpy('unsubscribe');
            telemetryProvider.subscribe.and.returnValue(unsubFunc);
            telemetryProvider.supportsSubscribe.and.returnValue(true);
            telemetryAPI.addProvider(telemetryProvider);

            const callback = jasmine.createSpy('callback');
            const callbacktwo = jasmine.createSpy('callback two');
            const callbackThree = jasmine.createSpy('callback three');
            const unsubscribe = telemetryAPI.subscribe(domainObject, callback);
            const unsubscribeTwo = telemetryAPI.subscribe(domainObject, callbacktwo);

            expect(telemetryProvider.subscribe.calls.count()).toBe(1);
            unsubscribe();
            const unsubscribeThree = telemetryAPI.subscribe(domainObject, callbackThree);
            // Regression test for where subscription cache was deleted on each unsubscribe, resulting in
            // superfluous additional subscriptions. If the subscription cache is being deleted on each unsubscribe,
            // then a subsequent subscribe will result in a new subscription at the provider.
            expect(telemetryProvider.subscribe.calls.count()).toBe(1);
            unsubscribeTwo();
            unsubscribeThree();
        });

        it('does subscribe/unsubscribe', function () {
            const unsubFunc = jasmine.createSpy('unsubscribe');
            telemetryProvider.subscribe.and.returnValue(unsubFunc);
            telemetryProvider.supportsSubscribe.and.returnValue(true);
            telemetryAPI.addProvider(telemetryProvider);

            const callback = jasmine.createSpy('callback');
            let unsubscribe = telemetryAPI.subscribe(domainObject, callback);
            expect(telemetryProvider.subscribe.calls.count()).toBe(1);
            unsubscribe();

            unsubscribe = telemetryAPI.subscribe(domainObject, callback);
            expect(telemetryProvider.subscribe.calls.count()).toBe(2);
            unsubscribe();
        });

        it('subscribes for different object', function () {
            const unsubFuncs = [];
            const notifiers = [];
            telemetryProvider.supportsSubscribe.and.returnValue(true);
            telemetryProvider.subscribe.and.callFake(function (obj, cb) {
                const unsubFunc = jasmine.createSpy('unsubscribe ' + unsubFuncs.length);
                unsubFuncs.push(unsubFunc);
                notifiers.push(cb);

                return unsubFunc;
            });
            telemetryAPI.addProvider(telemetryProvider);

            const otherDomainObject = JSON.parse(JSON.stringify(domainObject));
            otherDomainObject.identifier.namespace = 'other';

            const callback = jasmine.createSpy('callback');
            const callbacktwo = jasmine.createSpy('callback two');

            const unsubscribe = telemetryAPI.subscribe(domainObject, callback);
            const unsubscribetwo = telemetryAPI.subscribe(otherDomainObject, callbacktwo);

            expect(telemetryProvider.subscribe.calls.count()).toBe(2);

            notifiers[0]('someValue');
            expect(callback).toHaveBeenCalledWith('someValue');
            expect(callbacktwo).not.toHaveBeenCalledWith('someValue');

            notifiers[1]('anotherValue');
            expect(callback).not.toHaveBeenCalledWith('anotherValue');
            expect(callbacktwo).toHaveBeenCalledWith('anotherValue');

            unsubscribe();
            expect(unsubFuncs[0]).toHaveBeenCalled();
            expect(unsubFuncs[1]).not.toHaveBeenCalled();

            unsubscribetwo();
            expect(unsubFuncs[1]).toHaveBeenCalled();
        });

        it('sends requests to matching providers', function (done) {
            const telemPromise = Promise.resolve([]);
            telemetryProvider.supportsRequest.and.returnValue(true);
            telemetryProvider.request.and.returnValue(telemPromise);
            telemetryAPI.addProvider(telemetryProvider);

            telemetryAPI.request(domainObject).then(() => {
                expect(telemetryProvider.supportsRequest).toHaveBeenCalledWith(
                    domainObject,
                    jasmine.any(Object)
                );
                expect(telemetryProvider.request).toHaveBeenCalledWith(
                    domainObject,
                    jasmine.any(Object)
                );
            }).finally(done);
        });

        it('generates default request options', function (done) {
            telemetryProvider.supportsRequest.and.returnValue(true);
            telemetryProvider.request.and.returnValue(Promise.resolve([]));
            telemetryAPI.addProvider(telemetryProvider);

            telemetryAPI.request(domainObject).then(() => {
                const { signal } = new AbortController();
                expect(telemetryProvider.supportsRequest).toHaveBeenCalledWith(
                    jasmine.any(Object),
                    {
                        signal,
                        start: 0,
                        end: 1,
                        domain: 'system'
                    }
                );

                expect(telemetryProvider.request).toHaveBeenCalledWith(
                    jasmine.any(Object),
                    {
                        signal,
                        start: 0,
                        end: 1,
                        domain: 'system'
                    }
                );

                telemetryProvider.supportsRequest.calls.reset();
                telemetryProvider.request.calls.reset();

                telemetryAPI.request(domainObject, {}).then(() => {
                    expect(telemetryProvider.supportsRequest).toHaveBeenCalledWith(
                        jasmine.any(Object),
                        {
                            signal,
                            start: 0,
                            end: 1,
                            domain: 'system'
                        }
                    );

                    expect(telemetryProvider.request).toHaveBeenCalledWith(
                        jasmine.any(Object),
                        {
                            signal,
                            start: 0,
                            end: 1,
                            domain: 'system'
                        }
                    );
                });
            }).finally(done);

        });

        it('do not overwrite existing request options', function (done) {
            telemetryProvider.supportsRequest.and.returnValue(true);
            telemetryProvider.request.and.returnValue(Promise.resolve([]));
            telemetryAPI.addProvider(telemetryProvider);

            telemetryAPI.request(domainObject, {
                start: 20,
                end: 30,
                domain: 'someDomain'
            }).then(() => {
                const { signal } = new AbortController();
                expect(telemetryProvider.supportsRequest).toHaveBeenCalledWith(
                    jasmine.any(Object),
                    {
                        start: 20,
                        end: 30,
                        domain: 'someDomain',
                        signal
                    }
                );

                expect(telemetryProvider.request).toHaveBeenCalledWith(
                    jasmine.any(Object),
                    {
                        start: 20,
                        end: 30,
                        domain: 'someDomain',
                        signal
                    }
                );

            }).finally(done);
        });
    });

    describe('metadata', function () {
        let mockMetadata = {};
        let mockObjectType = {
            definition: {}
        };
        beforeEach(function () {
            telemetryAPI.addProvider({
                key: 'mockMetadataProvider',
                supportsMetadata() {
                    return true;
                },
                getMetadata() {
                    return mockMetadata;
                }
            });
            openmct.types.get.and.returnValue(mockObjectType);
        });

        it('respects explicit priority', function () {
            mockMetadata.values = [
                {
                    key: "name",
                    name: "Name",
                    hints: {
                        priority: 2
                    }

                },
                {
                    key: "timestamp",
                    name: "Timestamp",
                    hints: {
                        priority: 1
                    }
                },
                {
                    key: "sin",
                    name: "Sine",
                    hints: {
                        priority: 4
                    }
                },
                {
                    key: "cos",
                    name: "Cosine",
                    hints: {
                        priority: 3
                    }
                }
            ];
            let metadata = telemetryAPI.getMetadata({});
            let values = metadata.values();

            values.forEach((value, index) => {
                expect(value.hints.priority).toBe(index + 1);
            });
        });
        it('if no explicit priority, defaults to order defined', function () {
            mockMetadata.values = [
                {
                    key: "name",
                    name: "Name"

                },
                {
                    key: "timestamp",
                    name: "Timestamp"
                },
                {
                    key: "sin",
                    name: "Sine"
                },
                {
                    key: "cos",
                    name: "Cosine"
                }
            ];
            let metadata = telemetryAPI.getMetadata({});
            let values = metadata.values();

            values.forEach((value, index) => {
                expect(value.key).toBe(mockMetadata.values[index].key);
            });
        });
        it('respects domain priority', function () {
            mockMetadata.values = [
                {
                    key: "name",
                    name: "Name"

                },
                {
                    key: "timestamp-utc",
                    name: "Timestamp UTC",
                    hints: {
                        domain: 2
                    }
                },
                {
                    key: "timestamp-local",
                    name: "Timestamp Local",
                    hints: {
                        domain: 1
                    }
                },
                {
                    key: "sin",
                    name: "Sine",
                    hints: {
                        range: 2
                    }
                },
                {
                    key: "cos",
                    name: "Cosine",
                    hints: {
                        range: 1
                    }
                }
            ];
            let metadata = telemetryAPI.getMetadata({});
            let values = metadata.valuesForHints(['domain']);

            expect(values[0].key).toBe('timestamp-local');
            expect(values[1].key).toBe('timestamp-utc');
        });
        it('respects range priority', function () {
            mockMetadata.values = [
                {
                    key: "name",
                    name: "Name"

                },
                {
                    key: "timestamp-utc",
                    name: "Timestamp UTC",
                    hints: {
                        domain: 2
                    }
                },
                {
                    key: "timestamp-local",
                    name: "Timestamp Local",
                    hints: {
                        domain: 1
                    }
                },
                {
                    key: "sin",
                    name: "Sine",
                    hints: {
                        range: 2
                    }
                },
                {
                    key: "cos",
                    name: "Cosine",
                    hints: {
                        range: 1
                    }
                }
            ];
            let metadata = telemetryAPI.getMetadata({});
            let values = metadata.valuesForHints(['range']);

            expect(values[0].key).toBe('cos');
            expect(values[1].key).toBe('sin');
        });
        it('respects priority and domain ordering', function () {
            mockMetadata.values = [
                {
                    key: "id",
                    name: "ID",
                    hints: {
                        priority: 2
                    }
                },
                {
                    key: "name",
                    name: "Name",
                    hints: {
                        priority: 1
                    }

                },
                {
                    key: "timestamp-utc",
                    name: "Timestamp UTC",
                    hints: {
                        domain: 2,
                        priority: 1
                    }
                },
                {
                    key: "timestamp-local",
                    name: "Timestamp Local",
                    hints: {
                        domain: 1,
                        priority: 2
                    }
                },
                {
                    key: "timestamp-pst",
                    name: "Timestamp PST",
                    hints: {
                        domain: 3,
                        priority: 2
                    }
                },
                {
                    key: "sin",
                    name: "Sine"
                },
                {
                    key: "cos",
                    name: "Cosine"
                }
            ];
            let metadata = telemetryAPI.getMetadata({});
            let values = metadata.valuesForHints(['priority', 'domain']);
            [
                'timestamp-utc',
                'timestamp-local',
                'timestamp-pst'
            ].forEach((key, index) => {
                expect(values[index].key).toBe(key);
            });
        });
    });

    describe('telemetry collections', () => {
        let domainObject;
        let mockMetadata = {};
        let mockObjectType = {
            definition: {}
        };

        beforeEach(function () {
            openmct.telemetry = telemetryAPI;
            telemetryAPI.addProvider({
                key: 'mockMetadataProvider',
                supportsMetadata() {
                    return true;
                },
                getMetadata() {
                    return mockMetadata;
                }
            });
            openmct.types.get.and.returnValue(mockObjectType);
            domainObject = {
                identifier: {
                    key: 'a',
                    namespace: 'b'
                },
                type: 'sample-type'
            };
        });

        it('when requested, returns an instance of telemetry collection', () => {
            const telemetryCollection = telemetryAPI.requestCollection(domainObject);

            expect(telemetryCollection).toBeInstanceOf(TelemetryCollection);
        });

    });
});

describe('Telemetery', () => {
    let openmct;
    let telemetryProvider;
    let telemetryAPI;
    let watchedSignal;

    beforeEach(() => {
        openmct = createOpenMct();
        openmct.install(openmct.plugins.MyItems());

        telemetryAPI = openmct.telemetry;

        telemetryProvider = {
            request: (obj, options) => {
                watchedSignal = options.signal;

                return Promise.resolve();
            }
        };
        spyOn(telemetryAPI, 'findRequestProvider').and.returnValue(telemetryProvider);
    });

    afterEach(() => {
        return resetApplicationState(openmct);
    });

    it('should not abort request without navigation', function (done) {
        telemetryAPI.addProvider(telemetryProvider);

        telemetryAPI.request({}).finally(() => {
            expect(watchedSignal.aborted).toBe(false);
            done();
        });
    });

    it('should abort request on navigation', function (done) {
        telemetryAPI.addProvider(telemetryProvider);

        telemetryAPI.request({}).finally(() => {
            expect(watchedSignal.aborted).toBe(true);
            done();
        });
        openmct.router.doPathChange('newPath', 'oldPath');
    });
});