alihan/openshift-mcp-server
1
0
Fork 0
mirror of https://github.com/openshift/openshift-mcp-server.git synced 2025-10-17 14:27:48 +03:00
Code Issues Packages Projects Releases Wiki Activity

test(mcp): remove side-effects from toolsets tests (#329)

Browse Source 
Signed-off-by: Marc Nuri <marc@marcnuri.com>
This commit is contained in:
Marc Nuri
2025-09-17 12:06:33 +02:00
committed by GitHub
parent d6936f42d3
commit 2bf6c549fe
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/mcp/toolsets_test.go
View File

@@ -30,13 +30,13 @@ type ToolsetsSuite struct {
func (s *ToolsetsSuite) SetupTest() { func (s *ToolsetsSuite) SetupTest() {
s.originalToolsets = toolsets.Toolsets() s.originalToolsets = toolsets.Toolsets()
toolsets.Clear()
s.MockServer = test.NewMockServer() s.MockServer = test.NewMockServer()
s.Cfg = configuration.Default() s.Cfg = configuration.Default()
s.Cfg.KubeConfig = s.MockServer.KubeconfigFile(s.T()) s.Cfg.KubeConfig = s.MockServer.KubeconfigFile(s.T())
} }
func (s *ToolsetsSuite) TearDownTest() { func (s *ToolsetsSuite) TearDownTest() {
toolsets.Clear()
for _, toolset := range s.originalToolsets { for _, toolset := range s.originalToolsets {
toolsets.Register(toolset) toolsets.Register(toolset)
} }
@@ -54,6 +54,7 @@ func (s *ToolsetsSuite) TearDownSubTest() {
func (s *ToolsetsSuite) TestNoToolsets() { func (s *ToolsetsSuite) TestNoToolsets() {
s.Run("No toolsets registered", func() { s.Run("No toolsets registered", func() {
toolsets.Clear()
s.Cfg.Toolsets = []string{} s.Cfg.Toolsets = []string{}
s.InitMcpClient() s.InitMcpClient()
tools, err := s.ListTools(s.T().Context(), mcp.ListToolsRequest{}) tools, err := s.ListTools(s.T().Context(), mcp.ListToolsRequest{})
@@ -67,10 +68,6 @@ func (s *ToolsetsSuite) TestNoToolsets() {
func (s *ToolsetsSuite) TestDefaultToolsetsTools() { func (s *ToolsetsSuite) TestDefaultToolsetsTools() {
s.Run("Default configuration toolsets", func() { s.Run("Default configuration toolsets", func() {
s.Cfg.Toolsets = configuration.Default().Toolsets
toolsets.Register(&core.Toolset{})
toolsets.Register(&config.Toolset{})
toolsets.Register(&helm.Toolset{})
s.InitMcpClient() s.InitMcpClient()
tools, err := s.ListTools(s.T().Context(), mcp.ListToolsRequest{}) tools, err := s.ListTools(s.T().Context(), mcp.ListToolsRequest{})
s.Run("ListTools returns tools", func() { s.Run("ListTools returns tools", func() {
@@ -92,10 +89,6 @@ func (s *ToolsetsSuite) TestDefaultToolsetsTools() {
func (s *ToolsetsSuite) TestDefaultToolsetsToolsInOpenShift() { func (s *ToolsetsSuite) TestDefaultToolsetsToolsInOpenShift() {
s.Run("Default configuration toolsets in OpenShift", func() { s.Run("Default configuration toolsets in OpenShift", func() {
s.Handle(&test.InOpenShiftHandler{}) s.Handle(&test.InOpenShiftHandler{})
s.Cfg.Toolsets = configuration.Default().Toolsets
toolsets.Register(&core.Toolset{})
toolsets.Register(&config.Toolset{})
toolsets.Register(&helm.Toolset{})
s.InitMcpClient() s.InitMcpClient()
tools, err := s.ListTools(s.T().Context(), mcp.ListToolsRequest{}) tools, err := s.ListTools(s.T().Context(), mcp.ListToolsRequest{})
s.Run("ListTools returns tools", func() { s.Run("ListTools returns tools", func() {
@@ -122,6 +115,7 @@ func (s *ToolsetsSuite) TestGranularToolsetsTools() {
} }
for _, testCase := range testCases { for _, testCase := range testCases {
s.Run("Toolset "+testCase.GetName(), func() { s.Run("Toolset "+testCase.GetName(), func() {
toolsets.Clear()
toolsets.Register(testCase) toolsets.Register(testCase)
s.Cfg.Toolsets = []string{testCase.GetName()} s.Cfg.Toolsets = []string{testCase.GetName()}
s.InitMcpClient() s.InitMcpClient()