alihan/textual
1
0
Fork 0
mirror of https://github.com/Textualize/textual.git synced 2025-10-17 02:38:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

Rename the switch--switch component class to switch--slider

Browse Source 
Following on from #1751: originally Switch was called Checkbox and the
moving part was, for the component class, called a checkbox--switch; after
renaming the widget to Switch that component class ended up being
switch--switch; which wasn't ideal.

We decided to go with it as-is, but I just realised that internally the code
calls it a slider. So this leans into that and I'm renaming the component
class switch--slider. This removes the doubling-up of the name and also
makes the code more consistent.
This commit is contained in:
Dave Pearson
2023-02-09 15:36:04 +00:00
parent 989e71e749
commit 1956f7f9d7
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/examples/widgets/switch.css
View File

@@ -22,7 +22,7 @@ Switch {
background: darkslategrey; background: darkslategrey;
} }
#custom-design > .switch--switch { #custom-design > .switch--slider {
color: dodgerblue; color: dodgerblue;
background: darkslateblue; background: darkslateblue;
} }

10
src/textual/widgets/_switch.py
View File

@@ -31,12 +31,12 @@ class Switch(Widget, can_focus=True):
""" """
COMPONENT_CLASSES: ClassVar[set[str]] = { COMPONENT_CLASSES: ClassVar[set[str]] = {
"switch--switch", "switch--slider",
} }
""" """
| Class | Description | | Class | Description |
| :- | :- | | :- | :- |
| `switch--switch` | Targets the switch of the switch. | | `switch--slider` | Targets the slider of the switch. |
""" """
DEFAULT_CSS = """ DEFAULT_CSS = """
@@ -48,7 +48,7 @@ class Switch(Widget, can_focus=True):
padding: 0 2; padding: 0 2;
} }
Switch > .switch--switch { Switch > .switch--slider {
background: $panel-darken-2; background: $panel-darken-2;
color: $panel-lighten-2; color: $panel-lighten-2;
} }
@@ -65,7 +65,7 @@ class Switch(Widget, can_focus=True):
} }
Switch.-on > .switch--switch { Switch.-on > .switch--slider {
color: $success; color: $success;
} }
""" """
@@ -128,7 +128,7 @@ class Switch(Widget, can_focus=True):
self.set_class(slider_pos == 1, "-on") self.set_class(slider_pos == 1, "-on")
def render(self) -> RenderableType: def render(self) -> RenderableType:
style = self.get_component_rich_style("switch--switch") style = self.get_component_rich_style("switch--slider")
return ScrollBarRender( return ScrollBarRender(
virtual_size=100, virtual_size=100,
window_size=50, window_size=50,