alihan/textual
1
0
Fork 0
mirror of https://github.com/Textualize/textual.git synced 2025-10-17 02:38:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

Only convert to an indexable sequence if absolutely necessary

Browse Source
This commit is contained in:
Dave Pearson
2023-01-06 06:01:59 +00:00
committed by Rodrigo Girão Serrão
parent 948cb6676f
commit 274bb634ca
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/textual/_collections.py
View File

@@ -1,7 +1,7 @@
"""Provides collection-based utility code."""
from __future__ import annotations
from typing import Generic, TypeVar, Iterator, overload, Iterable
from typing import Generic, TypeVar, Iterator, overload, Iterable, Sequence
T = TypeVar("T")
@@ -15,7 +15,7 @@ class ImmutableSequence(Generic[T]):
Args:
wrap (Iterable[T]): The iterable value being wrapped.
"""
self._wrap = tuple(wrap)
self._wrap = wrap if isinstance(wrap, Sequence) else tuple(wrap)
@overload
def __getitem__(self, index: int) -> T:

5
tests/test_collections.py
View File

@@ -57,10 +57,11 @@ def test_get_item_from_immutable_sequence() -> None:
assert wrap(range(10))[0] == 0
assert wrap(range(10))[-1] == 9
def test_get_slice_from_immutable_sequence() -> None:
"""It should be possible to get a slice from an immutable sequence."""
assert list(wrap(range(10))[0:2]) == [0,1]
assert list(wrap(range(10))[0:-1]) == [0,1,2,3,4,5,6,7,8]
assert list(wrap(iter(range(10)))[0:2]) == [0,1]
assert list(wrap(iter(range(10)))[0:-1]) == [0,1,2,3,4,5,6,7,8]
def test_immutable_sequence_contains() -> None: