alihan/textual
1
0
Fork 0
mirror of https://github.com/Textualize/textual.git synced 2025-10-17 02:38:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

Ensure access to options is actually access to selections

Browse Source
This commit is contained in:
Dave Pearson
2023-05-22 14:18:20 +01:00
parent 07515e22c8
commit 51d1dade5c
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/textual/widgets/_selection_list.py
View File

@@ -125,10 +125,9 @@ class SelectionList(Generic[SelectionType], OptionList):
super().__init__() super().__init__()
self.selection_list: SelectionList = selection_list self.selection_list: SelectionList = selection_list
"""The option list that sent the message.""" """The option list that sent the message."""
self.selection: Selection[MessageSelectionType] = cast( self.selection: Selection[
Selection[MessageSelectionType], MessageSelectionType
selection_list.get_option_at_index(index), ] = selection_list.get_option_at_index(index)
)
"""The highlighted selection.""" """The highlighted selection."""
self.selection_index: int = index self.selection_index: int = index
"""The index of the selection that the message relates to.""" """The index of the selection that the message relates to."""
@@ -301,9 +300,7 @@ class SelectionList(Generic[SelectionType], OptionList):
If nothing is selected in the list this is a non-operation. If nothing is selected in the list this is a non-operation.
""" """
if self.highlighted is not None: if self.highlighted is not None:
option = self.get_option_at_index(self.highlighted) self.toggle(self.get_option_at_index(self.highlighted))
assert isinstance(option, Selection)
self.toggle(option)
def render_line(self, y: int) -> Strip: def render_line(self, y: int) -> Strip:
"""Render a line in the display. """Render a line in the display.
@@ -329,7 +326,6 @@ class SelectionList(Generic[SelectionType], OptionList):
_, scroll_y = self.scroll_offset _, scroll_y = self.scroll_offset
selection_index = scroll_y + y selection_index = scroll_y + y
selection = self.get_option_at_index(selection_index) selection = self.get_option_at_index(selection_index)
assert isinstance(selection, Selection)
# Figure out which component style is relevant for a checkbox on # Figure out which component style is relevant for a checkbox on
# this particular line. # this particular line.
@@ -390,3 +386,9 @@ class SelectionList(Generic[SelectionType], OptionList):
event.stop() event.stop()
self._toggle_highlighted_selection() self._toggle_highlighted_selection()
self.post_message(self.SelectionToggled(self, event.option_index)) self.post_message(self.SelectionToggled(self, event.option_index))
def get_option_at_index(self, index: int) -> Selection[SelectionType]:
return cast("Selection[SelectionType]", super().get_option_at_index(index))
def get_option(self, option_id: str) -> Selection[SelectionType]:
return cast("Selection[SelectionType]", super().get_option(option_id))