alihan/textual
1
0
Fork 0
mirror of https://github.com/Textualize/textual.git synced 2025-10-17 02:38:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1195 from davep/button-variant-check

Browse Source 
Check button variant for validity during button construction
This commit is contained in:
Will McGugan
2022-11-16 16:58:09 +00:00
committed by GitHub
parent e32e094b92 e3899c0c10
commit 572d9b6968
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@@ -31,6 +31,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Watchers are now called immediately when setting the attribute if they are synchronous. https://github.com/Textualize/textual/pull/1145 - Watchers are now called immediately when setting the attribute if they are synchronous. https://github.com/Textualize/textual/pull/1145
- Widget.call_later has been renamed to Widget.call_after_refresh. - Widget.call_later has been renamed to Widget.call_after_refresh.
- Button variant values are now checked at runtime. https://github.com/Textualize/textual/issues/1189
### Fixed ### Fixed

2
src/textual/widgets/_button.py
View File

@@ -186,7 +186,7 @@ class Button(Static, can_focus=True):
if disabled: if disabled:
self.add_class("-disabled") self.add_class("-disabled")
self.variant = variant self.variant = self.validate_variant(variant)
label: Reactive[RenderableType] = Reactive("") label: Reactive[RenderableType] = Reactive("")
variant = Reactive.init("default") variant = Reactive.init("default")