alihan/textual
1
0
Fork 0
mirror of https://github.com/Textualize/textual.git synced 2025-10-17 02:38:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

Ensure reflow reflows non-visible widgets, fix scroll_to_center issue (#2684)

Browse Source
This commit is contained in:
darrenburns
2023-05-29 18:23:49 +01:00
committed by GitHub
parent 6cb052a7f2
commit a40300a6f5
5 changed files with 81 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

119
tests/snapshot_tests/__snapshots__/test_snapshots.ambr
View File

File diff suppressed because one or more lines are too long

31
tests/snapshot_tests/snapshot_apps/scroll_to_center.py
View File

@@ -5,32 +5,33 @@ from textual.widgets import Label
class MyApp(App[None]):
CSS = """
VerticalScroll, HorizontalScroll {
VerticalScroll {
border: round $primary;
}
#vertical {
height: 21;
}
HorizontalScroll {
border: round $secondary;
height: auto;
}
Label {
height: auto;
width: auto;
}
"""
def compose(self) -> ComposeResult:
with VerticalScroll():
yield Label(("SPAM\n" * 205)[:-1])
with VerticalScroll():
yield Label(("SPAM\n" * 53)[:-1])
with VerticalScroll(id="vertical"):
yield Label(("SPAM\n" * 78)[:-1])
with HorizontalScroll():
yield Label(("v\n" * 17)[:-1])
yield Label("@" * 302)
yield Label("[red]>>bullseye<<[/red]", id="bullseye")
yield Label("@" * 99)
yield Label(("SPAM\n" * 49)[:-1])
yield Label(("SPAM\n" * 51)[:-1])
yield Label(("SPAM\n" * 59)[:-1])
yield Label(("SPAM\n" * 53)[:-1])
with VerticalScroll(id="vertical"):
yield Label(("SPAM\n" * 78)[:-1])
with HorizontalScroll():
yield Label(("v\n" * 17)[:-1])
yield Label("@" * 302)
yield Label("[red]>>bullseye<<[/red]", id="bullseye")
yield Label("@" * 99)
yield Label(("SPAM\n" * 49)[:-1])
yield Label(("SPAM\n" * 51)[:-1])
def key_s(self) -> None:
self.screen.scroll_to_center(self.query_one("#bullseye"))

3
tests/snapshot_tests/test_snapshots.py
View File

@@ -518,9 +518,6 @@ def test_scroll_visible(snap_compare):
assert snap_compare(SNAPSHOT_APPS_DIR / "scroll_visible.py", press=["t"])
@pytest.mark.xfail(
reason="Unpredictable while https://github.com/Textualize/textual/issues/2254 is open."
)
def test_scroll_to_center(snap_compare):
# READ THIS IF THIS TEST FAILS:
# While https://github.com/Textualize/textual/issues/2254 is open, the snapshot