From eef9c8157d56a667cb44e9a2712570431faab4fe Mon Sep 17 00:00:00 2001 From: Dave Pearson Date: Wed, 12 Oct 2022 14:36:19 +0100 Subject: [PATCH 1/2] Provide extra hinting for App.query This change seeks to help silence some warnings that were appearing with pylance/pyright when type checking was in strict mode. See #867. --- src/textual/dom.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/textual/dom.py b/src/textual/dom.py index 8bb706d1c..a3a474515 100644 --- a/src/textual/dom.py +++ b/src/textual/dom.py @@ -684,14 +684,14 @@ class DOMNode(MessagePump): ExpectType = TypeVar("ExpectType", bound="Widget") @overload - def query(self, selector: str | None) -> DOMQuery: + def query(self, selector: str | None) -> DOMQuery[Widget]: ... @overload def query(self, selector: type[ExpectType]) -> DOMQuery[ExpectType]: ... - def query(self, selector: str | type | None = None) -> DOMQuery: + def query(self, selector: str | type[ExpectType] | None = None) -> DOMQuery[Widget] | DOMQuery[ExpectType]: """Get a DOM query matching a selector. Args: From ea0c9bb464d3b78a48478a8557859364c704f6e1 Mon Sep 17 00:00:00 2001 From: Dave Pearson Date: Wed, 12 Oct 2022 14:40:49 +0100 Subject: [PATCH 2/2] Reformat to black standard --- src/textual/dom.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/textual/dom.py b/src/textual/dom.py index a3a474515..798b04d45 100644 --- a/src/textual/dom.py +++ b/src/textual/dom.py @@ -691,7 +691,9 @@ class DOMNode(MessagePump): def query(self, selector: type[ExpectType]) -> DOMQuery[ExpectType]: ... - def query(self, selector: str | type[ExpectType] | None = None) -> DOMQuery[Widget] | DOMQuery[ExpectType]: + def query( + self, selector: str | type[ExpectType] | None = None + ) -> DOMQuery[Widget] | DOMQuery[ExpectType]: """Get a DOM query matching a selector. Args: