From c2e327cee38073fa3a5fa2cc270ada733b4ae52b Mon Sep 17 00:00:00 2001 From: Will McGugan Date: Fri, 18 Feb 2022 22:30:06 +0000 Subject: [PATCH] simplify check, add test --- src/textual/_layout_resolve.py | 2 +- tests/test_layout_resolve.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/textual/_layout_resolve.py b/src/textual/_layout_resolve.py index c0d72a16b..af45b2032 100644 --- a/src/textual/_layout_resolve.py +++ b/src/textual/_layout_resolve.py @@ -56,7 +56,7 @@ def layout_resolve(total: int, edges: Sequence[Edge]) -> list[int]: ] _Fraction = Fraction - while None in sizes: + while flexible_edges: # Calculate number of characters in a ratio portion portion = _Fraction( remaining, sum((edge.fraction or 1) for _, edge in flexible_edges) diff --git a/tests/test_layout_resolve.py b/tests/test_layout_resolve.py index 29c2926aa..03a503ca2 100644 --- a/tests/test_layout_resolve.py +++ b/tests/test_layout_resolve.py @@ -60,6 +60,7 @@ def test_two(): [Edge(None, 4), Edge(None, 1), Edge(None, 1), Edge(None, 1)], [5, 2, 1, 2], ), + (2, [Edge(None, 1), Edge(None, 1), Edge(None, 1)], [1, 1, 1]), ], ) def test_multiple(size, edges, result):