alihan/textual
1
0
Fork 0
mirror of https://github.com/Textualize/textual.git synced 2025-10-17 02:38:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

Change ScrollView to inherit from ScrollableContainer rather than Widget

Browse Source 
See #2332
This commit is contained in:
Dave Pearson
2023-04-20 09:40:58 +01:00
parent ee45356c5c
commit fe5f80bdd6
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Changed ### Changed
- Breaking change: standard keyboard scrollable navigation bindings have been moved off `Widget` and onto a new base class for scrollable containers (see also below addition) https://github.com/Textualize/textual/issues/2332 - Breaking change: standard keyboard scrollable navigation bindings have been moved off `Widget` and onto a new base class for scrollable containers (see also below addition) https://github.com/Textualize/textual/issues/2332
- `ScrollView` now inherits from `Scrollablecontainer` rather than `Widget` https://github.com/Textualize/textual/issues/2332
### Added ### Added

4
src/textual/scroll_view.py
View File

@@ -7,11 +7,11 @@ from __future__ import annotations
from rich.console import RenderableType from rich.console import RenderableType
from .containers import ScrollableContainer
from .geometry import Size from .geometry import Size
from .widget import Widget
class ScrollView(Widget): class ScrollView(ScrollableContainer):
""" """
A base class for a Widget that handles it's own scrolling (i.e. doesn't rely A base class for a Widget that handles it's own scrolling (i.e. doesn't rely
on the compositor to render children). on the compositor to render children).