Commit Graph

4471 Commits

Author SHA1 Message Date
Dave Pearson
330950e6b0 Seek to improve the explanation of what a percentage does
I've seen a couple or so folk get confused about what a percentage value for
a dimension means, often seeming to think it means that percentage of
the *remaining* space within a container as opposed to a percentage of the
space in the container (note total space, not remaining space).

I'm not sure the wording here is the final form we want (there's more
mention of "dimension" here than your average Star Trek or Doctor Who
episode!), but I think it's narrowing in on it.

Making this change to place-hold the need to improve this and perhaps gather
some input to find the best final wording.
2023-01-17 16:33:30 +00:00
Will McGugan
fc2073386c Merge pull request #1591 from davep/compose-error-expand
Reraise compose TypeError from the error rather than None
2023-01-17 07:45:30 -08:00
Will McGugan
507413d473 updated text 2023-01-17 15:39:59 +00:00
Will McGugan
3104ae0d9d Merge branch 'key-minus' 2023-01-17 15:38:40 +00:00
Will McGugan
f13b7f7fe5 Merge pull request #1596 from Textualize/key-minus
Key minus
2023-01-17 07:36:12 -08:00
Will McGugan
1bfc19f480 help message 2023-01-17 15:24:31 +00:00
Rodrigo Girão Serrão
88a1fe013c Tweak docstrings. 2023-01-17 15:20:04 +00:00
Will McGugan
e32344615a Added test 2023-01-17 15:19:40 +00:00
Will McGugan
2bd1372c38 added minus key 2023-01-17 15:18:31 +00:00
darrenburns
da1d56202f Merge branch 'main' into datatable-events 2023-01-17 15:12:53 +00:00
Darren Burns
d37e9717d9 Update the CHANGELOG regarding DataTable improvements and fixes 2023-01-17 15:12:08 +00:00
Darren Burns
5a60726bdd A couple of missing DataTable docstrings 2023-01-17 15:05:29 +00:00
Rodrigo Girão Serrão
1ebbf3c7fa Docstrings and remove dead code. 2023-01-17 15:05:25 +00:00
Rodrigo Girão Serrão
4221febf44 Update changelog. 2023-01-17 15:04:15 +00:00
Darren Burns
c98a9249ee Ensure correct events raised on cursor_type change 2023-01-17 15:03:09 +00:00
Rodrigo Girão Serrão
d2726d18f1 Add selector to focus next and previous. 2023-01-17 15:02:29 +00:00
Rodrigo Girão Serrão
4963f62893 Use focusable widgets in tests. 2023-01-17 15:02:09 +00:00
Rodrigo Girão Serrão
ed1f7331d8 Add focus tests. 2023-01-17 14:56:45 +00:00
Rodrigo Girão Serrão
12f272d507 Fix tests.
I misread the original app hierarchy and was trying to focus something that can't be focused.
2023-01-17 14:56:35 +00:00
Darren Burns
e1de10d21a Pause after input test 2023-01-17 14:26:16 +00:00
Dave Pearson
984fa41de5 Fix typo/thinko in CHANGELOG 2023-01-17 14:25:44 +00:00
Will McGugan
c2a6e2f8b5 Merge pull request #1581 from Textualize/fix-textlog-wrap
Fixes for textlog issues
2023-01-17 06:23:11 -08:00
Darren Burns
8a04f13ad1 Mention the handler names for DataTable events in docs 2023-01-17 14:22:46 +00:00
Dave Pearson
16f21ecfc8 Reraise compose TypeError from the error rather than None
In its current form, if someone's `compose` results in an uncaught TypeError
in their own code, the resulting error will hide the source. This small
change ensures that the main problem (compose returned something that can't
be turned into a list) is still reported, but also provides the developer a
trackback they can look at to see what the ultimate source of the issue was.
2023-01-17 14:22:32 +00:00
Will McGugan
2956f1f4d8 update change log [skip ci] 2023-01-17 14:22:25 +00:00
Darren Burns
36bf162847 Snapshot tests for column and row cursors in DataTable 2023-01-17 14:17:25 +00:00
Darren Burns
925c02ad15 Small docs updates 2023-01-17 13:46:24 +00:00
Darren Burns
be45db4573 Use autodoc for DataTable Messages reference 2023-01-17 13:00:01 +00:00
Rodrigo Girão Serrão
56f339db20 Add failing tests. 2023-01-17 12:26:03 +00:00
Darren Burns
23eb13d12d Some DataTable doc updates, rename Coord -> Coordinate and extract to module 2023-01-17 11:06:21 +00:00
Rodrigo Girão Serrão
4078634d57 Merge pull request #1586 from Textualize/rodrigogiraoserrao-patch-1
Docstring correction
2023-01-17 11:01:18 +00:00
Rodrigo Girão Serrão
518c721ecf Docstring correction 2023-01-17 10:44:49 +00:00
Rodrigo Girão Serrão
b6c9eab332 Merge branch 'fix-1420' of github.com:Textualize/textual into fix-1420 2023-01-17 10:32:58 +00:00
Rodrigo Girão Serrão
2b9cd81ca5 Cleanup and new test. 2023-01-17 10:29:19 +00:00
Darren Burns
f327f1d2af Small datatable docs rewording 2023-01-17 10:11:19 +00:00
Will McGugan
e6d89dd839 docstring 2023-01-17 10:10:16 +00:00
Darren Burns
9bc93cd683 Small datatable docs rewording 2023-01-17 10:06:39 +00:00
Will McGugan
a521640dac Fixes for textlog issues 2023-01-17 09:55:56 +00:00
Darren Burns
b4f2da025a Add pause after datatable snapshot test 2023-01-16 16:40:01 +00:00
Darren Burns
d2fd9ec9bc Extracting some common cell/row/col highlighting logic in DataTable 2023-01-16 16:38:21 +00:00
Dave Pearson
cc5338ea5a Merge pull request #1578 from davep/prop-chop-doc
Add some extra docstrings to widgets
2023-01-16 16:34:26 +00:00
Darren Burns
5f797aae29 Emitting ColumnSelected in DataTable 2023-01-16 16:20:07 +00:00
Darren Burns
7ef36001fd Update docstrings in DataTable 2023-01-16 16:11:52 +00:00
Will McGugan
fb1bd6ad48 Merge pull request #1550 from davep/issue/1201/scroll-to-with-code
Allow by-code scrolling even when by-input scrolling would be denied
2023-01-16 07:47:58 -08:00
Dave Pearson
632e82818d Merge pull request #1570 from davep/title-docs
Add docstrings to app title an sub-titles
2023-01-16 15:45:13 +00:00
Dave Pearson
6c64773996 Merge branch 'main' into issue/1201/scroll-to-with-code 2023-01-16 15:42:39 +00:00
Dave Pearson
2b2d6c730c Correct over-eager remove of if constructs
That's how I'm reading 1b9f51a272 (r1070555064)
2023-01-16 15:41:20 +00:00
Dave Pearson
00291e7c99 Make some of Input's docstrings more property-like 2023-01-16 15:32:49 +00:00
Dave Pearson
d5ffc4e0ac Add a docstring to the __init__of Input 2023-01-16 15:32:28 +00:00
Darren Burns
f0ac05f1c6 Small changes to DataTable events 2023-01-16 15:26:27 +00:00