Will McGugan
5b4f05592d
Merge pull request #1157 from davep/awaitable-remove
...
Awaitable remove
2022-11-11 18:06:41 +00:00
Dave Pearson
90c14815a0
Add missing close quote to height Python example
2022-11-11 17:59:33 +00:00
Dave Pearson
bc851d5466
Correct the description of the default screenshot action location
2022-11-11 17:21:32 +00:00
Will McGugan
e83a3a79bd
Added walk to docs
2022-11-11 10:05:12 +00:00
Will McGugan
b2d9f4703d
keep pylance happy
2022-11-11 09:55:56 +00:00
Will McGugan
41263c32df
restore type alias
2022-11-11 09:41:14 +00:00
Will McGugan
44e44da784
docstrings
2022-11-11 09:38:17 +00:00
Will McGugan
d93e300d95
walk.py
2022-11-11 09:33:31 +00:00
Will McGugan
698ecc62c6
factored out walk
2022-11-11 09:29:45 +00:00
Dave Pearson
d83c4aacbe
Make a property docstring more property-a-like
2022-11-10 21:43:14 +00:00
Dave Pearson
2a80e1761d
Add some missing return types
2022-11-10 21:38:58 +00:00
Dave Pearson
c18852a737
Add missing property type
2022-11-10 21:36:05 +00:00
Dave Pearson
0dae1761ad
Tidy up the docstring for the checkbox
...
Google style docstring guidelines say that __init__ args can go either in
the class docstring, or the __init__ docstring; so this class was correct.
But the guidelines also recommend that once one approach has been picked it
should be the same over the whole body of the code. Textual mostly seems to
do it in the __init__ so I'm moving things to here and also adding some
missing args.
2022-11-10 21:33:24 +00:00
Dave Pearson
bd21e248b1
Fix the default value of a checkbox
...
The value is bool, but the default is None. This makes the default False.
2022-11-10 21:32:00 +00:00
Dave Pearson
3dae5f2c93
Add missing types to arguments
2022-11-10 21:28:21 +00:00
Dave Pearson
7864aa3f8e
Add missing types to arguments
2022-11-10 21:27:52 +00:00
Dave Pearson
5d2a2fd340
Add missing types to arguments
2022-11-10 21:27:12 +00:00
Dave Pearson
60b5456229
Add types to all Button.__init__ args
2022-11-10 21:25:14 +00:00
Dave Pearson
4418cbab78
Merge branch 'main' into awaitable-remove
2022-11-10 20:43:25 +00:00
Dave Pearson
32e6f71856
Be 100% sure all removals take place
2022-11-10 20:41:11 +00:00
Dave Pearson
d3e7f5ad99
Add a unit test for removal ordering via DOMQuery.remove
2022-11-10 20:36:57 +00:00
Dave Pearson
9748850657
Add a unit test for removal ordering via Widget.remove
2022-11-10 20:34:51 +00:00
Dave Pearson
d378eb4291
Update the CHANGELOG
2022-11-10 20:07:57 +00:00
Dave Pearson
7147df462b
Flesh out the Widget.remove docs
2022-11-10 19:59:18 +00:00
Dave Pearson
1fb2cacbe4
Widgets, not widget
2022-11-10 19:58:40 +00:00
Dave Pearson
de275d7011
Flesh out the Prune event docs
2022-11-10 19:57:08 +00:00
Dave Pearson
736237be58
Flesh out the docstring for DOMQuery.remove
2022-11-10 19:49:59 +00:00
Dave Pearson
1f36ebac97
Add some documentation to AwaitRemove
2022-11-10 19:47:13 +00:00
Dave Pearson
4dbb1f8e20
AwaitRemove work-in-progress
...
Initial work on #1094 -- this implements the core idea; lots of tidying up
to do but saving for the end of the week.
2022-11-10 16:54:44 +00:00
Will McGugan
3f761319f0
Merge pull request #1139 from overflowy/minimal-refactoring
...
Minimal refactoring
2022-11-10 16:33:33 +00:00
Will McGugan
d45780b90d
Merge pull request #1154 from Textualize/table-update
...
Table update
2022-11-10 16:32:10 +00:00
Will McGugan
1b61a95c70
table tests
2022-11-10 16:22:52 +00:00
Will McGugan
300bd86d45
Changelog
2022-11-10 16:03:26 +00:00
Will McGugan
b524fa08ee
ffixed table refresh on add row
2022-11-10 16:02:30 +00:00
Will McGugan
beddf27b0d
Merge pull request #1149 from Textualize/call-later
...
call later
2022-11-10 15:30:05 +00:00
Will McGugan
97eab5fd6e
Merge branch 'main' into call-later
2022-11-10 15:24:31 +00:00
Will McGugan
ed779f3e99
no need for full refresh
2022-11-10 15:22:25 +00:00
Dave Pearson
bb60d4c827
Merge pull request #1153 from davep/remove-event-tests
...
Add unit tests for App._on_remove
2022-11-10 14:02:44 +00:00
Dave Pearson
d73d4e898f
Add unit tests for App._on_remove
...
These tests are designed to give 100% coverage to the App._on_remove method,
which is the heart of the widget removal system. This is done in
anticipation to some reworking as part of #1094 .
Note that, for the moment, there's a bit of a hack in here. These tests need
the pilot. The pilot would need that we await changes to the DOM. Removing
things from the DOM changes the DOM. Remove can't be awaited (see above
change that's coming). So... until such a time as we can await a remove, we
go with a simple await of asyncio.sleep to get things started.
Once #1094 has been done these tests should all still work fine *and* we
should be able to await the removes rather than use the sleeps.
2022-11-10 13:13:15 +00:00
Will McGugan
fb0f9ab805
Merge pull request #1152 from davep/prop-docs
...
Property docstring tweaks
2022-11-10 11:45:41 +00:00
Dave Pearson
e5ef8c0495
Merge pull request #1147 from davep/remove-refresh
...
Improve the speed of `DOMQuery.remove`
2022-11-10 11:13:30 +00:00
Dave Pearson
ed1aeab071
Tidy up and add some app docstrings
2022-11-10 11:10:04 +00:00
Dave Pearson
f9e5541d01
Tidy some docstrings
...
Moving some property docstrings to a voice that describes what they are, not
what they do.
2022-11-10 11:09:17 +00:00
Dave Pearson
efe721fb51
Reduce the amount of work needed to build the pruned remove list
2022-11-10 11:03:28 +00:00
Dave Pearson
a888e52c30
Reduce the work needed to get the topmost widget prune set
...
See https://github.com/Textualize/textual/pull/1147#pullrequestreview-1175289913
2022-11-10 09:03:19 +00:00
Dave Pearson
922fd8ad6a
Merge pull request #1137 from davep/squish-type-error
...
Remove a type-checking error for the result of _find_mount_point
2022-11-09 21:22:28 +00:00
Dave Pearson
3cb00f93d5
Simplify the building of the pruned remove list
...
See https://github.com/Textualize/textual/pull/1147#discussion_r1018230164
2022-11-09 21:17:55 +00:00
Dave Pearson
419ae15435
Remove unnecessary caution
2022-11-09 21:00:49 +00:00
Dave Pearson
414f0a66bd
Fix a comment typo
2022-11-09 20:58:42 +00:00
Will McGugan
9538e60a01
remove print debug
2022-11-09 17:40:14 +00:00
