Commit Graph

657 Commits

Author SHA1 Message Date
Will McGugan
689ec477ea Update tests/test_keys.py
Co-authored-by: darrenburns <darrenburns@users.noreply.github.com>
2022-12-21 15:19:46 +00:00
Will McGugan
77eadc9fa1 words 2022-12-21 15:17:27 +00:00
Will McGugan
46cfbddad2 check for empty bindings 2022-12-21 14:57:25 +00:00
Will McGugan
0a1fc1e7de Merge branch 'main' into key-refactor 2022-12-21 14:07:18 +00:00
Will McGugan
a4aa30ebeb Merge pull request #1416 from Textualize/query-star-exclude-self
Queries/`walk_children` no longer includes self in results by default
2022-12-21 14:04:49 +00:00
Will McGugan
55c58e0f8f added tests 2022-12-21 11:39:36 +00:00
Will McGugan
7a46672d64 docs and expanded keys 2022-12-21 11:38:20 +00:00
Darren Burns
d06fca1041 Improving universal selector test 2022-12-21 11:28:19 +00:00
Dave Pearson
159f94a9b4 Reformat to keep black happy 2022-12-21 11:23:01 +00:00
Dave Pearson
adecdde3a7 Add dark/light mode toggling tests 2022-12-21 11:21:27 +00:00
Darren Burns
8c864030e2 Merge branch 'main' of github.com:Textualize/textual into query-star-exclude-self 2022-12-21 10:52:59 +00:00
Darren Burns
78f06c9d1b Add test for universal selector 2022-12-20 20:19:53 +00:00
Will McGugan
1cef349f27 test fix 2022-12-20 14:06:35 +00:00
Will McGugan
301d56e329 snapshot fix 2022-12-20 13:22:22 +00:00
Will McGugan
3e2c3fbb2f Merge branch 'main' into cli-keys 2022-12-20 13:20:01 +00:00
Will McGugan
0987229c25 fix binding inheritance issues 2022-12-20 13:19:49 +00:00
darrenburns
af8af1bee9 Ensure watcher isn't called on first_set when init is False and value doesn't change (#1367)
* Ensure watcher not called when value doesnt change, even on first set

* Update CHANGELOG.md
2022-12-20 11:17:11 +00:00
Will McGugan
93716e714b Merge branch 'main' into nested-height-fix 2022-12-20 11:14:45 +00:00
Will McGugan
16994c54d1 Update tests/test_binding_inheritance.py
Co-authored-by: darrenburns <darrenburns@users.noreply.github.com>
2022-12-20 10:42:21 +00:00
Will McGugan
b265b855cd insert pause 2022-12-19 13:39:03 +00:00
Will McGugan
bb7fd40d73 force console on terminal summary 2022-12-19 13:26:47 +00:00
Will McGugan
43ed1d5927 fix snapshot 2022-12-19 13:00:42 +00:00
Will McGugan
32b7308ac8 fox for nested heights 2022-12-19 12:54:06 +00:00
Will McGugan
002cbab0d5 add pause to action 2022-12-19 11:26:42 +00:00
Will McGugan
621e96dcdd pause 2022-12-19 11:20:46 +00:00
Will McGugan
053b7f38e1 snapshot tweak 2022-12-19 10:27:29 +00:00
Will McGugan
ee59c5882e Added SkipAction exception 2022-12-19 10:01:06 +00:00
Will McGugan
af049d4a4d added test 2022-12-19 09:30:22 +00:00
Will McGugan
d11e3f2e15 Merge pull request #1346 from davep/bug/1342/inherited-movement-keys
Add support for a `PRIORITY_BINDINGS` classvar to work alongside `BINDINGS`
2022-12-16 20:13:31 +00:00
darrenburns
14a4ad48cd Merge branch 'main' into validator-first-set 2022-12-15 14:50:46 +00:00
Dave Pearson
f25f6cbbb5 Fix a typo 2022-12-15 14:45:34 +00:00
Dave Pearson
431053182c Merge branch 'main' into bug/1342/inherited-movement-keys 2022-12-15 14:28:03 +00:00
Dave Pearson
75c9fba393 Use is to test tri-state, rather than equality
See https://github.com/Textualize/textual/pull/1346#discussion_r1049675405
2022-12-15 14:26:10 +00:00
Dave Pearson
d389c9185a s/mk_/make_/g
mk_bgr
2022-12-15 14:14:25 +00:00
Dave Pearson
f08b4eda6d Swap final test to a screen type rather than instance
See https://github.com/Textualize/textual/pull/1346#discussion_r1049678092
2022-12-15 14:12:52 +00:00
Dave Pearson
7397cff52a Revert previous attempt at an experiment 2022-12-15 14:12:00 +00:00
Dave Pearson
549fd6b47e Experiment with recording at all levels
More attempts to figure out why I'm getting the async issue with messages
and the pilot.
2022-12-15 14:04:03 +00:00
Dave Pearson
b196d8cd2e Revert experimental backing out of recent changes
Didn't make a difference. CI on GitHub is still acting differently.
2022-12-15 13:29:27 +00:00
Dave Pearson
76a22d81d4 Eliminating changes
This is the one biggish change between the last working test run in GitHub,
and now. Tests are still running locally fine, an on GitHub, in the last
run, I had one job pass and another fail, both on the same OS, just 3.10
passed and 3.9 failed. The problem still to do with (as far as I can tell)
messages inside Textual and some sort of async issue.

So let's try this.
2022-12-15 13:25:05 +00:00
Dave Pearson
938cd3bd1d Namespace the recording actions
Wondering if this is the issue with why the tests have stopped working in
GitHub; but also not *really* confused as to why they were working in the
first place.
2022-12-15 13:17:16 +00:00
Dave Pearson
2f77bab409 Extra long pause test
This code is running just finally locally in tests, but is failing with:

RuntimeError: Task <Task pending name='Task-279' coro=<MessagePump._process_messages() running at /home/runner/work/textual/textual/src/textual/message_pump.py:314>> got Future <Future pending> attached to a different loop

in GitHub Actions. Pretty sure I saw this before, which made me add the
pause in the first place. Given this seems to just be affecting the last
test, from what I can tell, let's make the pause longer to see if that
helps.

I hate chasing action issues...
2022-12-15 12:57:14 +00:00
Dave Pearson
ad7c2e6c4d Round off the priority clash test and un-xfail it
Also add in a test for when there is no priority anywhere. This is still a
priority level that needs testing, it just isn't a priority.
2022-12-15 12:47:46 +00:00
Dave Pearson
618db503b9 Add tests for competing bindings an priority permutations
This is set to xfail at the moment because the tested result is what I think
should be the result, but what happens now isn't that. Need to check with
Will to see what he thinks the correct resolution is here.
2022-12-15 12:16:27 +00:00
Dave Pearson
50df082479 Keep black happy 2022-12-15 12:16:16 +00:00
Dave Pearson
8ff9af581c Test rationale comment update 2022-12-15 09:10:00 +00:00
Dave Pearson
4a78283574 Update the binding inheritance tests to reflect the emerging changes
I feel some more will be needed, but this is all of the basics, hitting all
of the important points that relate to #1343. More importantly all of the
xfails are now removed.
2022-12-14 20:59:57 +00:00
Dave Pearson
dcad134acd Add a (currently) breaking test for spaces within a key list
At the moment at least, we don't allow binding on " ", we bind on "space".
Meanwhile, tidy folk may try and bind in "a, b, c, d" as opposed to trying
to bind on "a,b,c,d". I feel we should allow for that.

This test, which breaks at the moment, should be satisfied.
2022-12-14 17:29:47 +00:00
Darren Burns
e01c33c06a Snapshot updates 2022-12-14 14:21:41 +00:00
Darren Burns
1acc36084b Add non-printable key to footer snapshot 2022-12-14 14:07:26 +00:00
Darren Burns
2b8b7c15e6 Add extra test for validator called before dom ready, update changelog 2022-12-14 12:09:00 +00:00