Commit Graph

10 Commits

Author SHA1 Message Date
Rodrigo Girão Serrão
2a810f8c87 Implement border (sub)title. (#2064)
* Add Widget.border_title and border_subtitle.

Related issues: #1864

* Test setting border_(sub)title.

* Add border (sub)title references to StylesCache.

These internal references will make it easier for the instance of 'StylesCache' to know which border (sub)title to use, if/when needed.

* Add method to render border label.

* Add styles to align border (sub)title.

* Render border labels.

* Update styles template.

* Make new 'render_row' parameters optional.

* Add (sub)title border snapshot tests.

* Document border (sub)title and styles.

* Pass (sub)title directly as arguments.

Get rid of the watchers to make data flow easier to follow.
Related comment: https://github.com/Textualize/textual/pull/2064/files\#r1137746697

* Tweak example.

* Fix render_border_label.

This was wrong because border labels can be composed of multiple segments if they contain multiple styles. Additionally, we want to render a single blank space of padding around the title.

* Ensure we get no label when there's no space.

* Add tests for border label rendering.

* 'render_border_label' now returns iterable of segments.

* Add label to render_row.

* Fix calling signature in tests.

* Add padding to snapshot tests.

* Fix changelog.

* Update snapshot tests.

* Update snapshot tests.

* Border labels expand if there's no corners.

* Update CHANGELOG.md

* Fix docs.

* Remove irrelevant line.

* Fix snapshot tests.

* Don't share Console among tests.

* Simplify example in styles guide.

* Avoid expensive function call when possible.

* rewording

* positive branch first

* remove wasteful indirection

* fix changelog

---------

Co-authored-by: Will McGugan <willmcgugan@gmail.com>
2023-03-22 11:07:38 +00:00
Will McGugan
59def1a591 test fix 2023-02-04 16:10:33 +01:00
Will McGugan
de2a4fd78d test fixes 2023-02-04 15:53:00 +01:00
Will McGugan
51c7fef2e1 extend trips to line API 2022-12-29 10:13:37 +00:00
Will McGugan
6f82ad9c4a adds Strip primitive 2022-12-26 18:06:35 +00:00
Darren Burns
1b0c94e8a0 Remove draw.py, fix imports 2022-10-13 11:15:15 +01:00
Will McGugan
d514193ea9 test fixes 2022-07-09 17:21:27 +01:00
Will McGugan
415db09a4b docstrings 2022-07-04 20:53:53 +01:00
Will McGugan
2ac95c5922 render lines and scrollbars 2022-07-04 20:37:59 +01:00
Will McGugan
f3a7c9483f apply style to widget 2022-07-04 14:48:28 +01:00