alihan/textual
1
0
Fork 0
mirror of https://github.com/Textualize/textual.git synced 2025-10-17 02:38:12 +03:00
Code Issues Packages Projects Releases Wiki Activity
6,310 Commits 87 Branches 190 Tags
c16b32b52f4539a90dba04fb6b189b0959ffb3b5
Commit Graph

1217 Commits

Author SHA1 Message Date
Dave Pearson
c16b32b52f Merge pull request #2656 from davep/private-validate-and-compute 
Add (currently xfailing) tests for private reactive validation and compute methods
 2023-05-25 15:53:24 +01:00
Dave Pearson
fa47d0bd41 Mark the public/private validate and compute tests as xfails 2023-05-25 15:27:27 +01:00
Dave Pearson
bd6717f3d5 Add a test for public and private computes 
This fails for now.
 2023-05-25 15:23:33 +01:00
Will McGugan
3ab315beb6 Anim screenshot fix (#2655) 
* fix screenshots in docs

* fix anim

* added wait for animation switch

* remove comment
 2023-05-25 13:46:14 +01:00
darrenburns
62fcefbd2d Validation (#2600) 
* A few different types of validation

* Rename

* Fix test

* Updating validation framework

* Update lockfile

* Ensure validators can be None

* Reworking the API a little

* Convert Input.Changed to dataclass

* Add utility for getting failures as strings

* Update an example in Validator docstring

* Remove some redundant `pass`es

* Renaming variables

* Validating Input on submit, attaching result to Submitted event

* Testing various validation features

* Update snapshots and deps

* Styling unfocused -invalid Input differently

* Add snapshot test around input validation and associated styles

* Validation docs

* Tidying validation docs in Input widget reference

* Fix mypy issues

* Remove __bool__ from Failure, make validator field required

* Code review changes

* Improving error messages in Validators
 2023-05-25 13:29:33 +01:00
Rodrigo Girão Serrão
5cb30b5ecc Merge pull request #2628 from Textualize/auto-focus-improv 
Add auto focus to app.
 2023-05-25 11:59:54 +01:00
Dave Pearson
abda34aa13 Add a test for private validation 
Currently failing.
 2023-05-25 11:48:04 +01:00
Will McGugan
8151946f38 add blur (#2645) 
* add blur

* docstring

* blur on disabled

* snapshot test

* Add test
 2023-05-24 20:16:11 +01:00
Rodrigo Girão Serrão
bc92cf57e7 Add auto focus to app. 
Related issues: #2594.
 2023-05-23 11:32:40 +01:00
Rodrigo Girão Serrão
724fedc442 Merge pull request #2621 from Textualize/leave-footer-push-modal-screen 
Leave footer when pushing modal screen
 2023-05-22 14:43:05 +01:00
Rodrigo Girão Serrão
d48a127ffe Merge pull request #2540 from Textualize/screen-modes 
Implements screen modes
 2023-05-22 14:27:35 +01:00
Rodrigo Girão Serrão
c32d5d3c25 Add regression test for #2606. 2023-05-22 13:53:58 +01:00
Rodrigo Girão Serrão
6523fbaff1 Fix tests. 2023-05-18 16:27:09 +01:00
Rodrigo Girão Serrão
ad986b127d Merge branch 'main' into screen-modes 2023-05-18 15:11:21 +01:00
Rodrigo Girão Serrão
38f9500642 Fix test. 2023-05-17 11:35:10 +01:00
Rodrigo Girão Serrão
a058fe53eb Make test clearer. 2023-05-17 11:15:56 +01:00
Rodrigo Girão Serrão
dea133d357 Merge branch 'main' into auto-focus-improv 2023-05-17 10:28:54 +01:00
Rodrigo Girão Serrão
45686c8aca Fix tests. 2023-05-17 10:27:57 +01:00
Will McGugan
53e765f7d6 Avoid docks when scrolling (#2571) 
* handle docked layers

* handle scroll better

* snapshot update

* remove commented out code

* superflous

* dock gutter

* snapshit

* snapshit test

* changelog

* mistake

* docstrings

* changelog

* whitespace

* missing punctuation

* ofx docstring

* Apply suggestions from code review

Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>

---------

Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
 2023-05-16 21:34:59 +01:00
Rodrigo Girão Serrão
634789ae93 Add tests to screen modes. 2023-05-16 17:40:09 +01:00
Dave Pearson
83e4be77db Merge pull request #2567 from davep/issue/2557/select-update 
Fix clearing an OptionList
 2023-05-16 15:11:29 +01:00
Dave Pearson
1ebfe2f418 Update the snapshits 2023-05-16 14:38:11 +01:00
Dave Pearson
3d2e3d9092 Add a snapshot test for a rebuilt Select 
This helps test the practical impact of the fix added for #2557.
 2023-05-16 14:34:18 +01:00
Rodrigo Girão Serrão
4b22234b24 Merge branch 'main' into auto-focus-improv 2023-05-16 11:40:13 +01:00
Rodrigo Girão Serrão
a6ee867ee3 Fix tests. 2023-05-16 11:39:38 +01:00
Rodrigo Girão Serrão
b592ac077a AUTO_FOCUS targets first focusable widget. 
Related issues: #2578.
 2023-05-16 11:27:24 +01:00
Rodrigo Girão Serrão
7a8d6920e8 Error when dismissing non-active screen. 
Related issues: #2575.
 2023-05-16 11:14:54 +01:00
Rodrigo Girão Serrão
fe7812d94d Add regression test for #2563. 2023-05-15 13:24:48 +01:00
Rodrigo Girão Serrão
0b6e3b3040 Merge branch 'main' into auto-focus 2023-05-15 10:41:15 +01:00
Rodrigo Girão Serrão
c967661699 Merge branch 'main' into move-child-no-op 2023-05-15 10:31:43 +01:00
Will McGugan
d266e3685f snapshot update (#2555) 2023-05-12 18:57:53 +02:00
Will McGugan
c2e7b619f1 Revert "virtual size and docks" 
This reverts commit 9a134b4920.
 2023-05-12 15:53:47 +02:00
Will McGugan
9a134b4920 virtual size and docks 2023-05-12 15:36:49 +02:00
Dave Pearson
2d75ca0d77 Merge pull request #2536 from davep/expand-tree-expand-messages 
Ensure that `TreeNode` messages are posted when via-API changes are made
 2023-05-10 14:18:24 +01:00
Rodrigo Girão Serrão
8dd627b0f4 Merge branch 'main' into sub-title-str 2023-05-10 13:10:48 +01:00
Dave Pearson
28be54d10d Merge branch 'main' into expand-tree-expand-messages 2023-05-10 10:12:58 +01:00
Dave Pearson
f19f46bba0 Merge pull request #2519 from davep/cygnus-x-1 
Fix for `resolve_fraction_unit` zero division error (#2502)
 2023-05-10 10:10:55 +01:00
Dave Pearson
c7fc66fa6c Ensure that TreeNode messages are posted when via-API changes are made 
Until now the Tree.NodeExpanded and Tree.NodeCollapsed messages were only
sent out when changes were made to the tree by user interaction. This meant
that if any changes were made with the TreeNode expand, expand_all,
collapse, collapse_all, toggle or toggle_all API calls no messages would be
sent.

This PR corrects this.

The work here is, in part, required for #2456 (DirectoryTree lazy-loads
directory information on node expansion so if someone is expanding nodes
under code control the DirectoryTree never gets to know that it should load
a directory's content) and will build on #1644, essentially adding a missing
aspect to the latter PR.
 2023-05-10 09:24:07 +01:00
Rodrigo Girão Serrão
e8baf52bdd Allow setting (sub)title of any type. 
Related issues: #2521.
 2023-05-09 16:56:56 +01:00
Rodrigo Girão Serrão
3245eb38bb Make auto-focus a class var. 
Related comments: https://github.com/Textualize/textual/pull/2527\#discussion_r1188776849
 2023-05-09 16:44:37 +01:00
Rodrigo Girão Serrão
eafe6b1786 Moving child before/after self is a no-op. 
Related issues: #1743.
 2023-05-09 15:57:23 +01:00
Dave Pearson
8855471125 Merge pull request #2522 from davep/move-widget-enhanced-testing 
Make the widget moving tests more granular and add more tests
 2023-05-09 15:07:59 +01:00
Rodrigo Girão Serrão
ed4d811451 Add tests for Screen auto focus. 
Related issues: #2457.
 2023-05-09 14:55:18 +01:00
Dave Pearson
a0558e87d8 Merge branch 'main' into cygnus-x-1 2023-05-09 13:38:16 +01:00
Dave Pearson
ee70713002 Simplify the resolver zero division bug unit test 2023-05-09 13:35:55 +01:00
Dave Pearson
d3de6d1587 Make the widget moving tests more granular and add more tests 
Adds two (currently xfail) tests to illustrate #1743
 2023-05-09 11:19:00 +01:00
Dave Pearson
a77dbf4bee Tentative fix for resolve_fraction_unit ZeroDivision error 
I'll admit to not really following what the code does, so will really need
someone with a better understanding of the aim of this code to look over the
proposed fix; but based on a bunch of runs and hand-debugging, this seems to
do the job.

This passes all existing tests and also removes the reported error.

On the other hand I'm not confident that I'm *not* just masking an
underlying issue with this function.
 2023-05-09 10:38:09 +01:00
Dave Pearson
a5cc96cbc7 Make a pass of the #2502 test a fail 
If/when I get this actually passing, I want the test to appear to fail so I
know things have changed for the better.

This makes sense, trust me.
 2023-05-09 09:44:51 +01:00
Dave Pearson
052ec83b7a Make the test as small as possible 2023-05-09 09:44:30 +01:00
Dave Pearson
089dce1b41 Add a unit test for #2502 
Currently marked as xfail, but this gets it down to the most basic level.
 2023-05-09 09:39:12 +01:00