Commit Graph

4802 Commits

Author SHA1 Message Date
Darren Burns
87808c63b2 Tidying some tests 2023-02-02 15:29:26 +00:00
Darren Burns
134ceffd11 Testing to ensure column size calculated correctly 2023-02-02 14:20:33 +00:00
Dave Pearson
9f9ccf32d6 Merge pull request #1715 from davep/package-tests
Include the unit tests in the source distribution
2023-02-02 14:15:57 +00:00
Darren Burns
7748b69e95 Initial unit tests around column width updates 2023-02-02 14:12:14 +00:00
Dave Pearson
244372205e Include the unit tests in the source distribution
As requested in #631 and also #1349; this change should cause the tests (and
also the examples from the docs directory which get pulled into the tests)
to be pulled into the sdist.

With this change I can:

- `poetry build`
- Grab and extract the resulting tarball
- `poetry install --extras dev` inside the resulting directory
- `poetry run pytest -vv tests` inside the resulting directory

As I understand the request, I think this should provide everything
necessary.

NOTE: We have spoken about rolling the CLI tools into snapshot tests too, so
if that happens we should remember to make sure that the pipeline outlined
above still works fine.
2023-02-02 13:51:45 +00:00
Darren Burns
990a6311bc Extract common coordinate validation logic into method in DataTable 2023-02-02 13:09:11 +00:00
Darren Burns
77b94b005c Testing case where you try to update cells which dont exist 2023-02-01 17:34:03 +00:00
Will McGugan
d3fdcbe250 Merge pull request #1712 from Textualize/titles
Update to title and subtitle copy
2023-02-01 18:16:45 +01:00
Darren Burns
23a34030cd Measuring string cells correctly 2023-02-01 17:10:59 +00:00
Will McGugan
8ce76f4f89 fix title update 2023-02-01 18:01:34 +01:00
Will McGugan
087654a246 Update docs/guide/app.md
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
2023-02-01 17:49:33 +01:00
Will McGugan
340f7c53bc Update docs/guide/app.md
Co-authored-by: Rodrigo Girão Serrão <5621605+rodrigogiraoserrao@users.noreply.github.com>
2023-02-01 17:49:05 +01:00
Will McGugan
8fc978503b Merge pull request #1711 from davep/textual-keys-older-pythons
Make `textual keys` work on older supported Pythons
2023-02-01 17:44:44 +01:00
Will McGugan
259c1cc14e tip to info 2023-02-01 17:43:29 +01:00
Will McGugan
c04e387dfe title copy 2023-02-01 17:38:19 +01:00
Dave Pearson
91630d6e04 Make textual keys work on older supported Pythons 2023-02-01 16:37:53 +00:00
Will McGugan
806c80b8fe simplify 2023-02-01 17:14:53 +01:00
Darren Burns
fd4e13c988 Add tests for DataTable.get_cell_value 2023-02-01 15:43:36 +00:00
Dave Pearson
79952719ae Merge pull request #1709 from davep/tree-complete-clear
Add `Tree.reset`, which clears a `Tree` and then then resets the `Tree.root`'s `label` and `data` to given values
2023-02-01 15:30:28 +00:00
Will McGugan
0a5838d964 checker example 2023-02-01 16:26:55 +01:00
Darren Burns
43c2696ccf Small rename in DataTable utility types 2023-02-01 15:25:13 +00:00
Will McGugan
9e5814ed0f Strip improvements and line api 2023-02-01 16:22:14 +01:00
Rodrigo Girão Serrão
faa2ee68d7 Merge pull request #1706 from Textualize/document-sub-title
Document setting (sub) title in the app guide
2023-02-01 15:08:43 +00:00
Dave Pearson
d350374e59 Revert Tree.clear and add Tree.reset
After some internal discussion we've decided to keep `Tree.clear` as it was,
and add a `Tree.reset`, which does a `Tree.clear` but resets the label and
data of `Tree.root` to the values given, while mirroring how `Tree.__init__`
takes those parameters.
2023-02-01 15:08:03 +00:00
Darren Burns
c84ae53395 Fix docstring indentation to fix mkdocs rendering 2023-02-01 15:07:38 +00:00
Darren Burns
79b08aa6b5 Merge branch 'main' of github.com:Textualize/textual into datatable-cell-keys 2023-02-01 14:55:14 +00:00
Darren Burns
3f463cb0ef Store strings as strings 2023-02-01 14:54:33 +00:00
Rodrigo Girão Serrão
2140aa52d2 Update docs/guide/app.md 2023-02-01 14:53:20 +00:00
Darren Burns
a7383e6a83 Import and export datatable utilities from public module 2023-02-01 14:51:05 +00:00
Darren Burns
67d79e16da Simplify _get_offsets to return header row key 2023-02-01 14:10:01 +00:00
Darren Burns
53685ee2b5 Docstring update in DataTable 2023-02-01 13:59:44 +00:00
Darren Burns
c9629b1755 Ensure keys are included in emitted events from DataTable 2023-02-01 13:53:48 +00:00
Dave Pearson
8b4a833e26 Update the CHANGELOG 2023-02-01 13:47:48 +00:00
Dave Pearson
78f49f0ab2 Allow replacement of the root node data when clearing the tree 2023-02-01 13:44:53 +00:00
Dave Pearson
ff7f2488f8 Remove Tree class name clash with how pytest works
Just before doing the commit I decided to rename the test tree in the new
unit test for clearing down a tree. Of course I managed to name it in such a
way that it becomes special to pytest.

This fixes that.
2023-02-01 12:45:18 +00:00
Dave Pearson
7563d4cb7e Allow setting a new label when performing a clear on a Tree
See #1437 for background. While it would be ideal to allow for the complete
emptying of a Tree, the root node is required (and it's part of the
construction of a Tree). So, here, when clearing the Tree we optionally
allow for a new label to be given.

Ideally we'll also allow for fresh data to be provided too; but there's a
wrinkle there in knowing the difference between the data being None, and no
data being provided (so the current root's data being carried over).
Following the method of defaulting used in __init__ would cause problems. As
such, rather than roll all of this into one commit, this goes with the basic
requirement and the solution for data will follow.

Note this also starts some unit tests for the clearing of a Tree.
2023-02-01 12:33:36 +00:00
Will McGugan
8ddd52962b Merge pull request #1708 from davidbrochart/docs
Fix typo
2023-02-01 12:40:17 +01:00
Darren Burns
bf42ac94f7 Ensure row_key is included in RowHighlighted event 2023-02-01 11:34:39 +00:00
Rodrigo Girão Serrão
476eca7a6e Shuffle sections around. 2023-02-01 11:30:56 +00:00
David Brochart
d1790caff7 Fix typo 2023-02-01 12:25:00 +01:00
Darren Burns
cc3d744168 Add row_key to RowHighlighted event in DataTable 2023-02-01 11:15:31 +00:00
Darren Burns
07e964d2ba More docstrings for the DataTable, new private property refactor for total_row_height 2023-02-01 11:14:08 +00:00
Rodrigo Girão Serrão
521e90488c Add context about (sub)title. 2023-02-01 11:08:13 +00:00
Darren Burns
655b2b3ea7 Docstring updates 2023-02-01 10:57:03 +00:00
Rodrigo Girão Serrão
828d8d2cf1 Replace Static with Label. 2023-01-31 17:31:36 +00:00
Rodrigo Girão Serrão
c14f635244 Document setting app (sub)title. 2023-01-31 17:31:06 +00:00
Darren Burns
0b2b7a9646 Docstring improvements 2023-01-31 16:43:33 +00:00
Dave Pearson
6f24331564 Merge pull request #1703 from davep/lowkey-tree-selection
Lowkey tree selection
2023-01-31 16:27:15 +00:00
Dave Pearson
b0a29050cf Update snapshots after change of unfocused tree cursor handling 2023-01-31 16:20:41 +00:00
Dave Pearson
f2e756b695 Update the CHANGELOG 2023-01-31 15:54:27 +00:00