mirror of
https://github.com/Textualize/textual.git
synced 2025-10-17 02:38:12 +03:00
a107218064
If the mouse is hovering over the last option in an OptionList, and an option is removed, the application will crash with an IndexError. The problem was that the record of the hovered option needed to be cleared when an option is removed (as it is during other changes). Fixes #3270
113 lines
4.3 KiB
Python
113 lines
4.3 KiB
Python
"""Test removing options from an option list."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from textual.app import App, ComposeResult
|
|
from textual.geometry import Offset
|
|
from textual.widgets import OptionList
|
|
from textual.widgets.option_list import Option, OptionDoesNotExist
|
|
|
|
|
|
class OptionListApp(App[None]):
|
|
"""Test option list application."""
|
|
|
|
def compose(self) -> ComposeResult:
|
|
yield OptionList(
|
|
Option("0", id="0"),
|
|
Option("1", id="1"),
|
|
)
|
|
|
|
|
|
async def test_remove_first_option_via_index() -> None:
|
|
"""It should be possible to remove the first option of an option list, via index."""
|
|
async with OptionListApp().run_test() as pilot:
|
|
option_list = pilot.app.query_one(OptionList)
|
|
assert option_list.option_count == 2
|
|
assert option_list.highlighted == 0
|
|
option_list.remove_option_at_index(0)
|
|
assert option_list.option_count == 1
|
|
assert option_list.highlighted == 0
|
|
|
|
|
|
async def test_remove_first_option_via_id() -> None:
|
|
"""It should be possible to remove the first option of an option list, via ID."""
|
|
async with OptionListApp().run_test() as pilot:
|
|
option_list = pilot.app.query_one(OptionList)
|
|
assert option_list.option_count == 2
|
|
assert option_list.highlighted == 0
|
|
option_list.remove_option("0")
|
|
assert option_list.option_count == 1
|
|
assert option_list.highlighted == 0
|
|
|
|
|
|
async def test_remove_last_option_via_index() -> None:
|
|
"""It should be possible to remove the last option of an option list, via index."""
|
|
async with OptionListApp().run_test() as pilot:
|
|
option_list = pilot.app.query_one(OptionList)
|
|
assert option_list.option_count == 2
|
|
assert option_list.highlighted == 0
|
|
option_list.remove_option_at_index(1)
|
|
assert option_list.option_count == 1
|
|
assert option_list.highlighted == 0
|
|
|
|
|
|
async def test_remove_last_option_via_id() -> None:
|
|
"""It should be possible to remove the last option of an option list, via ID."""
|
|
async with OptionListApp().run_test() as pilot:
|
|
option_list = pilot.app.query_one(OptionList)
|
|
assert option_list.option_count == 2
|
|
assert option_list.highlighted == 0
|
|
option_list.remove_option("1")
|
|
assert option_list.option_count == 1
|
|
assert option_list.highlighted == 0
|
|
|
|
|
|
async def test_remove_all_options_via_index() -> None:
|
|
"""It should be possible to remove all options via index."""
|
|
async with OptionListApp().run_test() as pilot:
|
|
option_list = pilot.app.query_one(OptionList)
|
|
assert option_list.option_count == 2
|
|
assert option_list.highlighted == 0
|
|
option_list.remove_option_at_index(0)
|
|
option_list.remove_option_at_index(0)
|
|
assert option_list.option_count == 0
|
|
assert option_list.highlighted is None
|
|
|
|
|
|
async def test_remove_all_options_via_id() -> None:
|
|
"""It should be possible to remove all options via ID."""
|
|
async with OptionListApp().run_test() as pilot:
|
|
option_list = pilot.app.query_one(OptionList)
|
|
assert option_list.option_count == 2
|
|
assert option_list.highlighted == 0
|
|
option_list.remove_option("0")
|
|
option_list.remove_option("1")
|
|
assert option_list.option_count == 0
|
|
assert option_list.highlighted is None
|
|
|
|
|
|
async def test_remove_invalid_id() -> None:
|
|
"""Attempting to remove an option ID that doesn't exist should raise an exception."""
|
|
async with OptionListApp().run_test() as pilot:
|
|
with pytest.raises(OptionDoesNotExist):
|
|
pilot.app.query_one(OptionList).remove_option("does-not-exist")
|
|
|
|
|
|
async def test_remove_invalid_index() -> None:
|
|
"""Attempting to remove an option index that doesn't exist should raise an exception."""
|
|
async with OptionListApp().run_test() as pilot:
|
|
with pytest.raises(OptionDoesNotExist):
|
|
pilot.app.query_one(OptionList).remove_option_at_index(23)
|
|
|
|
|
|
async def test_remove_with_hover_on_last_option():
|
|
"""https://github.com/Textualize/textual/issues/3270"""
|
|
async with OptionListApp().run_test() as pilot:
|
|
await pilot.hover(OptionList, Offset(1, 1) + Offset(2, 1))
|
|
option_list = pilot.app.query_one(OptionList)
|
|
assert option_list._mouse_hovering_over == 1
|
|
option_list.remove_option_at_index(0)
|
|
assert option_list._mouse_hovering_over == None
|