alihan/crush-code-agent-ide
1
0
Fork 0
mirror of https://github.com/charmbracelet/crush.git synced 2025-08-02 05:20:46 +03:00
Code Issues Packages Projects Releases Wiki Activity

perf: avoid regex compilation in runtime

Browse Source
This commit is contained in:
Raphael Amorim
2025-07-30 11:22:10 +02:00
parent 229c0c79b4
commit 760e5c4f12
4 changed files with 23 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal/llm/provider/anthropic.go
View File

@@ -21,6 +21,11 @@ import (
"github.com/charmbracelet/crush/internal/message"
)
var (
// Pre-compiled regex for parsing context limit errors.
contextLimitRegex = regexp.MustCompile(`input length and ` + "`max_tokens`" + ` exceed context limit: (\d+) \+ (\d+) > (\d+)`)
)
type anthropicClient struct {
providerOptions providerClientOptions
useBedrock bool
@@ -512,8 +517,7 @@ func (a *anthropicClient) handleContextLimitError(apiErr *anthropic.Error) (int,
// Parse error message like: "input length and max_tokens exceed context limit: 154978 + 50000 > 200000"
errorMsg := apiErr.Error()
re := regexp.MustCompile("input length and `max_tokens` exceed context limit: (\\d+) \\+ (\\d+) > (\\d+)")
matches := re.FindStringSubmatch(errorMsg)
matches := contextLimitRegex.FindStringSubmatch(errorMsg)
if len(matches) != 4 {
return 0, false

3
internal/llm/tools/view.go
View File

@@ -306,7 +306,8 @@ func readTextFile(filePath string, offset, limit int) (string, int, error) {
}
}
var lines []string
// Pre-allocate slice with expected capacity
lines := make([]string, 0, limit)
lineCount = offset
for scanner.Scan() && len(lines) < limit {

11
internal/tui/exp/list/filterable.go
View File

@@ -15,6 +15,13 @@ import (
"github.com/sahilm/fuzzy"
)
var (
// Pre-compiled regex for checking if a string contains alphabetic characters.
alphaRegex = regexp.MustCompile(`[a-zA-Z]`)
// Pre-compiled regex for checking if a string is alphanumeric.
alphanumericRegex = regexp.MustCompile(`^[a-zA-Z0-9]*$`)
)
type FilterableItem interface {
Item
FilterValue() string
@@ -165,8 +172,6 @@ func (f *filterableList[T]) View() string {
// removes bindings that are used for search
func (f *filterableList[T]) updateKeyMaps() {
alphanumeric := regexp.MustCompile("^[a-zA-Z0-9]*$")
removeLettersAndNumbers := func(bindings []string) []string {
var keep []string
for _, b := range bindings {
@@ -177,7 +182,7 @@ func (f *filterableList[T]) updateKeyMaps() {
if b == " " {
continue
}
m := alphanumeric.MatchString(b)
m := alphanumericRegex.MatchString(b)
if !m {
keep = append(keep, b)
}

10
internal/tui/exp/list/filterable_group.go
View File

@@ -15,6 +15,12 @@ import (
"github.com/sahilm/fuzzy"
)
var (
// Pre-compiled regex for checking if a string is alphanumeric.
// Note: This is duplicated from filterable.go to avoid circular dependencies.
alphanumericRegexGroup = regexp.MustCompile(`^[a-zA-Z0-9]*$`)
)
type FilterableGroupList[T FilterableItem] interface {
GroupedList[T]
Cursor() *tea.Cursor
@@ -114,8 +120,6 @@ func (f *filterableGroupList[T]) View() string {
// removes bindings that are used for search
func (f *filterableGroupList[T]) updateKeyMaps() {
alphanumeric := regexp.MustCompile("^[a-zA-Z0-9]*$")
removeLettersAndNumbers := func(bindings []string) []string {
var keep []string
for _, b := range bindings {
@@ -126,7 +130,7 @@ func (f *filterableGroupList[T]) updateKeyMaps() {
if b == " " {
continue
}
m := alphanumeric.MatchString(b)
m := alphanumericRegexGroup.MatchString(b)
if !m {
keep = append(keep, b)
}