alihan/fastapi-openapi-to-postman
1
0
Fork 0
mirror of https://github.com/postmanlabs/openapi-to-postman.git synced 2022-11-29 22:05:00 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fixed issue where large request name caused validation issues

Browse Source
This commit is contained in:
Vishal Shingala
2021-11-25 12:26:46 +05:30
parent d9a085aadf
commit 0f9055a6b0
3 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/schemaUtils.js
View File

@@ -3397,6 +3397,9 @@ module.exports = {
return callback(null, []);
}
// only validate string upto 255 character as longer name results in issues while updation
typeof expectedReqName === 'string' && (actualReqName = actualReqName.substring(0, 255));
// handling path templating in request url if any
// convert all {anything} to {{anything}}
reqUrl = this.fixPathVariablesInUrl(pathRoute.slice(pathRoute.indexOf('/')));
@@ -3414,6 +3417,7 @@ module.exports = {
case 'fallback' : {
// operationId is usually camelcase or snake case
expectedReqName = schemaPath.summary || utils.insertSpacesInName(schemaPath.operationId) || reqUrl;
typeof expectedReqName === 'string' && (expectedReqName = expectedReqName.substring(0, 255));
reqNameMismatch = (actualReqName !== expectedReqName);
break;
}
@@ -3426,6 +3430,7 @@ module.exports = {
}
default : {
expectedReqName = schemaPath[options.requestNameSource];
typeof expectedReqName === 'string' && (expectedReqName = expectedReqName.substring(0, 255));
reqNameMismatch = (actualReqName !== expectedReqName);
break;
}
@@ -3848,7 +3853,7 @@ module.exports = {
contentHeaderMismatches;
// resolve $ref in request body if present
if (reqBody.$ref) {
if (_.has(reqBody, '$ref')) {
reqBody = this.getRefObject(reqBody.$ref, components, options);
}

2
test/data/validationData/validateMetadataCollection.json
View File

@@ -73,7 +73,7 @@
},
{
"id": "de9fd791-43d2-4251-8e00-8349ee2e2c79",
"name": "Create a pet",
"name": "Create a pet large request name Create a pet large request name Create a pet large request name Create a pet large request name Create a pet large request name Create a pet large request name Create a pet large request name Create a pet large request name",
"request": {
"description": {
"content": null,

4
test/data/validationData/validateMetadataSpec.yaml
View File

@@ -26,7 +26,9 @@ paths:
default:
description: unexpected error
post:
summary: Create a pet
summary: Create a pet large request name Create a pet large request name Create a pet large request name Create a pet large
request name Create a pet large request name Create a pet large request name Create a pet large request name Create a pet
large request name Create a pet large request name Create a pet large request name Create a pet large request name
description: Description for POST /pets - Create a pet
operationId: createPets
tags: