Fixed issue where exmples which had non-truthy value were not present in converted collection

This commit is contained in:
Vishal Shingala
2021-03-15 11:47:25 +05:30
parent 3cc21857a2
commit bd3dd588d4
3 changed files with 35 additions and 1 deletions

View File

@@ -399,7 +399,7 @@ module.exports = {
else if (examples) {
let exampleToUse = _.get(examples, '[0].value');
exampleToUse && (_.set(parameter, 'schema.example', exampleToUse));
!_.isUndefined(exampleToUse) && (_.set(parameter, 'schema.example', exampleToUse));
}
},

View File

@@ -7,6 +7,26 @@
"paths": {
"/pet": {
"post": {
"parameters": [
{
"in": "query",
"name": "limit",
"schema": {
"type": "integer",
"example": 25
},
"examples": {
"zero": {
"value": 0,
"summary": "A sample limit value # Optional description"
},
"max": {
"value": 50,
"summary": "A sample limit value"
}
}
}
],
"requestBody": {
"content": {
"application/json": {

View File

@@ -409,6 +409,20 @@ describe('CONVERT FUNCTION TESTS ', function() {
done();
});
});
it('[Github #338] Should contain non-truthy example from examples outside of schema instead of faked value' +
examplesOutsideSchema, function(done) {
Converter.convert({ type: 'file', data: examplesOutsideSchema },
{ schemaFaker: true, requestParametersResolution: 'example', exampleParametersResolution: 'example' },
(err, conversionResult) => {
let rootRequest = conversionResult.output[0].data.item[0].request;
expect(err).to.be.null;
expect(rootRequest.url.query[0].key).to.eql('limit');
expect(rootRequest.url.query[0].value).to.eql('0');
done();
});
});
});
it('[Github #117]- Should add the description in body params in case of urlencoded' +
descriptionInBodyParams, function(done) {