alihan/fn-serverless
1
0
Fork 0
mirror of https://github.com/fnproject/fn.git synced 2022-10-28 21:29:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

fn: handle client connection close errors (#1196)

Browse Source
This commit is contained in:
Tolga Ceylan
2018-09-05 16:56:31 -07:00
committed by GitHub
parent 246c353f9a
commit 35d04cae6d
2 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
api/models/error.go
View File

@@ -18,6 +18,11 @@ var (
code: http.StatusBadRequest,
error: errors.New("Invalid JSON"),
}
ErrClientCancel = err{
// The special custom error code to close connection without any response
code: 444,
error: errors.New("Client cancelled context"),
}
ErrCallTimeout = err{
code: http.StatusGatewayTimeout,
error: errors.New("Timed out"),

13
api/server/error_response.go
View File

@@ -28,12 +28,15 @@ func simpleError(err error) *models.Error {
// TODO delete me !
func handleV1ErrorResponse(ctx *gin.Context, err error) {
log := common.Logger(ctx)
if ctx.Request.Context().Err() == context.Canceled {
log.Info("request canceled")
w := ctx.Writer
if ctx.Err() == context.Canceled {
log.Info("client context cancelled")
w.WriteHeader(models.ErrClientCancel.Code())
return
}
w := ctx.Writer
var statuscode int
if e, ok := err.(models.APIError); ok {
if e.Code() >= 500 {
@@ -71,8 +74,10 @@ func writeV1Error(ctx context.Context, w http.ResponseWriter, statuscode int, er
// HandleErrorResponse used to handle response errors in the same way.
func HandleErrorResponse(ctx context.Context, w http.ResponseWriter, err error) {
log := common.Logger(ctx)
if ctx.Err() == context.Canceled {
log.Info("request canceled")
log.Info("client context cancelled")
w.WriteHeader(models.ErrClientCancel.Code())
return
}