alihan/fn-serverless
1
0
Fork 0
mirror of https://github.com/fnproject/fn.git synced 2022-10-28 21:29:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

Change not present v2 call endpoint respone to Gone (#1206)

Browse Source 
Currently, when the calls endpoints are disabled a 501 is
returned. While this is technically correct, it's not hard to see this
causing trouble when people tend to create 5xx roll up alerting
metrics.

This changes it to a 410, Gone, response, which is close enough and
should allow clients to know what's going on.
This commit is contained in:
Tom Coupland
2018-09-12 16:27:34 +01:00
committed by GitHub
parent aceb1021be
commit 3c95d80dce
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
api/server/server.go
View File

@@ -1048,8 +1048,8 @@ func (s *Server) startGears(ctx context.Context, cancel context.CancelFunc) {
}
}
func (s *Server) notImplementedResponse(c *gin.Context) {
c.Status(http.StatusNotImplemented)
func (s *Server) goneResponse(c *gin.Context) {
c.Status(http.StatusGone)
}
func (s *Server) bindHandlers(ctx context.Context) {
@@ -1132,8 +1132,8 @@ func (s *Server) bindHandlers(ctx context.Context) {
v2.GET("/fns/:fnID/calls", s.handleCallList)
v2.GET("/fns/:fnID/calls/:callID", s.handleCallGet)
} else {
v2.GET("/fns/:fnID/calls", s.notImplementedResponse)
v2.GET("/fns/:fnID/calls/:callID", s.notImplementedResponse)
v2.GET("/fns/:fnID/calls", s.goneResponse)
v2.GET("/fns/:fnID/calls/:callID", s.goneResponse)
}
if !s.noHybridAPI { // Hybrid API - this should only be enabled on API servers