alihan/fn-serverless
1
0
Fork 0
mirror of https://github.com/fnproject/fn.git synced 2022-10-28 21:29:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

Remove error returns.

Browse Source
This commit is contained in:
Travis Reeder
2017-10-26 11:12:08 +02:00
parent d30bcb0397
commit 965630af15
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
api/agent/call.go
View File

@@ -350,12 +350,12 @@ func (c *call) End(ctx context.Context, errIn error, t callTrigger) error {
// TODO: this should be update, really // TODO: this should be update, really
if err := c.ds.InsertCall(ctx, c.Call); err != nil { if err := c.ds.InsertCall(ctx, c.Call); err != nil {
common.Logger(ctx).WithError(err).Error("error inserting call into datastore") common.Logger(ctx).WithError(err).Error("error inserting call into datastore")
return err // note: Not returning err here since the job could have already finished successfully.
} }
if err := c.ds.InsertLog(ctx, c.AppName, c.ID, c.stderr); err != nil { if err := c.ds.InsertLog(ctx, c.AppName, c.ID, c.stderr); err != nil {
common.Logger(ctx).WithError(err).Error("error uploading log") common.Logger(ctx).WithError(err).Error("error uploading log")
return err // note: Not returning err here since the job could have already finished successfully.
} }
// NOTE call this after InsertLog or the buffer will get reset // NOTE call this after InsertLog or the buffer will get reset