alihan/fn-serverless
1
0
Fork 0
mirror of https://github.com/fnproject/fn.git synced 2022-10-28 21:29:17 +03:00
Code Issues Packages Projects Releases Wiki Activity
Files
f0f9a6d945978766dbff621ff37057cda45f4172
fn-serverless/vendor/git.apache.org/thrift.git/doc/committers.md
Reed Allman 9eaf824398 add jaeger support, link hot container & req span (#840) 
* add jaeger support, link hot container & req span

* adds jaeger support now with FN_JAEGER_URL, there's a simple tutorial in the
operating/metrics.md file now and it's pretty easy to get up and running.
* links a hot request span to a hot container span. when we change this to
sample at a lower ratio we'll need to finagle the hot container span to always
sample or something, otherwise we'll hide that info. at least, since we're
sampling at 100% for now if this is flipped on, can see freeze/unfreeze etc.
if they hit. this is useful for debugging. note that zipkin's exporter does
not follow the link at all, hence jaeger... and they're backed by the Cloud
Empire now (CNCF) so we'll probably use it anyway.

* vendor: add thrift for jaeger
2018-03-13 15:57:12 -07:00

1.6 KiB
Raw Blame History

Process used by committers to review and submit patches

  1. Make sure that there is an issue for the patch(s) you are about to commit in our Jira issue tracker

  2. Check out the latest version of the source code

  1. Apply the patch

or

  1. Inspect the applied patch to ensure that all Legal aspects on Submission of Contributions (Patches) are met

  2. Run the necessary unit tests and cross language test cases to verify the patch

  3. Commit the patch

     git --config user.name "Your Name"
 git --config user.email "YourApacheID@apache.org"
 git add -A
 git commit

  4. The commit message should be in the format:

    THRIFT-###:<Jira description>
Client: <component>
Patch: <Name of person contributing the patch>

Description of what was fixed or addressed.

<%
    if this is a github pull request then add below comment
     to automaticaly close GitHub request.
%>
This closes #XX

  5. Double check the patch committed and that nothing was missed then push the patch

    git status
git show HEAD
git push origin master

  6. Resolve the jira issue and set the following for the changelog

  • Component the patch is for
  • fixVersion to the current version on master