alihan/growthbook
1
0
Fork 0
mirror of https://github.com/growthbook/growthbook.git synced 2021-08-07 14:23:53 +03:00
Code Issues Projects Releases Wiki Activity

Fix BigQuery date parsing bug

Browse Source
This commit is contained in:
Jeremy Dorn
2021-08-05 16:59:31 -05:00
parent 75e99f8f31
commit a7efc68c2c
2 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/back-end/src/integrations/BigQuery.ts
View File

@@ -49,7 +49,9 @@ export default class BigQuery extends SqlIntegration {
percentile * 100
)})]`;
}
convertDate(fromDB: bq.BigQueryDatetime) {
return new Date(fromDB.value + "Z");
}
dateTrunc(col: string) {
return `date_trunc(${col}, DAY)`;
}

12
packages/back-end/src/integrations/SqlIntegration.ts
View File

@@ -216,6 +216,10 @@ export default abstract class SqlIntegration
dateDiff(startCol: string, endCol: string) {
return `datediff(day, ${startCol}, ${endCol})`;
}
// eslint-disable-next-line
convertDate(fromDB: any): Date {
return new Date(fromDB);
}
getPastExperimentQuery(from: Date) {
return format(
@@ -294,8 +298,8 @@ export default abstract class SqlIntegration
experiments: rows.map((r) => {
return {
users: parseInt(r.users),
end_date: new Date(r.end_date),
start_date: new Date(r.start_date),
end_date: this.convertDate(r.end_date),
start_date: this.convertDate(r.start_date),
experiment_id: r.experiment_id,
variation_id: r.variation_id,
};
@@ -594,7 +598,7 @@ export default abstract class SqlIntegration
if (date) {
ret.dates = ret.dates || [];
ret.dates.push({
date,
date: this.convertDate(date).toISOString(),
users: parseInt(users) || 0,
});
} else {
@@ -616,7 +620,7 @@ export default abstract class SqlIntegration
if (date) {
ret.dates = ret.dates || [];
ret.dates.push({
date,
date: this.convertDate(date).toISOString(),
count: parseInt(count) || 0,
mean: parseFloat(mean) || 0,
stddev: parseFloat(stddev) || 0,