alihan/humanlayer
1
0
Fork 0
mirror of https://github.com/humanlayer/humanlayer.git synced 2025-08-20 19:01:22 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #433 from samdickson22/sam/eng-1887-remove-snapshot-based-diff-rendering-failed-console-log

Browse Source 
sam/eng-1887 - fix: suppress noisy snapshot-based diff rendering console warning
This commit is contained in:
Dex
2025-08-14 11:35:59 -05:00
committed by GitHub
parent 3f0be0fbf9 69e00845e1
commit 7010811ca3
2 changed files with 28 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
hld/session/manager.go
View File

@@ -657,10 +657,10 @@ func (m *Manager) processStreamEvent(ctx context.Context, sessionID string, clau
m.eventBus.Publish(bus.Event{
Type: bus.EventSessionStatusChanged,
Data: map[string]interface{}{
"session_id": sessionID,
"new_status": currentStatus, // Required by UI handler
"old_status": currentStatus, // Status isn't changing, just tokens
"reason": "token_update",
"session_id": sessionID,
"new_status": currentStatus, // Required by UI handler
"old_status": currentStatus, // Status isn't changing, just tokens
"reason": "token_update",
},
})
}

37
humanlayer-wui/src/components/internal/SessionDetail/components/CustomDiffViewer.tsx
View File

@@ -1,6 +1,28 @@
import React, { Fragment } from 'react'
import { logger } from '@/lib/logging'
// --- Debug utilities ---
// Preserved for debugging - uncomment the invocation below to enable
// @ts-expect-error - Intentionally unused, preserved for debugging
// eslint-disable-next-line @typescript-eslint/no-unused-vars
function debugLogSnapshotFailure(
error: unknown,
edits: { oldValue: string; newValue: string }[],
fileContents?: string,
) {
logger.warn('Snapshot-based diff rendering failed, falling back to simple diff:', {
error: error instanceof Error ? error.message : String(error),
editsCount: edits.length,
fileContentLength: fileContents?.length,
firstEditPreview: edits[0]
? {
oldValue: edits[0].oldValue.substring(0, 50) + '...',
newValue: edits[0].newValue.substring(0, 50) + '...',
}
: null,
})
}
// --- Minimal diff utilities (no third-party libraries) ---
function computeLineDiff(oldStr: string, newStr: string) {
// Returns an array of { type: 'equal'|'add'|'remove'|'replace', oldLine?: string, newLine?: string, oldIndex?: number, newIndex?: number }
@@ -600,19 +622,8 @@ export const CustomDiffViewer = ({
</div>
</div>
)
} catch (error) {
// Log detailed context for debugging
logger.warn('Snapshot-based diff rendering failed, falling back to simple diff:', {
error: error instanceof Error ? error.message : String(error),
editsCount: edits.length,
fileContentLength: fileContents?.length,
firstEditPreview: edits[0]
? {
oldValue: edits[0].oldValue.substring(0, 50) + '...',
newValue: edits[0].newValue.substring(0, 50) + '...',
}
: null,
})
} catch {
// debugLogSnapshotFailure(error, edits, fileContents) // uncomment to enable debug logging
// Recursively call self with undefined fileContents to trigger non-snapshot mode
return <CustomDiffViewer fileContents={undefined} edits={edits} splitView={splitView} />