GitHub Actions: Bump actions/{up,down}load-artifact from 3 to 4 (#7166)

* GitHub Actions: Bump actions/download-artifact from 3 to 4

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump `actions/upload-artifact` from v3 to v4

* Group dependency updates to both `actions/{up,down}load-artifact` in a single Dependabot PR

This should allow updating them in tandem, and prevent
similar issues from occurring again.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Armel Soro <asoro@redhat.com>

.github/dependabot.yml

@@ -60,6 +60,12 @@ updates:
   labels:
   - "area/dependency"
   - "kind/task"
+  groups:
+    # See https://github.blog/changelog/2023-06-30-grouped-version-updates-for-dependabot-public-beta/
+    artifact-management-actions:
+      patterns:
+        - "actions/upload-artifact"
+        - "actions/download-artifact"
 
 ## Feel free to add other package managers here if needed.
 ## See https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem

.github/workflows/ci-remote-clusters.yaml

@@ -50,7 +50,7 @@ jobs:
           chmod +x ./odo
           ./odo version
       - name: 'Upload odo'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: odo_bin
           path: odo
@@ -80,7 +80,7 @@ jobs:
       - name: Authenticate with IBM Cloud CLI
         run: ibmcloud login --apikey "${IBM_CLOUD_API_KEY}" --no-region --quiet
       - name: Download odo from previous job
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: odo_bin
       - name: Set odo in system path

.github/workflows/ci.yaml

@@ -48,7 +48,7 @@ jobs:
           chmod +x ./odo
           ./odo version
       - name: 'Upload odo'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: odo_bin
           path: odo
@@ -65,7 +65,7 @@ jobs:
         with:
           go-version-file: 'go.mod'
       - name: Download odo from previous job
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: odo_bin
       - name: Set odo in system path
@@ -97,7 +97,7 @@ jobs:
         with:
           go-version-file: 'go.mod'
       - name: Download odo from previous job
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: odo_bin
       - name: Set odo in system path
@@ -138,7 +138,7 @@ jobs:
         with:
           go-version-file: 'go.mod'
       - name: Download odo from previous job
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: odo_bin
       - name: Set odo in system path
@@ -228,7 +228,7 @@ jobs:
         with:
           go-version-file: 'go.mod'
       - name: Download odo from previous job
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: odo_bin
       - name: Set odo in system path

.github/workflows/pr-website.yaml

@@ -62,7 +62,7 @@ jobs:
           ./odo version
 
       - name: 'Upload odo'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: odo_bin
           path: odo
@@ -108,7 +108,7 @@ jobs:
           echo "DEPLOY_INGRESS_DOMAIN=$ingressDomain" >> "$GITHUB_ENV"
 
       - name: Download odo from previous job
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: odo_bin
 
@@ -187,7 +187,7 @@ jobs:
           ref: ${{ github.event.pull_request.head.sha || github.ref }}
 
       - name: Download odo from previous job
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: odo_bin
 

.github/workflows/release-management.yaml

@@ -31,7 +31,7 @@ jobs:
           ./scripts/changelog-script.sh ${{ steps.get_previous_tag.outputs.prev_tag }} ${TAG_NAME}
 
       - name: Upload Release Notes Artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: release-changelog
           path: release-changelog.md
@@ -54,7 +54,7 @@ jobs:
           fetch-depth: 0
 
       - run: mkdir -p /tmp/release-notes
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: release-changelog
           path: /tmp/release-notes
@@ -78,7 +78,7 @@ jobs:
           echo "blogFileName=${blogFileName}" >> $GITHUB_OUTPUT
 
       - name: Upload Release Notes Artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: release-blog-post-draft
           path: ${{ steps.generate_draft_blog_post.outputs.blogFileName }}

.github/workflows/ui-e2e.yaml

@@ -44,7 +44,7 @@ jobs:
           wait-on-timeout: 180
 
       # after the test run completes, store videos and any screenshots only upon a failure
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         if: failure()
         with:
           name: cypress-artifacts